Re: [Outreachy kernel] [PATCH v2 1/3] Staging: wilc1000: host_interface: Remove extra NULL test

[Arnd Bergmann <arnd@arndb.de>]

On Monday 12 October 2015 23:02:01 Shivani Bhardwaj wrote:
> Remove NULL test statement as it is preceded by another NULL test on the
> same variable in the code.
> Issue found using coccinelle.
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
> Changes in v2:
>         Deleted one patch and added another. Improved the other ones.
>  drivers/staging/wilc1000/host_interface.c | 3 ---
>  1 file changed, 3 deletions(-)

In the text above, it makes sense to provide an abbreviated
version of the semantic patch when you send something that was
generated by coccinelle.

> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index bb833d3..5e4d620 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -6044,12 +6044,9 @@ s32 host_int_deinit(tstrWILC_WFIDrv *hWFIDrv)
>         if (ret)
>                 s32Error = -ENOENT;
>  
> -       if (pstrWFIDrv != NULL) {
>                 kfree(pstrWFIDrv);
>                 /* pstrWFIDrv=NULL; */
>  
> -       }
> -

Now the indentation of the kfree() is wrong, it needs to go one tabstop
to the left. Also, the comment behind it can be removed in the same
patch.

	Arnd