All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs: remove useless ACL check
       [not found] <1396955388-4189-1-git-send-email-zhenzhang.zhang@huawei.com>
@ 2014-04-08 11:30 ` ZhangZhen
  0 siblings, 0 replies; only message in thread
From: ZhangZhen @ 2014-04-08 11:30 UTC (permalink / raw)
  To: jbacik; +Cc: linux-btrfs

posix_acl_xattr_set() already does the check, and it's the only
way to feed in an ACL from userspace.
So the check here is useless, remove it.

Signed-off-by: zhang zhen <zhenzhang.zhang@huawei.com>
---
 fs/btrfs/acl.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index ff9b399..9a0124a 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -79,13 +79,6 @@ static int __btrfs_set_acl(struct btrfs_trans_handle *trans,
 	const char *name;
 	char *value = NULL;

-	if (acl) {
-		ret = posix_acl_valid(acl);
-		if (ret < 0)
-			return ret;
-		ret = 0;
-	}
-
 	switch (type) {
 	case ACL_TYPE_ACCESS:
 		name = POSIX_ACL_XATTR_ACCESS;
-- 
1.6.0.2


.





^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-04-08 11:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1396955388-4189-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-04-08 11:30 ` [PATCH] btrfs: remove useless ACL check ZhangZhen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.