Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand

[Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>]

On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>> From: Murali Karicheri <m-karicheri2@ti.com>
>>
>> Sub page write doesn't work because of hw issue in controller found on
>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>
>> Cc: Brian Norris <computersforpeace@gmail.com>
>> Cc: Warner Losh <imp@bsdimp.com>
>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>> ---
>>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
>> This patch is a result of discussion on patch v1:
>> https://lkml.org/lkml/2014/3/20/461
>>
>>   drivers/mtd/nand/davinci_nand.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
>> index 4615d79..b922c8e 100644
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 = {
>>   #if defined(CONFIG_OF)
>>   static const struct of_device_id davinci_nand_of_match[] = {
>>   	{.compatible = "ti,davinci-nand", },
>> +	{.compatible = "ti,keystone-nand", },
>>   	{},
>>   };
>>   MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>> @@ -581,6 +582,11 @@ static struct davinci_nand_pdata
>>   		    of_property_read_bool(pdev->dev.of_node,
>>   			"ti,davinci-nand-use-bbt"))
>>   			pdata->bbt_options = NAND_BBT_USE_FLASH;
>> +
>> +		if (of_device_is_compatible(pdev->dev.of_node,
>> +					    "ti,keystone-nand")) {
>> +			pdata->options |= NAND_NO_SUBPAGE_WRITE;
>> +		}
>>   	}
>>   
>>   	return dev_get_platdata(&pdev->dev);
>>
>>

Brian,
Could you pick up subj patch?

-- 
Regards,
Ivan Khoronzhuk