From: Tomasz Figa <t.figa@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>,
Rahul Sharma <rahul.sharma@samsung.com>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
sunil joshi <joshi@samsung.com>,
Rahul Sharma <r.sh.open@gmail.com>,
Pankaj Dubey <pankaj.dubey@samsung.com>
Subject: Re: [PATCH v7 1/3] ARM: EXYNOS: initial board support for exynos5260 SoC
Date: Wed, 09 Apr 2014 11:04:41 +0200 [thread overview]
Message-ID: <53450D29.7020207@samsung.com> (raw)
In-Reply-To: <CAK9yfHzuVZh-RhfT+0tEehnF+aWnYHG=X2cv_E6uvzq2aS7UQg@mail.gmail.com>
On 07.04.2014 10:38, Sachin Kamat wrote:
> Hi Rahul,
>
> On 3 April 2014 15:30, Rahul Sharma <rahul.sharma@samsung.com> wrote:
>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>> This patch add basic arch side support for exynos5260 SoC.
> <snip>
>
>> @@ -374,6 +374,7 @@ static char const *exynos_dt_compat[] __initconst = {
>> "samsung,exynos4412",
>> "samsung,exynos5",
>> "samsung,exynos5250",
>> + "samsung,exynos5260",
>
> I don't think we should be adding this as we do not yet have any soc
> specific quirk.
> Compatibility to generic string, "samsung,exynos5" should be sufficient.
>
Yes. Unless a SoC specific quirk that needs to be handled at such low
level stage emerges, there is no need to add such compatible string to
the kernel.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 1/3] ARM: EXYNOS: initial board support for exynos5260 SoC
Date: Wed, 09 Apr 2014 11:04:41 +0200 [thread overview]
Message-ID: <53450D29.7020207@samsung.com> (raw)
In-Reply-To: <CAK9yfHzuVZh-RhfT+0tEehnF+aWnYHG=X2cv_E6uvzq2aS7UQg@mail.gmail.com>
On 07.04.2014 10:38, Sachin Kamat wrote:
> Hi Rahul,
>
> On 3 April 2014 15:30, Rahul Sharma <rahul.sharma@samsung.com> wrote:
>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>> This patch add basic arch side support for exynos5260 SoC.
> <snip>
>
>> @@ -374,6 +374,7 @@ static char const *exynos_dt_compat[] __initconst = {
>> "samsung,exynos4412",
>> "samsung,exynos5",
>> "samsung,exynos5250",
>> + "samsung,exynos5260",
>
> I don't think we should be adding this as we do not yet have any soc
> specific quirk.
> Compatibility to generic string, "samsung,exynos5" should be sufficient.
>
Yes. Unless a SoC specific quirk that needs to be handled at such low
level stage emerges, there is no need to add such compatible string to
the kernel.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-04-09 9:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 10:00 [PATCH v7 0/3] exynos: arch: add support for exynos5260 SoC Rahul Sharma
2014-04-03 10:00 ` Rahul Sharma
[not found] ` <1396519224-18712-1-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-03 10:00 ` [PATCH v7 1/3] ARM: EXYNOS: initial board " Rahul Sharma
2014-04-03 10:00 ` Rahul Sharma
2014-04-07 8:38 ` Sachin Kamat
2014-04-07 8:38 ` Sachin Kamat
2014-04-09 9:04 ` Tomasz Figa [this message]
2014-04-09 9:04 ` Tomasz Figa
2014-04-09 9:15 ` Rahul Sharma
2014-04-09 9:15 ` Rahul Sharma
2014-04-03 10:00 ` [PATCH v7 2/3] ARM: dts: add dts files " Rahul Sharma
2014-04-03 10:00 ` Rahul Sharma
2014-04-09 10:29 ` Tomasz Figa
2014-04-09 10:29 ` Tomasz Figa
2014-04-03 10:00 ` [PATCH v7 3/3] ARM: dts: add dts files for xyref5260 board Rahul Sharma
2014-04-03 10:00 ` Rahul Sharma
2014-04-07 8:40 ` Sachin Kamat
2014-04-07 8:40 ` Sachin Kamat
2014-04-09 10:52 ` Tomasz Figa
2014-04-09 10:52 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53450D29.7020207@samsung.com \
--to=t.figa@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=r.sh.open@gmail.com \
--cc=rahul.sharma@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.