From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Ulf Hansson <ulf.hansson@linaro.org>, Fabio Estevam <festevam@gmail.com>
Cc: Chris Ball <chris@printf.net>,
linux-mmc <linux-mmc@vger.kernel.org>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] mmc: card.h: Use NULL instead of 0 for END_FIXUP
Date: Wed, 09 Apr 2014 12:25:50 +0100 [thread overview]
Message-ID: <53452E3E.7020000@codethink.co.uk> (raw)
In-Reply-To: <CAPDyKFrGhX1R6HsVF_r=MTGXg_06xEe1WL3YCaywhKWq19TLFQ@mail.gmail.com>
On 09/04/14 10:33, Ulf Hansson wrote:
> On 5 April 2014 03:42, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Fix the following sparse warnings:
>>
>> drivers/mmc/card/block.c:2421:9: warning: Using plain integer as NULL pointer
>>
>> drivers/mmc/core/quirks.c:69:9: warning: Using plain integer as NULL pointer
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
>
>> ---
>> include/linux/mmc/card.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
>> index b730272..aa7e57f 100644
>> --- a/include/linux/mmc/card.h
>> +++ b/include/linux/mmc/card.h
>> @@ -353,7 +353,7 @@ struct mmc_fixup {
>> #define CID_OEMID_ANY ((unsigned short) -1)
>> #define CID_NAME_ANY (NULL)
>>
>> -#define END_FIXUP { 0 }
>> +#define END_FIXUP { NULL }
It would also be possible to use { } here.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
prev parent reply other threads:[~2014-04-09 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-05 1:42 [PATCH] mmc: card.h: Use NULL instead of 0 for END_FIXUP Fabio Estevam
2014-04-09 9:33 ` Ulf Hansson
2014-04-09 11:25 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53452E3E.7020000@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=chris@printf.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.