* [PATCH] mmc: card.h: Use NULL instead of 0 for END_FIXUP
@ 2014-04-05 1:42 Fabio Estevam
2014-04-09 9:33 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2014-04-05 1:42 UTC (permalink / raw)
To: chris; +Cc: ulf.hansson, linux-mmc, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Fix the following sparse warnings:
drivers/mmc/card/block.c:2421:9: warning: Using plain integer as NULL pointer
drivers/mmc/core/quirks.c:69:9: warning: Using plain integer as NULL pointer
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/linux/mmc/card.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
index b730272..aa7e57f 100644
--- a/include/linux/mmc/card.h
+++ b/include/linux/mmc/card.h
@@ -353,7 +353,7 @@ struct mmc_fixup {
#define CID_OEMID_ANY ((unsigned short) -1)
#define CID_NAME_ANY (NULL)
-#define END_FIXUP { 0 }
+#define END_FIXUP { NULL }
#define _FIXUP_EXT(_name, _manfid, _oemid, _rev_start, _rev_end, \
_cis_vendor, _cis_device, \
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: card.h: Use NULL instead of 0 for END_FIXUP
2014-04-05 1:42 [PATCH] mmc: card.h: Use NULL instead of 0 for END_FIXUP Fabio Estevam
@ 2014-04-09 9:33 ` Ulf Hansson
2014-04-09 11:25 ` Ben Dooks
0 siblings, 1 reply; 3+ messages in thread
From: Ulf Hansson @ 2014-04-09 9:33 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Chris Ball, linux-mmc, Fabio Estevam
On 5 April 2014 03:42, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Fix the following sparse warnings:
>
> drivers/mmc/card/block.c:2421:9: warning: Using plain integer as NULL pointer
>
> drivers/mmc/core/quirks.c:69:9: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> include/linux/mmc/card.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
> index b730272..aa7e57f 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -353,7 +353,7 @@ struct mmc_fixup {
> #define CID_OEMID_ANY ((unsigned short) -1)
> #define CID_NAME_ANY (NULL)
>
> -#define END_FIXUP { 0 }
> +#define END_FIXUP { NULL }
>
> #define _FIXUP_EXT(_name, _manfid, _oemid, _rev_start, _rev_end, \
> _cis_vendor, _cis_device, \
> --
> 1.8.3.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: card.h: Use NULL instead of 0 for END_FIXUP
2014-04-09 9:33 ` Ulf Hansson
@ 2014-04-09 11:25 ` Ben Dooks
0 siblings, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2014-04-09 11:25 UTC (permalink / raw)
To: Ulf Hansson, Fabio Estevam; +Cc: Chris Ball, linux-mmc, Fabio Estevam
On 09/04/14 10:33, Ulf Hansson wrote:
> On 5 April 2014 03:42, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Fix the following sparse warnings:
>>
>> drivers/mmc/card/block.c:2421:9: warning: Using plain integer as NULL pointer
>>
>> drivers/mmc/core/quirks.c:69:9: warning: Using plain integer as NULL pointer
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
>
>> ---
>> include/linux/mmc/card.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
>> index b730272..aa7e57f 100644
>> --- a/include/linux/mmc/card.h
>> +++ b/include/linux/mmc/card.h
>> @@ -353,7 +353,7 @@ struct mmc_fixup {
>> #define CID_OEMID_ANY ((unsigned short) -1)
>> #define CID_NAME_ANY (NULL)
>>
>> -#define END_FIXUP { 0 }
>> +#define END_FIXUP { NULL }
It would also be possible to use { } here.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-09 11:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-05 1:42 [PATCH] mmc: card.h: Use NULL instead of 0 for END_FIXUP Fabio Estevam
2014-04-09 9:33 ` Ulf Hansson
2014-04-09 11:25 ` Ben Dooks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.