All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Cc: Peter.Chen@freescale.com, stern@rowland.harvard.edu,
	thierry.reding@gmail.com, balbi@ti.com,
	linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-sh@vger.kernel.org, magnus.damm@gmail.com
Subject: Re: [PATCH 1/2] usb: rename 'phy' field of 'struct usb_hcd' to 'transceiver'
Date: Wed, 09 Apr 2014 09:31:06 -0600	[thread overview]
Message-ID: <534567BA.5030208@wwwdotorg.org> (raw)
In-Reply-To: <201404091757.16574.sergei.shtylyov@cogentembedded.com>

On 04/09/2014 07:57 AM, Sergei Shtylyov wrote:
> Return to the 'phy' field of 'struct usb_hcd' its historic name 'transceiver'. 
> This is in preparation to adding the generic PHY support.

Surely if the correct term is transceiver, we should be adding generic
transceiver support not generic PHY support? To be honest, this rename
feels like churn, especially since the APIs and DT bindings all still
include the work phy so now everything will be inconsistent.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Cc: Peter.Chen@freescale.com, stern@rowland.harvard.edu,
	thierry.reding@gmail.com, balbi@ti.com,
	linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-sh@vger.kernel.org, magnus.damm@gmail.com
Subject: Re: [PATCH 1/2] usb: rename 'phy' field of 'struct usb_hcd' to 'transceiver'
Date: Wed, 09 Apr 2014 15:31:06 +0000	[thread overview]
Message-ID: <534567BA.5030208@wwwdotorg.org> (raw)
In-Reply-To: <201404091757.16574.sergei.shtylyov@cogentembedded.com>

On 04/09/2014 07:57 AM, Sergei Shtylyov wrote:
> Return to the 'phy' field of 'struct usb_hcd' its historic name 'transceiver'. 
> This is in preparation to adding the generic PHY support.

Surely if the correct term is transceiver, we should be adding generic
transceiver support not generic PHY support? To be honest, this rename
feels like churn, especially since the APIs and DT bindings all still
include the work phy so now everything will be inconsistent.

  reply	other threads:[~2014-04-09 15:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 13:57 [PATCH 1/2] usb: rename 'phy' field of 'struct usb_hcd' to 'transceiver' Sergei Shtylyov
2014-04-09 13:57 ` Sergei Shtylyov
2014-04-09 15:31 ` Stephen Warren [this message]
2014-04-09 15:31   ` Stephen Warren
2014-04-09 16:27   ` Sergei Shtylyov
2014-04-09 16:27     ` Sergei Shtylyov
2014-04-09 16:48     ` Stephen Warren
2014-04-09 16:48       ` Stephen Warren
     [not found]       ` <534579D5.10306-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-04-09 16:53         ` Sergei Shtylyov
2014-04-09 16:53           ` Sergei Shtylyov
2014-04-09 17:37           ` Stephen Warren
2014-04-09 17:37             ` Stephen Warren
2014-04-09 17:52             ` Sergei Shtylyov
2014-04-09 17:52               ` Sergei Shtylyov
2014-04-09 17:56               ` Alan Stern
2014-04-09 17:56                 ` Alan Stern
2014-04-09 18:16                 ` Sergei Shtylyov
2014-04-09 18:16                   ` Sergei Shtylyov
     [not found]                   ` <53458E95.4080505-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-04-09 19:01                     ` Stephen Warren
2014-04-09 19:01                       ` Stephen Warren
     [not found]                       ` <534598EF.3010102-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-04-09 19:06                         ` Sergei Shtylyov
2014-04-09 19:06                           ` Sergei Shtylyov
2014-04-10  9:20                           ` David Laight
2014-04-10 10:49                             ` Sergei Shtylyov
2014-04-10 10:49                               ` Sergei Shtylyov
2014-04-10 11:01                               ` Ben Dooks
2014-04-10 11:01                                 ` Ben Dooks
2014-04-10 11:14                                 ` David Laight
2014-04-10 11:20                                   ` Ben Dooks
2014-04-10 11:20                                     ` Ben Dooks
     [not found]                                   ` <063D6719AE5E284EB5DD2968C1650D6D0F6F44A4-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2014-04-10 12:40                                     ` Sergei Shtylyov
2014-04-10 12:40                                       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534567BA.5030208@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=Peter.Chen@freescale.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=stern@rowland.harvard.edu \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.