* WARNING ... drivers/gpu/drm/ttm/ttm_bo_vm.c... @ 2014-04-08 1:29 poma 2014-04-08 5:11 ` Fwd: " Thomas Hellstrom 2014-04-10 16:34 ` poma 0 siblings, 2 replies; 5+ messages in thread From: poma @ 2014-04-08 1:29 UTC (permalink / raw) To: Thomas Hellstrom; +Cc: Linux Kernel list, Mailing-List fedora-kernel ... Command line: initrd=initrd.img inst.stage2=hd:LABEL=Fedora\x20rawhide\x20x86_64 xdriver=modesetting BOOT_IMAGE=vmlinuz Kernel command line: initrd=initrd.img inst.stage2=hd:LABEL=Fedora\x20rawhide\x20x86_64 xdriver=modesetting BOOT_IMAGE=vmlinuz ... ------------[ cut here ]------------ WARNING: CPU: 1 PID: 1230 at drivers/gpu/drm/ttm/ttm_bo_vm.c:269 ttm_bo_vm_open+0x52/0x80 [ttm]() CPU: 1 PID: 1230 Comm: Xorg Not tainted 3.15.0-0.rc0.git9.1.fc21.x86_64 #1 Call Trace: [<ffffffff817db690>] dump_stack+0x4d/0x66 [<ffffffff81096b9d>] warn_slowpath_common+0x7d/0xa0 [<ffffffff81096cca>] warn_slowpath_null+0x1a/0x20 [<ffffffffa0250452>] ttm_bo_vm_open+0x52/0x80 [ttm] [<ffffffff810956fe>] copy_process.part.23+0x1b9e/0x1e90 [<ffffffff81095bb6>] do_fork+0xc6/0x4b0 [<ffffffff811de68f>] ? might_fault+0x5f/0xb0 [<ffffffff817ef695>] ? sysret_check+0x22/0x5d [<ffffffff81096026>] SyS_clone+0x16/0x20 [<ffffffff817efa49>] stub_clone+0x69/0x90 [<ffffffff817ef669>] ? system_call_fastpath+0x16/0x1b ---[ end trace bc31de8c9c4c4d52 ]--- ... https://bugzilla.redhat.com/show_bug.cgi?id=1085145 https://bugzilla.redhat.com/attachment.cgi?id=883813 poma ^ permalink raw reply [flat|nested] 5+ messages in thread
* Fwd: WARNING ... drivers/gpu/drm/ttm/ttm_bo_vm.c... 2014-04-08 1:29 WARNING ... drivers/gpu/drm/ttm/ttm_bo_vm.c poma @ 2014-04-08 5:11 ` Thomas Hellstrom 2014-04-09 18:54 ` David Herrmann 2014-04-10 16:34 ` poma 1 sibling, 1 reply; 5+ messages in thread From: Thomas Hellstrom @ 2014-04-08 5:11 UTC (permalink / raw) To: David Herrmann; +Cc: dri-devel@lists.freedesktop.org Hi, David, Are there any dev_mapping changes in 3.15 that could cause this? Do we know what happens to vma->vm_file->f_mapping during fork? Thanks, /Thomas -------- Original Message -------- Return-Path: pomidorabelisima@gmail.com Received: from zcs-prod-mta-3.vmware.com (LHLO zcs-prod-mta-3.vmware.com) (10.113.163.65) by zcs-prod-mbox-71.vmware.com with LMTP; Mon, 7 Apr 2014 18:29:31 -0700 (PDT) Received: from zcs-prod-mta-3.vmware.com (localhost.localdomain [127.0.0.1]) by zcs-prod-mta-3.vmware.com (Postfix) with ESMTP id 9967BE003B for <thellstrom@zimbra.vmware.com>; Mon, 7 Apr 2014 18:29:31 -0700 (PDT) Received: from sc9-mailhost1.vmware.com (sc9-mailhost1.vmware.com [10.113.161.71]) by zcs-prod-mta-3.vmware.com (Postfix) with ESMTP for <thellstrom@zimbra.vmware.com>; Mon, 7 Apr 2014 18:29:31 -0700 (PDT) Received: by sc9-mailhost1.vmware.com (Postfix) id 8755C184C4; Mon, 7 Apr 2014 18:29:31 -0700 (PDT) Delivered-To: thellstrom@vmware.com Received: from sc9-proofpoint-agent-3.vmware.com (sc9-proofpoint-agent-3.vmware.com [10.113.162.104]) by sc9-mailhost1.vmware.com (Postfix) with ESMTP id 83121184C3 for <thellstrom@vmware.com>; Mon, 7 Apr 2014 18:29:31 -0700 (PDT) Received: from pps.filterd (sc9-proofpoint-agent-3.vmware.com [127.0.0.1]) by sc9-proofpoint-agent-3.vmware.com (8.14.5/8.14.5) with SMTP id s381Pn6F017997 for <thellstrom@vmware.com>; Mon, 7 Apr 2014 18:29:31 -0700 Received: from sc9-mail1.vmware.com (lbv-sc9-t2prod2-int.vmware.com [10.113.160.246]) by sc9-proofpoint-agent-3.vmware.com with ESMTP id 1k3xxksc4u-1 for <thellstrom@vmware.com>; Mon, 07 Apr 2014 18:29:31 -0700 Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by sc9-mail1.vmware.com (Postfix) with ESMTPS id B13F7100AA for <thellstrom@vmware.com>; Mon, 7 Apr 2014 18:29:30 -0700 (PDT) Received: by mail-ee0-f41.google.com with SMTP id t10so104752eei.14 for <thellstrom@vmware.com>; Mon, 07 Apr 2014 18:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; bh=z/4ic61J+N58h1sNnKa7ijlyzlqumiv+OmAV1k7Tw6g=; b=P7A42QOEMi6FhfcjOe0dwJeY6JYz8IHyy3HxtJjuY7esBV2LpgRaukscH+Y4qs6VRt 7aKBqKbvOa5/nCbVFq+JB1nunRO/vjJHDiXpNIsZavQfUt3mLdhlHRdokRJSEK7n3Kwu 8fgbijRmWQNeu57Cyuvm3kb8Yc9EwL9cwnBN1MvnFBqprO0nOxttOFUmeDNnNdip8RPJ fPryZ2kL2KUOkzids0oWY/894DLdclmKgIdgfuGY7QicG2vLOPUdGMDrAVgAAIUQC065 UcreRin5BNvkTjN27WytMaqrMTQkcyQvKvyPUm9Hw5c2oz3b3u77DTIk0sd4D1yD5YCx h1/A== X-Received: by 10.14.37.8 with SMTP id x8mr442817eea.32.1396920568788; Mon, 07 Apr 2014 18:29:28 -0700 (PDT) Received: from localhost (iskon7169.duo.carnet.hr. [31.147.124.1]) by mx.google.com with ESMTPSA id w1sm1094486eel.16.2014.04.07.18.29.27 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 07 Apr 2014 18:29:27 -0700 (PDT) Message-ID: <534350F6.9050604@gmail.com> Date: Tue, 08 Apr 2014 03:29:26 +0200 From: poma <pomidorabelisima@gmail.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 To: Thomas Hellstrom <thellstrom@vmware.com> CC: Linux Kernel list <linux-kernel@vger.kernel.org>, Mailing-List fedora-kernel <kernel@lists.fedoraproject.org> Subject: WARNING ... drivers/gpu/drm/ttm/ttm_bo_vm.c... Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: Quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.96,1.0.14,0.0.0000 definitions=2014-04-08_01:2014-04-07,2014-04-08,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=quarantine_notspam policy=quarantine score=0 kscore.is_bulkscore=0 kscore.compositescore=0 circleOfTrustscore=0 compositescore=0.1038748133519 urlsuspect_oldscore=0.1038748133519 suspectscore=0 recipient_domain_to_sender_totalscore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 recipient_to_sender_totalscore=0 recipient_domain_to_sender_domain_totalscore=0 rbsscore=0.1038748133519 spamscore=0 recipient_to_sender_domain_totalscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1404070251 ... Command line: initrd=initrd.img inst.stage2=hd:LABEL=Fedora\x20rawhide\x20x86_64 xdriver=modesetting BOOT_IMAGE=vmlinuz Kernel command line: initrd=initrd.img inst.stage2=hd:LABEL=Fedora\x20rawhide\x20x86_64 xdriver=modesetting BOOT_IMAGE=vmlinuz ... ------------[ cut here ]------------ WARNING: CPU: 1 PID: 1230 at drivers/gpu/drm/ttm/ttm_bo_vm.c:269 ttm_bo_vm_open+0x52/0x80 [ttm]() CPU: 1 PID: 1230 Comm: Xorg Not tainted 3.15.0-0.rc0.git9.1.fc21.x86_64 #1 Call Trace: [<ffffffff817db690>] dump_stack+0x4d/0x66 [<ffffffff81096b9d>] warn_slowpath_common+0x7d/0xa0 [<ffffffff81096cca>] warn_slowpath_null+0x1a/0x20 [<ffffffffa0250452>] ttm_bo_vm_open+0x52/0x80 [ttm] [<ffffffff810956fe>] copy_process.part.23+0x1b9e/0x1e90 [<ffffffff81095bb6>] do_fork+0xc6/0x4b0 [<ffffffff811de68f>] ? might_fault+0x5f/0xb0 [<ffffffff817ef695>] ? sysret_check+0x22/0x5d [<ffffffff81096026>] SyS_clone+0x16/0x20 [<ffffffff817efa49>] stub_clone+0x69/0x90 [<ffffffff817ef669>] ? system_call_fastpath+0x16/0x1b ---[ end trace bc31de8c9c4c4d52 ]--- ... https://urldefense.proofpoint.com/v1/url?u=https://bugzilla.redhat.com/show_bug.cgi?id%3D1085145&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=l5Ago9ekmVFZ3c4M6eauqrJWGwjf6fTb%2BP3CxbBFkVM%3D%0A&m=qzmqZB43wxRmhSQAtnI%2Fbqma1jUQMsMmLd1b50enasE%3D%0A&s=82842365a6d3e47ba18fd138af399ad001681783f420ce0014b3b16de71b0ca9 https://urldefense.proofpoint.com/v1/url?u=https://bugzilla.redhat.com/attachment.cgi?id%3D883813&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=l5Ago9ekmVFZ3c4M6eauqrJWGwjf6fTb%2BP3CxbBFkVM%3D%0A&m=qzmqZB43wxRmhSQAtnI%2Fbqma1jUQMsMmLd1b50enasE%3D%0A&s=92bfe28702b038526aaecda7995a411aefc2631fbfe959a9c54f113d0541b9a3 poma ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: WARNING ... drivers/gpu/drm/ttm/ttm_bo_vm.c... 2014-04-08 5:11 ` Fwd: " Thomas Hellstrom @ 2014-04-09 18:54 ` David Herrmann 2014-04-09 19:21 ` Thomas Hellstrom 0 siblings, 1 reply; 5+ messages in thread From: David Herrmann @ 2014-04-09 18:54 UTC (permalink / raw) To: Thomas Hellstrom; +Cc: dri-devel@lists.freedesktop.org Hi Thomas On Tue, Apr 8, 2014 at 7:11 AM, Thomas Hellstrom <thellstrom@vmware.com> wrote: > Hi, David, > > Are there any dev_mapping changes in 3.15 that could cause this? > Do we know what happens to vma->vm_file->f_mapping during fork? Sorry, I was traveling. Yes, there have been changes, but I converted all drivers properly. We now set file->f_mapping in drm_fops.c to dev->anon_inode->i_mapping during open(). All the ttm stuff now sets ttm->dev_mapping to the same during ttm init so I have no idea why that assertion fails. The vmwgfx driver sets it correctly in vmw_driver_load() and I cannot find any code changing it. I also cannot reproduce it. Can you provide some more information? Like what is vma->vm_file set to? What is ttm->dev_mapping? What is drm_device->anon_inode->i_mapping? What is &drm_device->anon_inode->i_data? All these should _always_ be the same. Btw., grep'ping for '_mapping' usually shows all related code, which I reviewed and all looks good. Thanks David ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: WARNING ... drivers/gpu/drm/ttm/ttm_bo_vm.c... 2014-04-09 18:54 ` David Herrmann @ 2014-04-09 19:21 ` Thomas Hellstrom 0 siblings, 0 replies; 5+ messages in thread From: Thomas Hellstrom @ 2014-04-09 19:21 UTC (permalink / raw) To: David Herrmann; +Cc: dri-devel@lists.freedesktop.org Hi, David! Thanks for the reply. Actually I just got CC'd on the Fedora Bug. I haven't seen this either, so I can't provide more info... What I was thinking was that maybe after a fork, vma->vm_file->f_mapping of the child process wasn't set to the same value as the parent... /Thomas On 04/09/2014 08:54 PM, David Herrmann wrote: > Hi Thomas > > On Tue, Apr 8, 2014 at 7:11 AM, Thomas Hellstrom <thellstrom@vmware.com> wrote: >> Hi, David, >> >> Are there any dev_mapping changes in 3.15 that could cause this? >> Do we know what happens to vma->vm_file->f_mapping during fork? > Sorry, I was traveling. Yes, there have been changes, but I converted > all drivers properly. We now set file->f_mapping in drm_fops.c to > dev->anon_inode->i_mapping during open(). All the ttm stuff now sets > ttm->dev_mapping to the same during ttm init so I have no idea why > that assertion fails. The vmwgfx driver sets it correctly in > vmw_driver_load() and I cannot find any code changing it. > > I also cannot reproduce it. Can you provide some more information? > Like what is vma->vm_file set to? What is ttm->dev_mapping? What is > drm_device->anon_inode->i_mapping? What is > &drm_device->anon_inode->i_data? All these should _always_ be the > same. > > Btw., grep'ping for '_mapping' usually shows all related code, which I > reviewed and all looks good. > > Thanks > David ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: WARNING ... drivers/gpu/drm/ttm/ttm_bo_vm.c... 2014-04-08 1:29 WARNING ... drivers/gpu/drm/ttm/ttm_bo_vm.c poma 2014-04-08 5:11 ` Fwd: " Thomas Hellstrom @ 2014-04-10 16:34 ` poma 1 sibling, 0 replies; 5+ messages in thread From: poma @ 2014-04-10 16:34 UTC (permalink / raw) To: Thomas Hellstrom; +Cc: Linux Kernel list, Mailing-List fedora-kernel On 08.04.2014 03:29, poma wrote: > ... > Command line: initrd=initrd.img > inst.stage2=hd:LABEL=Fedora\x20rawhide\x20x86_64 xdriver=modesetting > BOOT_IMAGE=vmlinuz > Kernel command line: initrd=initrd.img > inst.stage2=hd:LABEL=Fedora\x20rawhide\x20x86_64 xdriver=modesetting > BOOT_IMAGE=vmlinuz > ... > ------------[ cut here ]------------ > WARNING: CPU: 1 PID: 1230 at drivers/gpu/drm/ttm/ttm_bo_vm.c:269 > ttm_bo_vm_open+0x52/0x80 [ttm]() > CPU: 1 PID: 1230 Comm: Xorg Not tainted 3.15.0-0.rc0.git9.1.fc21.x86_64 #1 > Call Trace: > [<ffffffff817db690>] dump_stack+0x4d/0x66 > [<ffffffff81096b9d>] warn_slowpath_common+0x7d/0xa0 > [<ffffffff81096cca>] warn_slowpath_null+0x1a/0x20 > [<ffffffffa0250452>] ttm_bo_vm_open+0x52/0x80 [ttm] > [<ffffffff810956fe>] copy_process.part.23+0x1b9e/0x1e90 > [<ffffffff81095bb6>] do_fork+0xc6/0x4b0 > [<ffffffff811de68f>] ? might_fault+0x5f/0xb0 > [<ffffffff817ef695>] ? sysret_check+0x22/0x5d > [<ffffffff81096026>] SyS_clone+0x16/0x20 > [<ffffffff817efa49>] stub_clone+0x69/0x90 > [<ffffffff817ef669>] ? system_call_fastpath+0x16/0x1b > ---[ end trace bc31de8c9c4c4d52 ]--- > ... > > https://bugzilla.redhat.com/show_bug.cgi?id=1085145 > https://bugzilla.redhat.com/attachment.cgi?id=883813 > Tested with: - linux-next commit 53101f8be33d9dab12a5994b154c2029fadaaab4 & - Rawhide 3.15.0-0.rc0.git10.1.fc21.x86_64 Both PASSED! poma ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-04-10 16:34 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-04-08 1:29 WARNING ... drivers/gpu/drm/ttm/ttm_bo_vm.c poma 2014-04-08 5:11 ` Fwd: " Thomas Hellstrom 2014-04-09 18:54 ` David Herrmann 2014-04-09 19:21 ` Thomas Hellstrom 2014-04-10 16:34 ` poma
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.