From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Kevin Hilman <khilman@linaro.org>,
Tony Lindgren <tony@atomide.com>, Paul Walmsley <paul@pwsan.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>, Nishanth Menon <nm@ti.com>,
linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] gpio: omap: add a GPIO_OMAP option instead of using ARCH_OMAP
Date: Thu, 10 Apr 2014 13:37:15 -0400 [thread overview]
Message-ID: <5346D6CB.6070003@ti.com> (raw)
In-Reply-To: <1396796297-13002-4-git-send-email-javier.martinez@collabora.co.uk>
On Sunday 06 April 2014 10:58 AM, Javier Martinez Canillas wrote:
> The ARCH_OMAP config option was used to built the GPIO OMAP
> driver but this is not consistent with the rest of the GPIO
> drivers that have their own Kconfig option.
>
> Also, this make it harder to add dependencies or reverse
> dependencies (i.e: select) since that would mean touching the
> sub-arch config option.
>
> So is better to add a boolean Kconfig option for this driver
> that defaults to true if ARCH_OMAP is enabled.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] gpio: omap: add a GPIO_OMAP option instead of using ARCH_OMAP
Date: Thu, 10 Apr 2014 13:37:15 -0400 [thread overview]
Message-ID: <5346D6CB.6070003@ti.com> (raw)
In-Reply-To: <1396796297-13002-4-git-send-email-javier.martinez@collabora.co.uk>
On Sunday 06 April 2014 10:58 AM, Javier Martinez Canillas wrote:
> The ARCH_OMAP config option was used to built the GPIO OMAP
> driver but this is not consistent with the rest of the GPIO
> drivers that have their own Kconfig option.
>
> Also, this make it harder to add dependencies or reverse
> dependencies (i.e: select) since that would mean touching the
> sub-arch config option.
>
> So is better to add a boolean Kconfig option for this driver
> that defaults to true if ARCH_OMAP is enabled.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2014-04-10 17:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 14:58 [PATCH 0/5] GPIO OMAP driver changes for v3.16 Javier Martinez Canillas
2014-04-06 14:58 ` Javier Martinez Canillas
2014-04-06 14:58 ` [PATCH 1/5] gpio: omap: convert to use irq_domain_add_simple() Javier Martinez Canillas
2014-04-06 14:58 ` Javier Martinez Canillas
2014-04-10 17:35 ` Santosh Shilimkar
2014-04-10 17:35 ` Santosh Shilimkar
2014-04-06 14:58 ` [PATCH 2/5] gpio: omap: check gpiochip_add() return value Javier Martinez Canillas
2014-04-06 14:58 ` Javier Martinez Canillas
2014-04-10 17:36 ` Santosh Shilimkar
2014-04-10 17:36 ` Santosh Shilimkar
2014-04-06 14:58 ` [PATCH 3/5] gpio: omap: add a GPIO_OMAP option instead of using ARCH_OMAP Javier Martinez Canillas
2014-04-06 14:58 ` Javier Martinez Canillas
2014-04-10 17:37 ` Santosh Shilimkar [this message]
2014-04-10 17:37 ` Santosh Shilimkar
2014-04-06 14:58 ` [PATCH 4/5] gpio: omap: convert driver to use gpiolib irqchip Javier Martinez Canillas
2014-04-06 14:58 ` Javier Martinez Canillas
2014-04-10 17:39 ` Santosh Shilimkar
2014-04-10 17:39 ` Santosh Shilimkar
2014-04-10 17:45 ` Linus Walleij
2014-04-10 17:45 ` Linus Walleij
2014-04-10 18:58 ` Javier Martinez Canillas
2014-04-10 18:58 ` Javier Martinez Canillas
2014-04-06 14:58 ` [PATCH 5/5] MAINTAINERS: update GPIO OMAP driver entry Javier Martinez Canillas
2014-04-06 14:58 ` Javier Martinez Canillas
2014-04-10 17:29 ` [PATCH 0/5] GPIO OMAP driver changes for v3.16 Linus Walleij
2014-04-10 17:29 ` Linus Walleij
2014-04-10 19:30 ` Aaro Koskinen
2014-04-10 19:30 ` Aaro Koskinen
2014-04-10 20:17 ` Javier Martinez Canillas
2014-04-10 20:17 ` Javier Martinez Canillas
2014-04-10 21:22 ` Aaro Koskinen
2014-04-10 21:22 ` Aaro Koskinen
2014-04-11 15:03 ` Javier Martinez Canillas
2014-04-11 15:03 ` Javier Martinez Canillas
2014-04-22 13:00 ` Linus Walleij
2014-04-22 13:00 ` Linus Walleij
2014-04-23 21:48 ` Javier Martinez Canillas
2014-04-23 21:48 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5346D6CB.6070003@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=javier.martinez@collabora.co.uk \
--cc=khilman@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.