From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: r8a7790: link PCI USb devices to USB PHY
Date: Thu, 10 Apr 2014 18:46:47 +0000 [thread overview]
Message-ID: <5346E717.4040507@cogentembedded.com> (raw)
In-Reply-To: <534674B5.6080706@cogentembedded.com>
On 04/10/2014 02:38 PM, Sergei Shtylyov wrote:
>> Thanks for this patch, good to see that the relationship between the
>> USB Host and the PHY is described via DT.
>> This patch seems to cover USB0 and USB2 that both require special
>> control in the PHY. How about USB1? Can you explain about the reason
>> why you omit that?
> Because the driver does nothing for USB1 anyway.
Looks like I should have tested that last minute change: kernel oopses due
to NULL pointer dereference somewhere in phy_get() once it gets called for
EHCI on the channel #1. At least doesn't seem to be my mistake...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: r8a7790: link PCI USb devices to USB PHY
Date: Thu, 10 Apr 2014 22:46:47 +0400 [thread overview]
Message-ID: <5346E717.4040507@cogentembedded.com> (raw)
In-Reply-To: <534674B5.6080706@cogentembedded.com>
On 04/10/2014 02:38 PM, Sergei Shtylyov wrote:
>> Thanks for this patch, good to see that the relationship between the
>> USB Host and the PHY is described via DT.
>> This patch seems to cover USB0 and USB2 that both require special
>> control in the PHY. How about USB1? Can you explain about the reason
>> why you omit that?
> Because the driver does nothing for USB1 anyway.
Looks like I should have tested that last minute change: kernel oopses due
to NULL pointer dereference somewhere in phy_get() once it gets called for
EHCI on the channel #1. At least doesn't seem to be my mistake...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: "Simon Horman [Horms]" <horms@verge.net.au>,
SH-Linux <linux-sh@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
robh+dt@kernel.org, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
ijc+devicetree@hellion.org.uk, Kumar Gala <galak@codeaurora.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: shmobile: r8a7790: link PCI USb devices to USB PHY
Date: Thu, 10 Apr 2014 22:46:47 +0400 [thread overview]
Message-ID: <5346E717.4040507@cogentembedded.com> (raw)
In-Reply-To: <534674B5.6080706@cogentembedded.com>
On 04/10/2014 02:38 PM, Sergei Shtylyov wrote:
>> Thanks for this patch, good to see that the relationship between the
>> USB Host and the PHY is described via DT.
>> This patch seems to cover USB0 and USB2 that both require special
>> control in the PHY. How about USB1? Can you explain about the reason
>> why you omit that?
> Because the driver does nothing for USB1 anyway.
Looks like I should have tested that last minute change: kernel oopses due
to NULL pointer dereference somewhere in phy_get() once it gets called for
EHCI on the channel #1. At least doesn't seem to be my mistake...
WBR, Sergei
next prev parent reply other threads:[~2014-04-10 18:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 19:18 [PATCH] ARM: shmobile: r8a7790: link PCI USb devices to USB PHY Sergei Shtylyov
2014-04-09 19:18 ` Sergei Shtylyov
2014-04-09 19:18 ` Sergei Shtylyov
2014-04-10 7:07 ` Magnus Damm
2014-04-10 7:07 ` Magnus Damm
2014-04-10 7:07 ` Magnus Damm
2014-04-10 10:38 ` Sergei Shtylyov
2014-04-10 10:38 ` Sergei Shtylyov
2014-04-10 10:38 ` Sergei Shtylyov
2014-04-10 18:46 ` Sergei Shtylyov [this message]
2014-04-10 18:46 ` Sergei Shtylyov
2014-04-10 18:46 ` Sergei Shtylyov
2014-04-11 5:48 ` Magnus Damm
2014-04-11 5:48 ` Magnus Damm
2014-04-11 5:48 ` Magnus Damm
2014-04-11 11:39 ` Sergei Shtylyov
2014-04-11 11:39 ` Sergei Shtylyov
2014-04-11 11:39 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5346E717.4040507@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.