From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
Jim Keniston <jkenisto@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anton Arapov <aarapov@redhat.com>,
David Long <dave.long@linaro.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Jonathan Lebon <jlebon@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: Re: [RFC PATCH 4/6] uprobes/x86: Emulate rip-relative call's
Date: Fri, 11 Apr 2014 10:29:43 +0900 [thread overview]
Message-ID: <53474587.5080805@hitachi.com> (raw)
In-Reply-To: <20140410142820.GA24720@redhat.com>
(2014/04/10 23:28), Oleg Nesterov wrote:
> On 04/10, Masami Hiramatsu wrote:
>>
>> (2014/04/10 22:41), Denys Vlasenko wrote:
>>> On 04/09/2014 05:43 PM, Oleg Nesterov wrote:
>>>> On 04/08, Jim Keniston wrote:
>>>>>
>>>>> On Sun, 2014-04-06 at 22:16 +0200, Oleg Nesterov wrote:
>>>>>> 0xe8. Anything else?
>>>>>
>>>>> No, I think e8 is the only call instruction uprobes will see.
>>>>
>>>> Good.
>>>
>>> There is this monstrosity, "16-bit override for branches" in 64-mode:
>>>
>>> 66 e8 nn nn callw <offset16>
>>>
>>> Nobody sane uses it because it truncates instruction pointer.
>>
>> No problem, insn.c can handle that too. :)
>
> Does it?
>
> "callw 1f; 1:\n"
> "rep; nop\n"
>
> objdump:
>
> 66 e8 00 00 callw 485 <_init-0x3ffed3>
> f3 90 pause
>
>
> if we probe this "callw", we copy MAX_INSN_BYTES into auprobe->insn,
> and after insn_get_length() (insn_complete() == T)
>
> // this is correct
> OPCODE1() == e8
>
> // this all looks wrong
> insn->length == 6
> insn->immediate.value == -1863122944
> insn->immediate.nbytes == 4
Oops, that should be a bug in insn.c!
I'll fix that asap!
Thank you,
>
> so it seems that lib/insn.c treats the next "pause" insn as the high
> 16 bits of address.
>
> Oleg.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2014-04-11 1:29 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 18:50 [PATCH v2 0/9] uprobes/x86: preparations to fix the reprel jmp/call handling Oleg Nesterov
2014-04-04 18:51 ` [PATCH v2 1/9] uprobes: Kill UPROBE_SKIP_SSTEP and can_skip_sstep() Oleg Nesterov
2014-04-04 18:51 ` [PATCH v2 2/9] uprobes/x86: Fold prepare_fixups() into arch_uprobe_analyze_insn() Oleg Nesterov
2014-04-04 18:51 ` [PATCH v2 3/9] uprobes/x86: Kill the "ia32_compat" check in handle_riprel_insn(), remove "mm" arg Oleg Nesterov
2014-04-04 18:51 ` [PATCH v2 4/9] uprobes/x86: Gather "riprel" functions together Oleg Nesterov
2014-04-04 18:51 ` [PATCH v2 5/9] uprobes/x86: move the UPROBE_FIX_{RIP,IP,CALL} code at the end of pre/post hooks Oleg Nesterov
2014-04-04 18:51 ` [PATCH v2 6/9] uprobes/x86: Introduce uprobe_xol_ops and arch_uprobe->ops Oleg Nesterov
2014-04-08 9:10 ` Masami Hiramatsu
2014-04-08 16:10 ` Oleg Nesterov
2014-04-08 18:10 ` Oleg Nesterov
2014-04-09 12:58 ` Masami Hiramatsu
2014-04-09 16:55 ` Oleg Nesterov
2014-04-10 13:58 ` Masami Hiramatsu
2014-04-04 18:51 ` [PATCH v2 7/9] uprobes/x86: Conditionalize the usage of handle_riprel_insn() Oleg Nesterov
2014-04-04 18:51 ` [PATCH v2 8/9] uprobes/x86: Send SIGILL if arch_uprobe_post_xol() fails Oleg Nesterov
2014-04-04 18:51 ` [PATCH v2 9/9] uprobes/x86: Teach arch_uprobe_post_xol() to restart if possible Oleg Nesterov
2014-04-04 21:56 ` Jim Keniston
2014-04-05 12:46 ` Oleg Nesterov
2014-04-04 19:32 ` [PATCH v2 0/9] uprobes/x86: preparations to fix the reprel jmp/call handling Oleg Nesterov
2014-04-04 19:52 ` Oleg Nesterov
2014-04-04 23:44 ` Jim Keniston
2014-04-06 20:15 ` [RFC PATCH 0/6] uprobes/x86: " Oleg Nesterov
2014-04-06 20:16 ` [RFC PATCH 1/6] uprobes/x86: Emulate unconditional rip-relative jmp's Oleg Nesterov
2014-04-08 20:36 ` Jim Keniston
2014-04-09 14:47 ` Oleg Nesterov
2014-04-06 20:16 ` [RFC PATCH 2/6] uprobes/x86: Emulate nop's using ops->emulate() Oleg Nesterov
2014-04-06 20:16 ` [RFC PATCH 3/6] uprobes/x86: Introduce sizeof_long(), cleanup adjust_ret_addr() and arch_uretprobe_hijack_return_addr() Oleg Nesterov
2014-04-07 20:34 ` Jim Keniston
2014-04-07 20:42 ` Jim Keniston
2014-04-06 20:16 ` [RFC PATCH 4/6] uprobes/x86: Emulate rip-relative call's Oleg Nesterov
2014-04-08 22:26 ` Jim Keniston
2014-04-09 15:43 ` Oleg Nesterov
2014-04-09 21:25 ` Jim Keniston
2014-04-10 4:05 ` Jim Keniston
2014-04-10 13:41 ` Denys Vlasenko
2014-04-10 13:57 ` Masami Hiramatsu
2014-04-10 14:20 ` Denys Vlasenko
2014-04-11 3:03 ` Masami Hiramatsu
2014-04-11 12:23 ` Denys Vlasenko
2014-04-14 14:22 ` Masami Hiramatsu
2014-04-18 15:17 ` Denys Vlasenko
2014-04-10 14:28 ` Oleg Nesterov
2014-04-10 17:00 ` Oleg Nesterov
2014-04-11 2:38 ` Masami Hiramatsu
2014-04-11 1:29 ` Masami Hiramatsu [this message]
2014-04-10 14:18 ` Oleg Nesterov
2014-04-10 14:30 ` Denys Vlasenko
2014-04-10 17:02 ` Denys Vlasenko
2014-04-14 5:14 ` Masami Hiramatsu
2014-04-14 12:24 ` Denys Vlasenko
2014-04-14 14:05 ` Masami Hiramatsu
2014-04-06 20:16 ` [RFC PATCH 5/6] uprobes/x86: Emulate rip-relative conditional "short" jmp's Oleg Nesterov
2014-04-07 14:27 ` [RFC PATCH v2 " Oleg Nesterov
2014-04-07 16:41 ` Oleg Nesterov
2014-04-08 22:53 ` Jim Keniston
2014-04-09 16:42 ` Oleg Nesterov
2014-04-06 20:16 ` [RFC PATCH 6/6] uprobes/x86: Emulate rip-relative conditional "near" jmp's Oleg Nesterov
2014-04-07 14:28 ` Oleg Nesterov
2014-04-08 23:07 ` Jim Keniston
2014-04-09 16:50 ` Oleg Nesterov
2014-04-07 18:54 ` [RFC PATCH 0/6] uprobes/x86: fix the reprel jmp/call handling Jim Keniston
2014-04-08 11:43 ` Masami Hiramatsu
2014-04-08 16:28 ` Oleg Nesterov
2014-04-08 19:26 ` Oleg Nesterov
2014-04-09 19:44 ` [RFC PATCH v2 " Oleg Nesterov
2014-04-09 19:44 ` [RFC PATCH v2 1/6] uprobes/x86: Introduce sizeof_long(), cleanup adjust_ret_addr() and arch_uretprobe_hijack_return_addr() Oleg Nesterov
2014-04-09 19:44 ` [RFC PATCH v2 2/6] uprobes/x86: Emulate unconditional rip-relative jmp's Oleg Nesterov
2014-04-10 12:37 ` Denys Vlasenko
2014-04-10 13:47 ` Oleg Nesterov
2014-04-09 19:44 ` [RFC PATCH v2 3/6] uprobes/x86: Emulate nop's using ops->emulate() Oleg Nesterov
2014-04-09 19:44 ` [RFC PATCH v2 4/6] uprobes/x86: Emulate rip-relative call's Oleg Nesterov
2014-04-10 12:53 ` Denys Vlasenko
2014-04-10 13:15 ` Masami Hiramatsu
2014-04-10 13:41 ` Oleg Nesterov
2014-04-09 19:44 ` [RFC PATCH v2 5/6] uprobes/x86: Emulate rip-relative conditional "short" jmp's Oleg Nesterov
2014-04-09 19:44 ` [RFC PATCH v2 6/6] uprobes/x86: Emulate rip-relative conditional "near" jmp's Oleg Nesterov
2014-04-10 12:49 ` Denys Vlasenko
2014-04-09 21:34 ` [RFC PATCH v2 0/6] uprobes/x86: fix the reprel jmp/call handling Jim Keniston
2014-04-10 12:28 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53474587.5080805@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=aarapov@redhat.com \
--cc=ananth@in.ibm.com \
--cc=dave.long@linaro.org \
--cc=dvlasenk@redhat.com \
--cc=fche@redhat.com \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=jlebon@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.