From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH] x86/nested HAP: don't BUG() on legitimate error
Date: Fri, 11 Apr 2014 12:08:11 +0100 [thread overview]
Message-ID: <5347CD1B.5000809@citrix.com> (raw)
In-Reply-To: <5347DFDE0200007800007ECC@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 890 bytes --]
On 11/04/14 11:28, Jan Beulich wrote:
> set_p2m_entry() can fail without there being a bug in the code - crash
> the domain rather than the host in that case.
It would be useful to indicate which conditions.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Irrespective of the conditions causing a failed p2m update, this is
certainly a good change
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/mm/hap/nested_hap.c
> +++ b/xen/arch/x86/mm/hap/nested_hap.c
> @@ -133,7 +133,7 @@ nestedhap_fix_p2m(struct vcpu *v, struct
> gdprintk(XENLOG_ERR,
> "failed to set entry for %#"PRIx64" -> %#"PRIx64"\n",
> L2_gpa, L0_gpa);
> - BUG();
> + domain_crash(p2m->domain);
> }
> }
>
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 1968 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-04-11 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 10:28 [PATCH] x86/nested HAP: don't BUG() on legitimate error Jan Beulich
2014-04-11 11:08 ` Andrew Cooper [this message]
2014-04-11 11:41 ` Jan Beulich
2014-04-13 21:01 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5347CD1B.5000809@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.