All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"seth.heasley@intel.com" <seth.heasley@intel.com>,
	"khali@linux-fr.org" <khali@linux-fr.org>,
	"janet.morgan@intel.com" <janet.morgan@intel.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"mstowe@redhat.com" <mstowe@redhat.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH RFC] i2c algo, Add i2c-algo-i801 driver [v1]
Date: Fri, 11 Apr 2014 13:47:46 -0400	[thread overview]
Message-ID: <53482AC2.2060605@redhat.com> (raw)
In-Reply-To: <1397161609.5276.32.camel@x230>



On 04/10/2014 04:26 PM, Matthew Garrett wrote:
> On Thu, 2014-04-10 at 15:15 -0400, Prarit Bhargava wrote:
>>
>> On 04/09/2014 01:09 PM, Matthew Garrett wrote:
>>> Not really. These are an internal implementation detail, not an exported
>>> interface. We try to write drivers for exported interfaces, even if
>>> they're not documented.
>>
>> Aren't the methods the exported interface?  I'm obviously missing something :)
> 
> No. The device doesn't have a _HID(), so they're internal methods.
> 
>>> Imagine an i2c chip with indexed register access. What stops:
>>>

I think I missed something in this example (and if I have this wrong, please say
so).

Are you saying *both* the old (pci-style) driver and my new driver (ACPI) are
loaded?  Or something else?

>
>>> CPU0 (i2c):		CPU1 (ACPI):
>>> SBWB register address
>>> 			SBWB register address
>>> SBRB register value
>>> 			SBRB register value
>>>
>>> and CPU0 getting back the wrong value?

P.

  reply	other threads:[~2014-04-11 17:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 16:22 [PATCH RFC] i2c algo, Add i2c-algo-i801 driver [v1] Prarit Bhargava
     [not found] ` <1397060563-30431-1-git-send-email-prarit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 16:36   ` Matthew Garrett
2014-04-09 17:02     ` Prarit Bhargava
     [not found]       ` <53457D0D.7020805-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 17:09         ` Matthew Garrett
2014-04-09 17:34           ` Prarit Bhargava
     [not found]             ` <5345849F.6070909-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 17:37               ` Matthew Garrett
2014-04-09 17:55                 ` Prarit Bhargava
     [not found]                   ` <53458992.4060003-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 17:59                     ` Matthew Garrett
2014-04-09 18:02                       ` Prarit Bhargava
     [not found]                         ` <53458B2A.30003-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 18:27                           ` Matthew Garrett
2014-04-09 19:22                       ` Jean Delvare
2014-04-09 19:24                         ` Matthew Garrett
2014-04-09 19:01           ` Jean Delvare
2014-04-09 19:05             ` Matthew Garrett
2014-04-10 19:15           ` Prarit Bhargava
2014-04-10 20:26             ` Matthew Garrett
2014-04-11 17:47               ` Prarit Bhargava [this message]
     [not found]                 ` <53482AC2.2060605-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-11 18:55                   ` Matthew Garrett
2014-04-09 18:56     ` Jean Delvare
2014-04-09 18:58       ` Matthew Garrett
2014-04-09 20:25         ` Jean Delvare
2014-04-09 16:37   ` Jean Delvare
2014-04-09 16:57     ` Prarit Bhargava
     [not found]       ` <53457C00.1030400-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 20:27         ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53482AC2.2060605@redhat.com \
    --to=prarit@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=janet.morgan@intel.com \
    --cc=khali@linux-fr.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    --cc=mstowe@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=seth.heasley@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.