From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Nicholas A. Bellinger" <nab@daterainc.com>,
target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Sagi Grimberg <sagig@mellanox.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Sagi Grimberg <sagig@dev.mellanox.co.il>
Subject: Re: [PATCH 1/6] virtio-scsi.h: Add virtio_scsi_cmd_req_pi + VIRTIO_SCSI_F_T10_PI bits
Date: Sat, 12 Apr 2014 21:18:38 -0400 [thread overview]
Message-ID: <5349E5EE.2080709@redhat.com> (raw)
In-Reply-To: <20140409132239.GE10874@redhat.com>
Il 09/04/2014 09:22, Michael S. Tsirkin ha scritto:
>> > The interface uses bytes instead of iovecs as the unit, and
>> > vhost-scsi can add the (temporary...) requirement that do_pi_nbytes
>> > and di_pi_nbytes comprise an integer number of iovecs.
>> >
>> > Paolo
> That would be a reasonable intermediate step, but I'm worried there
> are more assumptions lurking in tere.
>
> In particular is it legal for PI to be in the same iov
> entry as data? If not they really need to use a
> separate buf entry.
No, in fact that would mean that do/di_pi_nbytes are not an integer
number of iovecs.
Paolo
next prev parent reply other threads:[~2014-04-13 1:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 21:32 [PATCH 0/6] vhost/scsi: Add T10 PI SGL passthrough support Nicholas A. Bellinger
2014-04-06 21:32 ` [PATCH 1/6] virtio-scsi.h: Add virtio_scsi_cmd_req_pi + VIRTIO_SCSI_F_T10_PI bits Nicholas A. Bellinger
2014-04-07 9:55 ` Michael S. Tsirkin
2014-04-08 20:31 ` Paolo Bonzini
2014-04-09 13:22 ` Michael S. Tsirkin
2014-04-13 1:18 ` Paolo Bonzini [this message]
2014-04-06 21:32 ` [PATCH 2/6] vhost/scsi: Move sanity check into vhost_scsi_map_iov_to_sgl Nicholas A. Bellinger
2014-04-06 21:32 ` [PATCH 3/6] vhost/scsi: Add preallocation of protection SGLs Nicholas A. Bellinger
2014-04-06 21:32 ` [PATCH 4/6] vhost/scsi: Add T10 PI IOV -> SGL memory mapping logic Nicholas A. Bellinger
2014-04-06 21:32 ` [PATCH 5/6] vhost/scsi: Enable T10 PI IOV -> SGL memory mapping Nicholas A. Bellinger
2014-04-07 9:16 ` Michael S. Tsirkin
2014-04-08 20:36 ` Paolo Bonzini
2014-04-06 21:32 ` [PATCH 6/6] virtio-scsi: Enable DIF/DIX modes in SCSI host LLD Nicholas A. Bellinger
2014-04-07 8:03 ` Sagi Grimberg
2014-04-07 8:40 ` Nicholas A. Bellinger
2014-04-07 8:45 ` Michael S. Tsirkin
2014-04-07 8:56 ` Nicholas A. Bellinger
2014-04-07 9:02 ` Michael S. Tsirkin
2014-04-07 9:13 ` Nicholas A. Bellinger
2014-04-07 9:13 ` Nicholas A. Bellinger
2014-04-08 20:35 ` Paolo Bonzini
2014-04-08 20:35 ` Paolo Bonzini
2014-05-07 9:13 ` Michael S. Tsirkin
2014-05-19 19:07 ` Nicholas A. Bellinger
2014-05-19 19:15 ` Michael S. Tsirkin
2014-05-19 20:54 ` Nicholas A. Bellinger
2014-05-19 22:43 ` Michael S. Tsirkin
2014-05-19 20:54 ` Nicholas A. Bellinger
2014-05-20 8:35 ` Paolo Bonzini
2014-05-20 18:24 ` Nicholas A. Bellinger
2014-05-20 18:24 ` Nicholas A. Bellinger
2014-05-20 8:35 ` Paolo Bonzini
2014-05-19 19:07 ` Nicholas A. Bellinger
2014-04-07 8:56 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5349E5EE.2080709@redhat.com \
--to=pbonzini@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=nab@daterainc.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@dev.mellanox.co.il \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.