From: Paolo Bonzini <pbonzini@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: "Nicholas A. Bellinger" <nab@daterainc.com>,
target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Sagi Grimberg <sagig@mellanox.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Sagi Grimberg <sagig@dev.mellanox.co.il>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 6/6] virtio-scsi: Enable DIF/DIX modes in SCSI host LLD
Date: Tue, 20 May 2014 10:35:28 +0200 [thread overview]
Message-ID: <537B13D0.3030007@redhat.com> (raw)
In-Reply-To: <1400526423.10964.31.camel@haakon3.risingtidesystems.com>
Il 19/05/2014 21:07, Nicholas A. Bellinger ha scritto:
> Hi MST,
>
> So I've finally got some cycles to get back to this code, and wanted to
> verify the outstanding items you had previously raised:
>
> - Convert vhost-scsi to be independent of IOV layout using
> memcpy_fromiovecend. (Does this effect existing non PI virtio-scsi
> operation..?)
> - Report VIRTIO_F_ANY_LAYOUT feature bit to userspace.
> - Convert virtio_scsi_cmd_req_pi to bytes field instead of number of
> iovecs.
This is the only item really required, since the bytes field is what
will be in VIRTIO 1.0. The other would be nice to have, but not a
blocker for PI support.
> - Ensure virtio_scsi_cmd_req_pi is naturally aligned
mst already commented on this.
> - Figure out why QEMU is not acking (any) vhost-scsi feature bits
This is a separate bug, isn't it? It need not block PI support.
Paolo
next prev parent reply other threads:[~2014-05-20 8:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 21:32 [PATCH 0/6] vhost/scsi: Add T10 PI SGL passthrough support Nicholas A. Bellinger
2014-04-06 21:32 ` [PATCH 1/6] virtio-scsi.h: Add virtio_scsi_cmd_req_pi + VIRTIO_SCSI_F_T10_PI bits Nicholas A. Bellinger
2014-04-07 9:55 ` Michael S. Tsirkin
2014-04-08 20:31 ` Paolo Bonzini
2014-04-09 13:22 ` Michael S. Tsirkin
2014-04-13 1:18 ` Paolo Bonzini
2014-04-06 21:32 ` [PATCH 2/6] vhost/scsi: Move sanity check into vhost_scsi_map_iov_to_sgl Nicholas A. Bellinger
2014-04-06 21:32 ` [PATCH 3/6] vhost/scsi: Add preallocation of protection SGLs Nicholas A. Bellinger
2014-04-06 21:32 ` [PATCH 4/6] vhost/scsi: Add T10 PI IOV -> SGL memory mapping logic Nicholas A. Bellinger
2014-04-06 21:32 ` [PATCH 5/6] vhost/scsi: Enable T10 PI IOV -> SGL memory mapping Nicholas A. Bellinger
2014-04-07 9:16 ` Michael S. Tsirkin
2014-04-08 20:36 ` Paolo Bonzini
2014-04-06 21:32 ` [PATCH 6/6] virtio-scsi: Enable DIF/DIX modes in SCSI host LLD Nicholas A. Bellinger
2014-04-07 8:03 ` Sagi Grimberg
2014-04-07 8:40 ` Nicholas A. Bellinger
2014-04-07 8:45 ` Michael S. Tsirkin
2014-04-07 8:56 ` Nicholas A. Bellinger
2014-04-07 9:02 ` Michael S. Tsirkin
2014-04-07 9:13 ` Nicholas A. Bellinger
2014-04-08 20:35 ` Paolo Bonzini
2014-04-08 20:35 ` Paolo Bonzini
2014-04-07 9:13 ` Nicholas A. Bellinger
2014-05-07 9:13 ` Michael S. Tsirkin
2014-05-19 19:07 ` Nicholas A. Bellinger
2014-05-19 19:15 ` Michael S. Tsirkin
2014-05-19 20:54 ` Nicholas A. Bellinger
2014-05-19 22:43 ` Michael S. Tsirkin
2014-05-19 20:54 ` Nicholas A. Bellinger
2014-05-20 8:35 ` Paolo Bonzini
2014-05-20 8:35 ` Paolo Bonzini [this message]
2014-05-20 18:24 ` Nicholas A. Bellinger
2014-05-20 18:24 ` Nicholas A. Bellinger
2014-05-19 19:07 ` Nicholas A. Bellinger
2014-04-07 8:56 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B13D0.3030007@redhat.com \
--to=pbonzini@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=nab@daterainc.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@dev.mellanox.co.il \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.