From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: Al Viro <viro@ZenIV.linux.org.uk>, Chris Mason <clm@fb.com>
Cc: <linux-btrfs@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC] odd thing in btrfs_file_aio_write()
Date: Mon, 14 Apr 2014 10:35:08 +0800 [thread overview]
Message-ID: <534B495C.6060504@cn.fujitsu.com> (raw)
In-Reply-To: <20140414002625.GQ18016@ZenIV.linux.org.uk>
Oh, that's my fault, I forgot that iov can be chained.
I should use 'pos + count' instead.
Thanks for pointing it out.
Qu.
-------- Original Message --------
Subject: [RFC] odd thing in btrfs_file_aio_write()
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Chris Mason <clm@fb.com>
Date: 2014年04月14日 08:26
> end_pos = round_up(pos + iov->iov_len, root->sectorsize);
>
> added in commit 3ac0d7b96a268a98bd474cab8bce3a9f125aaccf
> Author: Qu Wenruo <quwenruo@cn.fujitsu.com>
> Date: Thu Mar 27 02:51:58 2014 +0000
>
> btrfs: Change the expanding write sequence to fix snapshot related bug.
>
> doesn't look right - after all, just split the first iovec in the array
> and end_pos will go down. Do we want pos + count instead of
> pos + iov->iov_len there?
WARNING: multiple messages have this Message-ID (diff)
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: Al Viro <viro@ZenIV.linux.org.uk>, Chris Mason <clm@fb.com>
Cc: <linux-btrfs@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC] odd thing in btrfs_file_aio_write()
Date: Mon, 14 Apr 2014 10:35:08 +0800 [thread overview]
Message-ID: <534B495C.6060504@cn.fujitsu.com> (raw)
In-Reply-To: <20140414002625.GQ18016@ZenIV.linux.org.uk>
Oh, that's my fault, I forgot that iov can be chained.
I should use 'pos + count' instead.
Thanks for pointing it out.
Qu.
-------- Original Message --------
Subject: [RFC] odd thing in btrfs_file_aio_write()
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Chris Mason <clm@fb.com>
Date: 2014年04月14日 08:26
> end_pos = round_up(pos + iov->iov_len, root->sectorsize);
>
> added in commit 3ac0d7b96a268a98bd474cab8bce3a9f125aaccf
> Author: Qu Wenruo <quwenruo@cn.fujitsu.com>
> Date: Thu Mar 27 02:51:58 2014 +0000
>
> btrfs: Change the expanding write sequence to fix snapshot related bug.
>
> doesn't look right - after all, just split the first iovec in the array
> and end_pos will go down. Do we want pos + count instead of
> pos + iov->iov_len there?
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-14 2:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 0:26 [RFC] odd thing in btrfs_file_aio_write() Al Viro
2014-04-14 2:35 ` Qu Wenruo [this message]
2014-04-14 2:35 ` Qu Wenruo
2014-04-14 2:48 ` Al Viro
2014-04-14 3:36 ` Qu Wenruo
2014-04-14 3:36 ` Qu Wenruo
2014-04-14 5:08 ` Al Viro
2014-04-14 7:21 ` Qu Wenruo
2014-04-14 7:21 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534B495C.6060504@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.