* [PATCH v2 1/7] mmc: dw_mmc: fix the max_blk_count in IDMAC
@ 2014-03-26 11:30 Seungwon Jeon
2014-04-14 7:30 ` Jaehoon Chung
0 siblings, 1 reply; 2+ messages in thread
From: Seungwon Jeon @ 2014-03-26 11:30 UTC (permalink / raw)
To: linux-mmc, linux-samsung-soc
Cc: 'Chris Ball', 'Kukjin Kim',
'Jaehoon Chung', 'Ulf Hansson',
'Alim Akhtar'
Even though 1MB is reserved for descriptor table in IDMAC,
the dw_mmc host driver is allowed to receive only maximum
128KB block length in one request. This is caused by setting
improper max_blk_count. It needs to be e adjusted so that
descriptor table is used fully. It is found that the performance
is improved with the increased the max_blk_count.
Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 3a6721e..aeb38f9 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -2101,9 +2101,9 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
#ifdef CONFIG_MMC_DW_IDMAC
mmc->max_segs = host->ring_size;
mmc->max_blk_size = 65536;
- mmc->max_blk_count = host->ring_size;
mmc->max_seg_size = 0x1000;
- mmc->max_req_size = mmc->max_seg_size * mmc->max_blk_count;
+ mmc->max_req_size = mmc->max_seg_size * host->ring_size;
+ mmc->max_blk_count = mmc->max_req_size / 512;
#else
mmc->max_segs = 64;
mmc->max_blk_size = 65536; /* BLKSIZ is 16 bits */
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/7] mmc: dw_mmc: fix the max_blk_count in IDMAC
2014-03-26 11:30 [PATCH v2 1/7] mmc: dw_mmc: fix the max_blk_count in IDMAC Seungwon Jeon
@ 2014-04-14 7:30 ` Jaehoon Chung
0 siblings, 0 replies; 2+ messages in thread
From: Jaehoon Chung @ 2014-04-14 7:30 UTC (permalink / raw)
To: Seungwon Jeon, linux-mmc, linux-samsung-soc
Cc: 'Chris Ball', 'Kukjin Kim', 'Ulf Hansson',
'Alim Akhtar'
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 03/26/2014 08:30 PM, Seungwon Jeon wrote:
> Even though 1MB is reserved for descriptor table in IDMAC,
> the dw_mmc host driver is allowed to receive only maximum
> 128KB block length in one request. This is caused by setting
> improper max_blk_count. It needs to be e adjusted so that
> descriptor table is used fully. It is found that the performance
> is improved with the increased the max_blk_count.
>
> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 3a6721e..aeb38f9 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2101,9 +2101,9 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
> #ifdef CONFIG_MMC_DW_IDMAC
> mmc->max_segs = host->ring_size;
> mmc->max_blk_size = 65536;
> - mmc->max_blk_count = host->ring_size;
> mmc->max_seg_size = 0x1000;
> - mmc->max_req_size = mmc->max_seg_size * mmc->max_blk_count;
> + mmc->max_req_size = mmc->max_seg_size * host->ring_size;
> + mmc->max_blk_count = mmc->max_req_size / 512;
> #else
> mmc->max_segs = 64;
> mmc->max_blk_size = 65536; /* BLKSIZ is 16 bits */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-14 7:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-26 11:30 [PATCH v2 1/7] mmc: dw_mmc: fix the max_blk_count in IDMAC Seungwon Jeon
2014-04-14 7:30 ` Jaehoon Chung
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.