* [PATCH v2 2/7] mmc: dw_mmc: exynos: don't use if clock isn't available
@ 2014-03-26 11:31 Seungwon Jeon
2014-04-14 7:30 ` Jaehoon Chung
0 siblings, 1 reply; 2+ messages in thread
From: Seungwon Jeon @ 2014-03-26 11:31 UTC (permalink / raw)
To: linux-samsung-soc, linux-mmc
Cc: 'Chris Ball', 'Kukjin Kim',
'Jaehoon Chung', 'Ulf Hansson',
'Alim Akhtar'
Add checking whether the clock is valid.
Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
---
drivers/mmc/host/dw_mmc-exynos.c | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index a67e784..a2d06c5 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -117,9 +117,9 @@ static int dw_mci_exynos_priv_init(struct dw_mci *host)
static int dw_mci_exynos_setup_clock(struct dw_mci *host)
{
struct dw_mci_exynos_priv_data *priv = host->priv;
- unsigned long rate = clk_get_rate(host->ciu_clk);
- host->bus_hz = rate / (priv->ciu_div + 1);
+ host->bus_hz /= (priv->ciu_div + 1);
+
return 0;
}
@@ -196,8 +196,11 @@ static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios)
mci_writel(host, CLKSEL, priv->sdr_timing);
}
- /* Don't care if wanted clock is zero */
- if (!wanted)
+ /*
+ * Don't care if wanted clock is zero or
+ * ciu clock is unavailable
+ */
+ if (!wanted || IS_ERR(host->ciu_clk))
return;
/* Guaranteed minimum frequency for cclkin */
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2 2/7] mmc: dw_mmc: exynos: don't use if clock isn't available
2014-03-26 11:31 [PATCH v2 2/7] mmc: dw_mmc: exynos: don't use if clock isn't available Seungwon Jeon
@ 2014-04-14 7:30 ` Jaehoon Chung
0 siblings, 0 replies; 2+ messages in thread
From: Jaehoon Chung @ 2014-04-14 7:30 UTC (permalink / raw)
To: Seungwon Jeon, linux-samsung-soc, linux-mmc
Cc: 'Chris Ball', 'Kukjin Kim', 'Ulf Hansson',
'Alim Akhtar'
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 03/26/2014 08:31 PM, Seungwon Jeon wrote:
> Add checking whether the clock is valid.
>
> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 11 +++++++----
> 1 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index a67e784..a2d06c5 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -117,9 +117,9 @@ static int dw_mci_exynos_priv_init(struct dw_mci *host)
> static int dw_mci_exynos_setup_clock(struct dw_mci *host)
> {
> struct dw_mci_exynos_priv_data *priv = host->priv;
> - unsigned long rate = clk_get_rate(host->ciu_clk);
>
> - host->bus_hz = rate / (priv->ciu_div + 1);
> + host->bus_hz /= (priv->ciu_div + 1);
> +
> return 0;
> }
>
> @@ -196,8 +196,11 @@ static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios)
> mci_writel(host, CLKSEL, priv->sdr_timing);
> }
>
> - /* Don't care if wanted clock is zero */
> - if (!wanted)
> + /*
> + * Don't care if wanted clock is zero or
> + * ciu clock is unavailable
> + */
> + if (!wanted || IS_ERR(host->ciu_clk))
> return;
>
> /* Guaranteed minimum frequency for cclkin */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-14 7:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-26 11:31 [PATCH v2 2/7] mmc: dw_mmc: exynos: don't use if clock isn't available Seungwon Jeon
2014-04-14 7:30 ` Jaehoon Chung
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.