From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Steven Miao <realmz6@kernel.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
adi-buildroot-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Steven Miao <realmz6@gmail.com>
Subject: Re: [PATCH] video: bf54x-lq043fb: fix build error
Date: Mon, 14 Apr 2014 12:44:00 +0000 [thread overview]
Message-ID: <534BD810.3010705@ti.com> (raw)
In-Reply-To: <1397266245-3144-1-git-send-email-realmz6@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On 12/04/14 04:30, Steven Miao wrote:
> From: Steven Miao <realmz6@gmail.com>
>
> should include linux/gpio.h
>
> Signed-off-by: Steven Miao <realmz6@gmail.com>
> ---
> drivers/video/bf54x-lq043fb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
> index 42b8f9d..d2b54f1 100644
> --- a/drivers/video/bf54x-lq043fb.c
> +++ b/drivers/video/bf54x-lq043fb.c
> @@ -49,6 +49,7 @@
> #include <linux/spinlock.h>
> #include <linux/dma-mapping.h>
> #include <linux/platform_device.h>
> +#include <linux/gpio.h>
The driver includes <asm/gpio.h>. I think that should be removed, and
<linux/gpio.h> should be used.
Can you also remove the asm/gpio.h in your patch, and see if it compiles
fine?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Steven Miao <realmz6@kernel.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
<adi-buildroot-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>, <linux-fbdev@vger.kernel.org>,
Steven Miao <realmz6@gmail.com>
Subject: Re: [PATCH] video: bf54x-lq043fb: fix build error
Date: Mon, 14 Apr 2014 15:44:00 +0300 [thread overview]
Message-ID: <534BD810.3010705@ti.com> (raw)
In-Reply-To: <1397266245-3144-1-git-send-email-realmz6@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On 12/04/14 04:30, Steven Miao wrote:
> From: Steven Miao <realmz6@gmail.com>
>
> should include linux/gpio.h
>
> Signed-off-by: Steven Miao <realmz6@gmail.com>
> ---
> drivers/video/bf54x-lq043fb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
> index 42b8f9d..d2b54f1 100644
> --- a/drivers/video/bf54x-lq043fb.c
> +++ b/drivers/video/bf54x-lq043fb.c
> @@ -49,6 +49,7 @@
> #include <linux/spinlock.h>
> #include <linux/dma-mapping.h>
> #include <linux/platform_device.h>
> +#include <linux/gpio.h>
The driver includes <asm/gpio.h>. I think that should be removed, and
<linux/gpio.h> should be used.
Can you also remove the asm/gpio.h in your patch, and see if it compiles
fine?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-14 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 1:30 [PATCH] video: bf54x-lq043fb: fix build error Steven Miao
2014-04-12 1:30 ` Steven Miao
2014-04-14 12:44 ` Tomi Valkeinen [this message]
2014-04-14 12:44 ` Tomi Valkeinen
2014-04-15 6:35 ` Steven Miao
2014-04-15 6:35 ` Steven Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534BD810.3010705@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=realmz6@gmail.com \
--cc=realmz6@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.