From: "H. Peter Anvin" <hpa@zytor.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>,
x86@kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com,
tglx@linutronix.de, JBeulich@suse.com
Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately
Date: Mon, 14 Apr 2014 10:02:03 -0700 [thread overview]
Message-ID: <534C148B.30005@zytor.com> (raw)
In-Reply-To: <1397497584-23717-1-git-send-email-kys@microsoft.com>
On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> This patch implements the proposal put forth by H. Peter Anvin <hpa@linux.intel.com>.
>
> In version V1 of the patch, I had cleaned up the code based on comments from Peter.
> In version V2 of the patch, I have addressed additional comments from Peter.
> In this version of the patch, I have addressed Jan's comments (JBeulich@suse.com).
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Technically the patch looks good, but I'm going to have to reject it
based on the patch description.
Keep in mind that the above description is the only thing that would go
into the git repository, and needs to be understandable to someone, say,
10 years from now.
The above says nothing about what the proposal was, and the motivation,
and the problems it addresses. So the patch is good, but please write a
proper, standalone description for it.
Thanks,
-hpa
next prev parent reply other threads:[~2014-04-14 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 17:46 [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately K. Y. Srinivasan
2014-04-14 17:02 ` H. Peter Anvin [this message]
2014-04-14 17:03 ` KY Srinivasan
2014-04-14 17:08 ` H. Peter Anvin
2014-04-14 17:09 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534C148B.30005@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@suse.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.