From: "H. Peter Anvin" <hpa@zytor.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>,
x86@kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com,
tglx@linutronix.de, JBeulich@suse.com
Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately
Date: Mon, 14 Apr 2014 10:08:02 -0700 [thread overview]
Message-ID: <534C15F2.105@zytor.com> (raw)
In-Reply-To: <1397497584-23717-1-git-send-email-kys@microsoft.com>
On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> + new_val = inb(PIC_MASTER_IMR);
> + if (probe_val != new_val) {
Nitpick: Linux coding style should have this as:
if (new_val != probe_val)
-hpa
next prev parent reply other threads:[~2014-04-14 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 17:46 [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately K. Y. Srinivasan
2014-04-14 17:02 ` H. Peter Anvin
2014-04-14 17:03 ` KY Srinivasan
2014-04-14 17:08 ` H. Peter Anvin [this message]
2014-04-14 17:09 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534C15F2.105@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@suse.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.