From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Michael Tokarev <mjt@tls.msk.ru>,
Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue'
Date: Tue, 15 Apr 2014 12:41:04 +0800 [thread overview]
Message-ID: <534CB860.7040408@gmail.com> (raw)
In-Reply-To: <CAEgOgz7ey1BCwEoewVGhUtcx34=P8POmKOkNJY=VdfJZHFiJmQ@mail.gmail.com>
On 04/15/2014 10:11 AM, Peter Crosthwaite wrote:
> On Tue, Apr 8, 2014 at 10:01 PM, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
>> > Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not
>> > need additional useless 'continue'.
>> >
> Only in the case where the if-else is not followed by any code. Which
> is the case here. I found this sentance slightly confusing and TBH id
> just drop it or say something less codey like:
>
> "This if else has no code between it and the end of the enclosing
> while loop. This makes this continue redundant."
>
>> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> But patch is good:
>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>
OK, thanks.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2014-04-15 4:41 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 1:16 [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator() Chen Gang
2014-03-27 7:55 ` Marcel Apfelbaum
2014-03-27 9:54 ` Chen Gang
2014-03-27 8:59 ` Markus Armbruster
2014-03-27 10:01 ` Chen Gang
2014-03-30 14:44 ` Chen Gang
2014-03-31 12:38 ` Markus Armbruster
2014-03-31 12:53 ` Chen Gang
2014-03-31 13:01 ` [Qemu-trivial] " Peter Maydell
2014-03-31 13:01 ` Peter Maydell
2014-03-31 13:12 ` [Qemu-trivial] " Chen Gang
2014-03-31 13:12 ` Chen Gang
2014-03-31 13:16 ` [Qemu-trivial] " Peter Maydell
2014-03-31 13:16 ` Peter Maydell
2014-03-31 13:26 ` [Qemu-trivial] " Chen Gang
2014-03-31 13:26 ` Chen Gang
2014-03-31 13:33 ` [Qemu-trivial] " Peter Maydell
2014-03-31 13:33 ` Peter Maydell
2014-03-31 23:50 ` [Qemu-trivial] " Chen Gang
2014-03-31 23:50 ` Chen Gang
2014-04-04 9:39 ` [Qemu-trivial] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely Chen Gang
2014-04-04 9:39 ` [Qemu-devel] " Chen Gang
2014-04-04 10:57 ` [Qemu-trivial] " Markus Armbruster
2014-04-04 10:57 ` Markus Armbruster
2014-04-06 12:30 ` [Qemu-trivial] " Chen Gang
2014-04-06 12:30 ` Chen Gang
2014-04-06 6:32 ` [Qemu-trivial] " Michael Tokarev
2014-04-06 6:32 ` [Qemu-devel] " Michael Tokarev
2014-04-06 12:32 ` Chen Gang
2014-04-06 12:32 ` [Qemu-devel] " Chen Gang
2014-04-08 12:00 ` [Qemu-trivial] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device() Chen Gang
2014-04-08 12:00 ` [Qemu-devel] " Chen Gang
2014-04-08 12:01 ` [Qemu-trivial] [PATCH trivial 1/3] vl: remove useless 'continue' Chen Gang
2014-04-08 12:01 ` [Qemu-devel] " Chen Gang
2014-04-08 12:02 ` [Qemu-trivial] [PATCH trivial 2/3] vl: remove redundant local variable 'res' Chen Gang
2014-04-08 12:02 ` [Qemu-devel] " Chen Gang
2014-04-08 12:05 ` [Qemu-trivial] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block Chen Gang
2014-04-08 12:05 ` [Qemu-devel] " Chen Gang
2014-04-15 8:56 ` [Qemu-trivial] " Markus Armbruster
2014-04-15 11:09 ` Chen Gang
2014-04-15 12:29 ` Peter Crosthwaite
2014-04-15 12:33 ` Chen Gang
2014-04-15 2:13 ` [Qemu-trivial] [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res' Peter Crosthwaite
2014-04-15 4:50 ` Chen Gang
2014-04-15 8:43 ` Markus Armbruster
2014-04-15 11:03 ` Chen Gang
2014-04-15 2:11 ` [Qemu-trivial] [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue' Peter Crosthwaite
2014-04-15 4:41 ` Chen Gang [this message]
2014-04-15 8:50 ` Markus Armbruster
2014-04-15 11:05 ` Chen Gang
2014-04-16 2:56 ` liang ding
2014-04-15 0:37 ` [Qemu-trivial] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device() Chen Gang
2014-04-15 8:49 ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2014-04-15 13:54 ` Chen Gang
2014-04-15 14:51 ` Markus Armbruster
2014-04-15 23:08 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534CB860.7040408@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.