Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()

[Chen Gang <gang.chen.5i5j@gmail.com>]

On 04/15/2014 04:49 PM, Markus Armbruster wrote:
> Chen Gang <gang.chen.5i5j@gmail.com> writes:
> 
>> In "vl.c", at least, we can simplify the code below, so can let readers
>> read professional C code (especially for new readers, which often start
>> reading code at main function).
>>
>>  - remove useless 'continue' in main().
>>
>>  - remove redundant local variable 'res' in get_boot_device().
>>
>>  - remove local variable 'args' in the middle of code block in main().
>>
>> The following 3 patches are for the 3 'remove' above.
>>
>> And "vl.c" has a very long function main() which is about 17K lines.
>> Next, it can be split into sub-functions (so can bypass another code
>> style issue: multiple "{...}" styles within "swith(...)").
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>>  vl.c |   23 ++++++++++-------------
>>  1 file changed, 10 insertions(+), 13 deletions(-)
> 
> In future submissions, please send the patches in-reply-to the cover
> letter, not chained together in-reply-to the previous part.  Check out
> git-send-email --no-chain-reply-to.
> 

OK, thanks. But excuse me, I use thunderbird client to send/recv mail
(not use git send-mail), so not quit understand what you said. And I
guess what your meaning is:

  - start a new thread "[PATH 0/3]..."

    - "[PATH 1/3]..." need "reply all" the "[PATH 0/3]..."

    - "[PATH 2/3]..." need "reply all" the "[PATH 0/3]..."

    - "[PATH 3/3]..." need "reply all" the "[PATH 0/3]..."


If what I guess is incorrect, please let me know, and it will be better
to provide more detials.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed