All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Fernandes <joelf@ti.com>
To: Nishanth Menon <nm@ti.com>, Joachim Eastwood <manabian@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	<linux-crypto@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	<linux-omap@vger.kernel.org>, <balbi@ti.com>
Subject: Re: [PATCH V2] crypto: omap-des - handle error of pm_runtime_get_sync
Date: Tue, 15 Apr 2014 12:51:43 -0500	[thread overview]
Message-ID: <534D71AF.2090808@ti.com> (raw)
In-Reply-To: <534D69D0.207@ti.com>

On 04/15/2014 12:18 PM, Nishanth Menon wrote:
> On 04/15/2014 12:06 PM, Joachim Eastwood wrote:
>> On 15 April 2014 18:58, Nishanth Menon <nm@ti.com> wrote:
>>> pm_runtime_get_sync may not always succeed depending on SoC involved.
>>> So handle the error appropriately ensuring usage_count is accurate in
>>> case of failure.
>>>
>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>> ---
>>> V2:
>>>         - review fixes, print function names in error log as well.
>>>
>>> V1: https://patchwork.kernel.org/patch/3993861/
>>>  drivers/crypto/omap-des.c |   26 +++++++++++++++++++++++---
>>>  1 file changed, 23 insertions(+), 3 deletions(-)
>>>
>>
>> Fixes the runtime warning from omap_l3_noc when omap-des is built-in
>> on my VAR-SOM-OM44 (OMAP4460) board.
>>
>> Tested-by: Joachim Eastwood <manabian@gmail.com>
> 
> Thanks Joachim. Looks like in my hurry, I missed proper
> acknowledgement of your report. adding the following for patchworks to
> pickup.
> 
> Reported-by: Joachim Eastwood <manabian@gmail.com>
> 

Acked-by: Joel Fernandes <joelf@ti.com>

Regards,
-Joel

WARNING: multiple messages have this Message-ID (diff)
From: Joel Fernandes <joelf@ti.com>
To: Nishanth Menon <nm@ti.com>, Joachim Eastwood <manabian@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-omap@vger.kernel.org, balbi@ti.com
Subject: Re: [PATCH V2] crypto: omap-des - handle error of pm_runtime_get_sync
Date: Tue, 15 Apr 2014 12:51:43 -0500	[thread overview]
Message-ID: <534D71AF.2090808@ti.com> (raw)
In-Reply-To: <534D69D0.207@ti.com>

On 04/15/2014 12:18 PM, Nishanth Menon wrote:
> On 04/15/2014 12:06 PM, Joachim Eastwood wrote:
>> On 15 April 2014 18:58, Nishanth Menon <nm@ti.com> wrote:
>>> pm_runtime_get_sync may not always succeed depending on SoC involved.
>>> So handle the error appropriately ensuring usage_count is accurate in
>>> case of failure.
>>>
>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>> ---
>>> V2:
>>>         - review fixes, print function names in error log as well.
>>>
>>> V1: https://patchwork.kernel.org/patch/3993861/
>>>  drivers/crypto/omap-des.c |   26 +++++++++++++++++++++++---
>>>  1 file changed, 23 insertions(+), 3 deletions(-)
>>>
>>
>> Fixes the runtime warning from omap_l3_noc when omap-des is built-in
>> on my VAR-SOM-OM44 (OMAP4460) board.
>>
>> Tested-by: Joachim Eastwood <manabian@gmail.com>
> 
> Thanks Joachim. Looks like in my hurry, I missed proper
> acknowledgement of your report. adding the following for patchworks to
> pickup.
> 
> Reported-by: Joachim Eastwood <manabian@gmail.com>
> 

Acked-by: Joel Fernandes <joelf@ti.com>

Regards,
-Joel

  reply	other threads:[~2014-04-15 17:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 15:33 [PATCH] crypto: omap-des - handle error of pm_runtime_get_sync Nishanth Menon
2014-04-15 15:33 ` Nishanth Menon
2014-04-15 15:50 ` Felipe Balbi
2014-04-15 15:50   ` Felipe Balbi
2014-04-15 16:44   ` Nishanth Menon
2014-04-15 16:44     ` Nishanth Menon
2014-04-15 16:58     ` [PATCH V2] " Nishanth Menon
2014-04-15 16:58       ` Nishanth Menon
2014-04-15 17:05       ` Felipe Balbi
2014-04-15 17:05         ` Felipe Balbi
2014-04-15 17:06       ` Joachim Eastwood
2014-04-15 17:18         ` Nishanth Menon
2014-04-15 17:18           ` Nishanth Menon
2014-04-15 17:51           ` Joel Fernandes [this message]
2014-04-15 17:51             ` Joel Fernandes
2014-04-16 13:50             ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534D71AF.2090808@ti.com \
    --to=joelf@ti.com \
    --cc=balbi@ti.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=manabian@gmail.com \
    --cc=nm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.