From: Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Shaik Ameer Basha
<shaik.ameer-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
joshi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
shaik.samsung-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
r.sh.open-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Rahul Sharma
<rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v2 7/7] ARM: dts: update macros in clock bindings for exynos5420
Date: Tue, 15 Apr 2014 20:01:48 +0200 [thread overview]
Message-ID: <534D740C.2060904@gmail.com> (raw)
In-Reply-To: <1395918470-16374-8-git-send-email-shaik.ameer-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Hi Shaik,
On 27.03.2014 12:07, Shaik Ameer Basha wrote:
> From: Rahul Sharma <rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> This patch updates the macros as per the latest changes and
> replaces magic numbers with macros defined in DT header for
> exynos5420.
>
Contents of dts files are not "bindings", they are just device tree
sources/data, defined according to some bindings. Bindings are defined
sets of nodes and properties and their formats, as you can see in
Documentation/devicetree/bindings/, where documentation of supported
bindings is available.
So this patch doesn't update clock bindings, but rather device nodes.
Following would be more appropriate: "ARM: dts: update clock IDs in
device tree of Exynos5420".
However, as mentioned in comments to previous patches, most (if not all)
of the changes below could be probably dropped.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/7] ARM: dts: update macros in clock bindings for exynos5420
Date: Tue, 15 Apr 2014 20:01:48 +0200 [thread overview]
Message-ID: <534D740C.2060904@gmail.com> (raw)
In-Reply-To: <1395918470-16374-8-git-send-email-shaik.ameer@samsung.com>
Hi Shaik,
On 27.03.2014 12:07, Shaik Ameer Basha wrote:
> From: Rahul Sharma <rahul.sharma@samsung.com>
>
> This patch updates the macros as per the latest changes and
> replaces magic numbers with macros defined in DT header for
> exynos5420.
>
Contents of dts files are not "bindings", they are just device tree
sources/data, defined according to some bindings. Bindings are defined
sets of nodes and properties and their formats, as you can see in
Documentation/devicetree/bindings/, where documentation of supported
bindings is available.
So this patch doesn't update clock bindings, but rather device nodes.
Following would be more appropriate: "ARM: dts: update clock IDs in
device tree of Exynos5420".
However, as mentioned in comments to previous patches, most (if not all)
of the changes below could be probably dropped.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-04-15 18:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 11:07 [PATCH v2 0/7] exynos5420: clock file cleanup Shaik Ameer Basha
2014-03-27 11:07 ` Shaik Ameer Basha
2014-03-27 11:07 ` [PATCH v2 1/7] clk: exynos5420: Add more clock register offsets Shaik Ameer Basha
2014-03-27 11:07 ` Shaik Ameer Basha
2014-04-15 16:45 ` Tomasz Figa
2014-04-15 16:45 ` Tomasz Figa
2014-04-20 7:27 ` Shaik Ameer Basha
2014-04-20 7:27 ` Shaik Ameer Basha
2014-03-27 11:07 ` [PATCH v2 2/7] clk: exynos5420: Add more clock IDs Shaik Ameer Basha
2014-03-27 11:07 ` Shaik Ameer Basha
2014-04-15 16:50 ` Tomasz Figa
2014-04-15 16:50 ` Tomasz Figa
2014-04-20 7:30 ` Shaik Ameer Basha
2014-04-20 7:30 ` Shaik Ameer Basha
2014-03-27 11:07 ` [PATCH v2 3/7] clk: exynos5420: Rename " Shaik Ameer Basha
2014-03-27 11:07 ` Shaik Ameer Basha
2014-03-27 19:49 ` Gerhard Sittig
2014-03-27 19:49 ` Gerhard Sittig
2014-04-01 4:42 ` Shaik Ameer Basha
2014-04-01 4:42 ` Shaik Ameer Basha
2014-04-01 4:44 ` Shaik Ameer Basha
2014-04-01 4:44 ` Shaik Ameer Basha
2014-04-15 17:03 ` Tomasz Figa
2014-04-15 17:03 ` Tomasz Figa
2014-04-20 8:32 ` Shaik Ameer Basha
2014-04-20 8:32 ` Shaik Ameer Basha
2014-03-27 11:07 ` [PATCH v2 4/7] clk: exynos5420: Rename clock names Shaik Ameer Basha
2014-03-27 11:07 ` Shaik Ameer Basha
2014-04-15 17:05 ` Tomasz Figa
2014-04-15 17:05 ` Tomasz Figa
2014-03-27 11:07 ` [PATCH v2 5/7] clk: exynos5420: Add missing clocks Shaik Ameer Basha
2014-03-27 11:07 ` Shaik Ameer Basha
2014-04-15 17:56 ` Tomasz Figa
2014-04-15 17:56 ` Tomasz Figa
2014-03-27 11:07 ` [PATCH v2 6/7] clk: exynos5420: Add more registers to restore list Shaik Ameer Basha
2014-03-27 11:07 ` Shaik Ameer Basha
2014-03-27 11:07 ` [PATCH v2 7/7] ARM: dts: update macros in clock bindings for exynos5420 Shaik Ameer Basha
2014-03-27 11:07 ` Shaik Ameer Basha
[not found] ` <1395918470-16374-8-git-send-email-shaik.ameer-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-15 18:01 ` Tomasz Figa [this message]
2014-04-15 18:01 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534D740C.2060904@gmail.com \
--to=tomasz.figa-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=joshi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=r.sh.open-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=shaik.ameer-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=shaik.samsung-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.