From: Tomasz Figa <t.figa@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>, linux-kernel@vger.kernel.org
Cc: linux@arm.linux.org.uk, ben-linux@fluff.org,
kgene.kim@samsung.com, thomas.abraham@linaro.org,
kyungmin.park@samsung.com, sw0312.kim@samsung.com,
hyunhee.kim@samsung.com, yj44.cho@samsung.com,
chanho61.park@samsung.com, arnd@arndb.de, olof@lixom.net,
marc.zyngier@arm.com, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCHv2 5/8] ARM: EXYNOS: Support secondary CPU boot of Exynos3250
Date: Wed, 16 Apr 2014 16:28:04 +0200 [thread overview]
Message-ID: <534E9374.6010807@samsung.com> (raw)
In-Reply-To: <1397527192-21988-6-git-send-email-cw00.choi@samsung.com>
Hi Chanwoo,
On 15.04.2014 03:59, Chanwoo Choi wrote:
> This patch fix the offset of CPU boot address and don't operate smc call
> of SMC_CMD_CPU1BOOT command for Exynos3250.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/mach-exynos/firmware.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
> index aa01c42..6205d4f 100644
> --- a/arch/arm/mach-exynos/firmware.c
> +++ b/arch/arm/mach-exynos/firmware.c
> @@ -30,13 +30,16 @@ static int exynos_do_idle(void)
>
> static int exynos_cpu_boot(int cpu)
> {
> + if (soc_is_exynos3250()) {
> + return 0;
This is strange. How the firmware knows when to boot the CPU then, if
CPU1BOOT command is not called?
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 5/8] ARM: EXYNOS: Support secondary CPU boot of Exynos3250
Date: Wed, 16 Apr 2014 16:28:04 +0200 [thread overview]
Message-ID: <534E9374.6010807@samsung.com> (raw)
In-Reply-To: <1397527192-21988-6-git-send-email-cw00.choi@samsung.com>
Hi Chanwoo,
On 15.04.2014 03:59, Chanwoo Choi wrote:
> This patch fix the offset of CPU boot address and don't operate smc call
> of SMC_CMD_CPU1BOOT command for Exynos3250.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/mach-exynos/firmware.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
> index aa01c42..6205d4f 100644
> --- a/arch/arm/mach-exynos/firmware.c
> +++ b/arch/arm/mach-exynos/firmware.c
> @@ -30,13 +30,16 @@ static int exynos_do_idle(void)
>
> static int exynos_cpu_boot(int cpu)
> {
> + if (soc_is_exynos3250()) {
> + return 0;
This is strange. How the firmware knows when to boot the CPU then, if
CPU1BOOT command is not called?
Best regards,
Tomasz
next prev parent reply other threads:[~2014-04-16 14:28 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 1:59 [PATCHv2 0/8] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 1/8] ARM: EXYNOS: Add Exynos3250 SoC ID Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 2/8] ARM: EXYNOS: Add IO mapping for non-secure SYSRAM of Exynos3250 Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 3/8] ARM: EXYNOS: Add IO mapping for PMU " Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
[not found] ` <1397527192-21988-4-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-15 8:11 ` Arnd Bergmann
2014-04-15 8:11 ` Arnd Bergmann
2014-04-15 8:11 ` Arnd Bergmann
2014-04-15 8:32 ` Chanwoo Choi
2014-04-15 8:32 ` Chanwoo Choi
2014-04-15 8:32 ` Chanwoo Choi
2014-04-15 8:39 ` Vikas Sajjan
2014-04-15 8:39 ` Vikas Sajjan
2014-04-15 8:41 ` Chanwoo Choi
2014-04-15 8:41 ` Chanwoo Choi
[not found] ` <534CEEA8.6020800-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-15 8:46 ` Arnd Bergmann
2014-04-15 8:46 ` Arnd Bergmann
2014-04-15 8:46 ` Arnd Bergmann
2014-04-15 8:51 ` Chanwoo Choi
2014-04-15 8:51 ` Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 4/8] ARM: EXYNOS: Support secondary CPU boot of Exynos4212 Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 5/8] ARM: EXYNOS: Support secondary CPU boot of Exynos3250 Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
[not found] ` <1397527192-21988-6-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-15 5:09 ` Tushar Behera
2014-04-15 5:09 ` Tushar Behera
2014-04-15 5:09 ` Tushar Behera
2014-04-17 10:15 ` Chanwoo Choi
2014-04-17 10:15 ` Chanwoo Choi
2014-04-16 14:28 ` Tomasz Figa [this message]
2014-04-16 14:28 ` Tomasz Figa
2014-04-17 8:04 ` Chanwoo Choi
2014-04-17 8:04 ` Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 6/8] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7 Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
[not found] ` <1397527192-21988-7-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-16 14:35 ` Tomasz Figa
2014-04-16 14:35 ` Tomasz Figa
2014-04-16 14:35 ` Tomasz Figa
2014-04-16 14:39 ` Chanwoo Choi
2014-04-16 14:39 ` Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 7/8] clk: samsung: exynos3250: Add clocks using common clock framework Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
2014-04-15 1:59 ` [PATCHv2 8/8] ARM: dts: Add device tree sources for Exynos3250 Chanwoo Choi
2014-04-15 1:59 ` Chanwoo Choi
2014-04-15 8:15 ` Marc Zyngier
2014-04-15 8:15 ` Marc Zyngier
2014-04-15 8:27 ` Chanwoo Choi
2014-04-15 8:27 ` Chanwoo Choi
2014-04-15 9:13 ` Marc Zyngier
2014-04-15 9:13 ` Marc Zyngier
2014-04-15 9:19 ` Chanwoo Choi
2014-04-15 9:19 ` Chanwoo Choi
2014-04-15 9:24 ` Marc Zyngier
2014-04-15 9:24 ` Marc Zyngier
2014-04-16 8:22 ` Chanwoo Choi
2014-04-16 8:22 ` Chanwoo Choi
2014-04-16 8:34 ` Marc Zyngier
2014-04-16 8:34 ` Marc Zyngier
2014-04-16 8:45 ` Chanwoo Choi
2014-04-16 8:45 ` Chanwoo Choi
2014-04-16 10:23 ` Chanwoo Choi
2014-04-16 10:23 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534E9374.6010807@samsung.com \
--to=t.figa@samsung.com \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=chanho61.park@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=hyunhee.kim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=olof@lixom.net \
--cc=sw0312.kim@samsung.com \
--cc=thomas.abraham@linaro.org \
--cc=yj44.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.