HDMI on OMAP4460: clk rate mismatch warning

HDMI on OMAP4460: clk rate mismatch warning

[Joachim Eastwood]

Hello,

I am trying to get HDMI work with DT on my VAR-STK-OM44 (4460) board.
But during kernel boot I get the following message:

[ 0.953796] ------------[ cut here ]------------
[ 0.953826] WARNING: CPU: 0 PID: 1 at
drivers/video/omap2/dss/dss.c:483 dss_set_fck_rate+0x7c/0x8c()
[ 0.953826] clk rate mismatch: 153600000 != 170666666
[ 0.953857] Modules linked in:
[ 0.953857] CPU: 0 PID: 1 Comm: swapper/0 Not tainted
3.15.0-rc1-00030-gef9175d699c2 #25
[ 0.953918] [<c0014f68>] (unwind_backtrace) from [<c0011c2c>]
(show_stack+0x10/0x14)
[ 0.953918] [<c0011c2c>] (show_stack) from [<c05a7774>] (dump_stack+0x84/0x94)
[ 0.953948] [<c05a7774>] (dump_stack) from [<c0036e18>]
(warn_slowpath_common+0x70/0x8c)
[ 0.953979] [<c0036e18>] (warn_slowpath_common) from [<c0036e64>]
(warn_slowpath_fmt+0x30/0x40)
[ 0.953979] [<c0036e64>] (warn_slowpath_fmt) from [<c02a9928>]
(dss_set_fck_rate+0x7c/0x8c)
[ 0.954010] [<c02a9928>] (dss_set_fck_rate) from [<c083b7f8>]
(omap_dsshw_probe+0x21c/0x3a0)
[ 0.954040] [<c083b7f8>] (omap_dsshw_probe) from [<c030bc38>]
(platform_drv_probe+0x18/0x48)
[ 0.954040] [<c030bc38>] (platform_drv_probe) from [<c030a4bc>]
(driver_probe_device+0x124/0x240)
[ 0.954071] [<c030a4bc>] (driver_probe_device) from [<c030a6b0>]
(__driver_attach+0x94/0x98)
[ 0.954101] [<c030a6b0>] (__driver_attach) from [<c0308a94>]
(bus_for_each_dev+0x60/0x94)
[ 0.954101] [<c0308a94>] (bus_for_each_dev) from [<c0309c6c>]
(bus_add_driver+0x14c/0x1f4)
[ 0.954132] [<c0309c6c>] (bus_add_driver) from [<c030aca4>]
(driver_register+0x78/0xf8)
[ 0.954132] [<c030aca4>] (driver_register) from [<c030bc90>]
(platform_driver_probe+0x20/0xa8)
[ 0.954162] [<c030bc90>] (platform_driver_probe) from [<c083b54c>]
(omap_dss_init+0x24/0xb4)
[ 0.954162] [<c083b54c>] (omap_dss_init) from [<c000897c>]
(do_one_initcall+0xf8/0x148)
[ 0.954193] [<c000897c>] (do_one_initcall) from [<c080fc58>]
(kernel_init_freeable+0x13c/0x1dc)
[ 0.954223] [<c080fc58>] (kernel_init_freeable) from [<c05a2a80>]
(kernel_init+0xc/0xe8)
[ 0.954223] [<c05a2a80>] (kernel_init) from [<c000e2c8>]
(ret_from_fork+0x14/0x2c)
[ 0.954254] ---[ end trace ce91e7215ac78433 ]---
[ 0.954345] OMAP DSS rev 4.0
[ 0.956970] connector-hdmi connector.10: failed to find video source
[ 0.957031] connector-hdmi: probe of connector.10 failed with error -22
[ 0.959167] omapfb omapfb: no displays
[ 0.961547] omapfb omapfb: failed to setup omapfb
[ 0.961578] platform omapfb: Driver omapfb requests probe deferral

Googling turned up this thread:
https://lkml.org/lkml/2014/1/27/285

So I guess one possible explanation would be a bug in the omap4460 clock data.

Has anybody gotten HDMI to work on a 4460?


complete dmesg: http://slexy.org/raw/s2MZvlmrqL
.config:http://slexy.org/raw/s20A0bwQg9
dt nodes: http://slexy.org/raw/s21L4ToVva

regards
Joachim Eastwood

Re: HDMI on OMAP4460: clk rate mismatch warning

[Tomi Valkeinen]

[-- Attachment #1.1: Type: text/plain, Size: 1468 bytes --]

On 15/04/14 20:36, Joachim Eastwood wrote:
> Hello,
> 
> I am trying to get HDMI work with DT on my VAR-STK-OM44 (4460) board.
> But during kernel boot I get the following message:
> 
> [ 0.953796] ------------[ cut here ]------------
> [ 0.953826] WARNING: CPU: 0 PID: 1 at
> drivers/video/omap2/dss/dss.c:483 dss_set_fck_rate+0x7c/0x8c()
> [ 0.953826] clk rate mismatch: 153600000 != 170666666

I have a fix (attached) for this in fbdev-fixes, which I'll probably be
sending to Linus today. I couldn't send it in the main fbdev pull
request, as it depended on clk driver changes. And it's not fatal, most
likely things work fine even with the warning.

> [ 0.954345] OMAP DSS rev 4.0
> [ 0.956970] connector-hdmi connector.10: failed to find video source
> [ 0.957031] connector-hdmi: probe of connector.10 failed with error -22
> [ 0.959167] omapfb omapfb: no displays
> [ 0.961547] omapfb omapfb: failed to setup omapfb
> [ 0.961578] platform omapfb: Driver omapfb requests probe deferral

Your DT data is not right. The shorter endpoint format you use is not
supported. Have a look at arch/arm/boot/dts/omap4-panda-common.dtsi for
an example.

Also the HDMI driver does not currently work if the OMAP HDMI is
directly connected to the HDMI connector. Panda and 4430 SDP boards use
TPD12S015 chip in between. This should be fixed in the future, but at
the moment you'll see problems if your board does not have that chip.

 Tomi


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-OMAPDSS-fix-rounding-when-calculating-fclk-rate.patch --]
[-- Type: text/x-diff; name="0001-OMAPDSS-fix-rounding-when-calculating-fclk-rate.patch", Size: 1637 bytes --]

From d0e224f9963b79610850b2a10622182176658022 Mon Sep 17 00:00:00 2001
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
Date: Thu, 13 Feb 2014 11:36:22 +0200
Subject: [PATCH] OMAPDSS: fix rounding when calculating fclk rate

"clk: divider: fix rate calculation for fractional rates" patch (and
similar for TI specific divider) fixes the clk-divider's rounding. This
patch updates the DSS driver to round the rates accordingly.

This fixes the DSS's warnings about clock rate mismatch, and also fixes
the wrong fclk rate being set.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tested-by: Christoph Fritz <chf.fritz@googlemail.com>
Tested-by: Marek Belisko <marek@goldelico.com>
---
 drivers/video/omap2/dss/dss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c
index 825c019ddee7..d55266c0e029 100644
--- a/drivers/video/omap2/dss/dss.c
+++ b/drivers/video/omap2/dss/dss.c
@@ -457,7 +457,7 @@ bool dss_div_calc(unsigned long pck, unsigned long fck_min,
 	fckd_stop = max(DIV_ROUND_UP(prate * m, fck_hw_max), 1ul);
 
 	for (fckd = fckd_start; fckd >= fckd_stop; --fckd) {
-		fck = prate / fckd * m;
+		fck = DIV_ROUND_UP(prate, fckd) * m;
 
 		if (func(fck, data))
 			return true;
@@ -506,7 +506,7 @@ static int dss_setup_default_clock(void)
 
 		fck_div = DIV_ROUND_UP(prate * dss.feat->dss_fck_multiplier,
 				max_dss_fck);
-		fck = prate / fck_div * dss.feat->dss_fck_multiplier;
+		fck = DIV_ROUND_UP(prate, fck_div) * dss.feat->dss_fck_multiplier;
 	}
 
 	r = dss_set_fck_rate(fck);
-- 
1.8.3.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: HDMI on OMAP4460: clk rate mismatch warning

[Joachim Eastwood]

On 16 April 2014 07:40, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On 15/04/14 20:36, Joachim Eastwood wrote:
>> Hello,
>>
>> I am trying to get HDMI work with DT on my VAR-STK-OM44 (4460) board.
>> But during kernel boot I get the following message:
>>
>> [ 0.953796] ------------[ cut here ]------------
>> [ 0.953826] WARNING: CPU: 0 PID: 1 at
>> drivers/video/omap2/dss/dss.c:483 dss_set_fck_rate+0x7c/0x8c()
>> [ 0.953826] clk rate mismatch: 153600000 != 170666666
>
> I have a fix (attached) for this in fbdev-fixes, which I'll probably be
> sending to Linus today. I couldn't send it in the main fbdev pull
> request, as it depended on clk driver changes. And it's not fatal, most
> likely things work fine even with the warning.

The warning disappeared after the patch. Thanks.
Feel free to add: Tested-By: Joachim Eastwood <manabian@gmail.com>


>> [ 0.954345] OMAP DSS rev 4.0
>> [ 0.956970] connector-hdmi connector.10: failed to find video source
>> [ 0.957031] connector-hdmi: probe of connector.10 failed with error -22
>> [ 0.959167] omapfb omapfb: no displays
>> [ 0.961547] omapfb omapfb: failed to setup omapfb
>> [ 0.961578] platform omapfb: Driver omapfb requests probe deferral
>
> Your DT data is not right. The shorter endpoint format you use is not
> supported. Have a look at arch/arm/boot/dts/omap4-panda-common.dtsi for
> an example.
>
> Also the HDMI driver does not currently work if the OMAP HDMI is
> directly connected to the HDMI connector. Panda and 4430 SDP boards use
> TPD12S015 chip in between. This should be fixed in the future, but at
> the moment you'll see problems if your board does not have that chip.

This board (VAR-STK-OM44) has a TPD12S521 which has no controllable
settings so adding a driver for it would be pretty meaningless. I
think it's the same situation with Gumstix Parlor. That board also
just have a very simple HDMI transmitter which shouldn't require a
driver.

But never the less I got HDMI working on my board adding the tpd21s015
nodes and providing a dummy gpio for "CT CP HPD". This works but it's
a bit hacky.

During boot I got this warning from the tpd12s015 driver:
[ 2.955444] WARNING: CPU: 0 PID: 16 at
drivers/video/omap2/displays-new/encoder-tpd12s015.c:87
tpd_connect+0xb8/0xc8()
[ 2.955444] Modules linked in:
[ 2.955444] CPU: 0 PID: 16 Comm: kworker/u4:1 Not tainted
3.15.0-rc1-00058-ge6c0e0fdf274-dirty #33
[ 2.979309] Workqueue: deferwq deferred_probe_work_func
[ 2.984863] [<c0014f48>] (unwind_backtrace) from [<c0011c2c>]
(show_stack+0x10/0x14)
[ 3.000427] [<c0011c2c>] (show_stack) from [<c05cb494>] (dump_stack+0x84/0x94)
[ 3.008087] [<c05cb494>] (dump_stack) from [<c0036ba8>]
(warn_slowpath_common+0x70/0x8c)
[ 3.016632] [<c0036ba8>] (warn_slowpath_common) from [<c0036c60>]
(warn_slowpath_null+0x1c/0x24)
[ 3.025878] [<c0036c60>] (warn_slowpath_null) from [<c02c8d30>]
(tpd_connect+0xb8/0xc8)
[ 3.034332] [<c02c8d30>] (tpd_connect) from [<c031f640>] (pdev_probe+0x40/0xdc)
[ 3.042053] [<c031f640>] (pdev_probe) from [<c0330474>]
(platform_drv_probe+0x18/0x48)
[ 3.042083] [<c0330474>] (platform_drv_probe) from [<c032ecf8>]
(driver_probe_device+0x124/0x240)
[ 3.059722] [<c032ecf8>] (driver_probe_device) from [<c032d370>]
(bus_for_each_drv+0x58/0x8c)
[ 3.068695] [<c032d370>] (bus_for_each_drv) from [<c032eba4>]
(device_attach+0x78/0x8c)
[ 3.077148] [<c032eba4>] (device_attach) from [<c032e22c>]
(bus_probe_device+0x88/0xac)
[ 3.085571] [<c032e22c>] (bus_probe_device) from [<c032e674>]
(deferred_probe_work_func+0x6c/0xa0)
[ 3.095031] [<c032e674>] (deferred_probe_work_func) from [<c004edb0>]
(process_one_work+0x1b0/0x4c4)
[ 3.095031] [<c004edb0>] (process_one_work) from [<c004fc74>]
(worker_thread+0x13c/0x3dc)
[ 3.113220] [<c004fc74>] (worker_thread) from [<c0055844>] (kthread+0xe0/0xf4)
[ 3.121032] [<c0055844>] (kthread) from [<c000e2c8>] (ret_from_fork+0x14/0x2c)
[ 3.128631] ---[ end trace 7cb21223a2b91cf6 ]---

One other thing.
Does HDMI audio work with DT or is that a still TODO?
I am only getting probe deferral's from omap-hdmi-audio. Haven't look
to far into it.

regards
Joachim Eastwood

Re: HDMI on OMAP4460: clk rate mismatch warning

[Tomi Valkeinen]

[-- Attachment #1.1: Type: text/plain, Size: 2382 bytes --]

On 16/04/14 19:11, Joachim Eastwood wrote:
> On 16 April 2014 07:40, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> On 15/04/14 20:36, Joachim Eastwood wrote:
>>> Hello,
>>>
>>> I am trying to get HDMI work with DT on my VAR-STK-OM44 (4460) board.
>>> But during kernel boot I get the following message:
>>>
>>> [ 0.953796] ------------[ cut here ]------------
>>> [ 0.953826] WARNING: CPU: 0 PID: 1 at
>>> drivers/video/omap2/dss/dss.c:483 dss_set_fck_rate+0x7c/0x8c()
>>> [ 0.953826] clk rate mismatch: 153600000 != 170666666
>>
>> I have a fix (attached) for this in fbdev-fixes, which I'll probably be
>> sending to Linus today. I couldn't send it in the main fbdev pull
>> request, as it depended on clk driver changes. And it's not fatal, most
>> likely things work fine even with the warning.
> 
> The warning disappeared after the patch. Thanks.
> Feel free to add: Tested-By: Joachim Eastwood <manabian@gmail.com>

Thanks. It should be in -rc2.

> This board (VAR-STK-OM44) has a TPD12S521 which has no controllable
> settings so adding a driver for it would be pretty meaningless. I
> think it's the same situation with Gumstix Parlor. That board also
> just have a very simple HDMI transmitter which shouldn't require a
> driver.
> 
> But never the less I got HDMI working on my board adding the tpd21s015
> nodes and providing a dummy gpio for "CT CP HPD". This works but it's
> a bit hacky.

Remove the tpd21s015 nodes and try the attached patch. It adds HPD
support to the hdmi connector. You also need something like this for the
hdmi-connector node:


pinctrl-names = "default";
pinctrl-0 = <&hdmi_conn_pins>;

hpd-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>; /* GPIO 193, HPD */


And the respective pinctrl node:

hdmi_conn_pins: pinmux_hdmi_conn_pins {
        pinctrl-single,pins = <
                0x0fe (PIN_INPUT_PULLDOWN | MUX_MODE6)
        >;
};

Note that I tested this yesterday on one board, but I couldn't get it
working yet, so no promises =). But that may be an issue with the HPD
pin on the board.

> One other thing.
> Does HDMI audio work with DT or is that a still TODO?
> I am only getting probe deferral's from omap-hdmi-audio. Haven't look
> to far into it.

It's still on the works. If you volunteer for testing it (and Jyri needs
someone to test), you can ask Jyri Sarha.

 Tomi


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-connector-hdmi-hpd-support.patch --]
[-- Type: text/x-diff; name="0001-connector-hdmi-hpd-support.patch", Size: 2489 bytes --]

From e004ca58936336f06339e216c1f4bd5f1e694932 Mon Sep 17 00:00:00 2001
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
Date: Thu, 17 Apr 2014 10:18:58 +0300
Subject: [PATCH] connector-hdmi: hpd support

---
 drivers/video/omap2/displays-new/connector-hdmi.c | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/drivers/video/omap2/displays-new/connector-hdmi.c b/drivers/video/omap2/displays-new/connector-hdmi.c
index 29ed21b9dce5..7b06ea430209 100644
--- a/drivers/video/omap2/displays-new/connector-hdmi.c
+++ b/drivers/video/omap2/displays-new/connector-hdmi.c
@@ -13,6 +13,7 @@
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/of.h>
+#include <linux/of_gpio.h>
 
 #include <drm/drm_edid.h>
 
@@ -43,6 +44,8 @@ struct panel_drv_data {
 	struct device *dev;
 
 	struct omap_video_timings timings;
+
+	int hpd_gpio;
 };
 
 #define to_panel_data(x) container_of(x, struct panel_drv_data, dssdev)
@@ -161,7 +164,10 @@ static bool hdmic_detect(struct omap_dss_device *dssdev)
 	struct panel_drv_data *ddata = to_panel_data(dssdev);
 	struct omap_dss_device *in = ddata->in;
 
-	return in->ops.hdmi->detect(in);
+	if (gpio_is_valid(ddata->hpd_gpio))
+		return gpio_get_value_cansleep(ddata->hpd_gpio);
+	else
+		return in->ops.hdmi->detect(in);
 }
 
 static int hdmic_audio_enable(struct omap_dss_device *dssdev)
@@ -288,6 +294,8 @@ static int hdmic_probe_pdata(struct platform_device *pdev)
 
 	pdata = dev_get_platdata(&pdev->dev);
 
+	ddata->hpd_gpio = -ENODEV;
+
 	in = omap_dss_find_output(pdata->source);
 	if (in == NULL) {
 		dev_err(&pdev->dev, "Failed to find video source\n");
@@ -307,6 +315,14 @@ static int hdmic_probe_of(struct platform_device *pdev)
 	struct panel_drv_data *ddata = platform_get_drvdata(pdev);
 	struct device_node *node = pdev->dev.of_node;
 	struct omap_dss_device *in;
+	int gpio;
+
+	/* HPD GPIO */
+	gpio = of_get_named_gpio(node, "hpd-gpios", 0);
+	if (gpio_is_valid(gpio))
+		ddata->hpd_gpio = gpio;
+	else
+		ddata->hpd_gpio = -ENODEV;
 
 	in = omapdss_of_find_source_for_first_ep(node);
 	if (IS_ERR(in)) {
@@ -344,6 +360,11 @@ static int hdmic_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
+	r = devm_gpio_request_one(&pdev->dev, ddata->hpd_gpio,
+			GPIOF_DIR_IN, "hdmi_hpd");
+	if (r)
+		return r;
+
 	ddata->timings = hdmic_default_timings;
 
 	dssdev = &ddata->dssdev;
-- 
1.8.3.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: HDMI on OMAP4460: clk rate mismatch warning

[Joachim Eastwood]

On 17 April 2014 09:24, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On 16/04/14 19:11, Joachim Eastwood wrote:
>> On 16 April 2014 07:40, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>> On 15/04/14 20:36, Joachim Eastwood wrote:
>>>> Hello,
>>>>
>>>> I am trying to get HDMI work with DT on my VAR-STK-OM44 (4460) board.
>>>> But during kernel boot I get the following message:
>>>>
>>>> [ 0.953796] ------------[ cut here ]------------
>>>> [ 0.953826] WARNING: CPU: 0 PID: 1 at
>>>> drivers/video/omap2/dss/dss.c:483 dss_set_fck_rate+0x7c/0x8c()
>>>> [ 0.953826] clk rate mismatch: 153600000 != 170666666
>>>
>>> I have a fix (attached) for this in fbdev-fixes, which I'll probably be
>>> sending to Linus today. I couldn't send it in the main fbdev pull
>>> request, as it depended on clk driver changes. And it's not fatal, most
>>> likely things work fine even with the warning.
>>
>> The warning disappeared after the patch. Thanks.
>> Feel free to add: Tested-By: Joachim Eastwood <manabian@gmail.com>
>
> Thanks. It should be in -rc2.
>
>> This board (VAR-STK-OM44) has a TPD12S521 which has no controllable
>> settings so adding a driver for it would be pretty meaningless. I
>> think it's the same situation with Gumstix Parlor. That board also
>> just have a very simple HDMI transmitter which shouldn't require a
>> driver.
>>
>> But never the less I got HDMI working on my board adding the tpd21s015
>> nodes and providing a dummy gpio for "CT CP HPD". This works but it's
>> a bit hacky.
>
> Remove the tpd21s015 nodes and try the attached patch. It adds HPD
> support to the hdmi connector. You also need something like this for the
> hdmi-connector node:
>
>
> pinctrl-names = "default";
> pinctrl-0 = <&hdmi_conn_pins>;
>
> hpd-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>; /* GPIO 193, HPD */
>
>
> And the respective pinctrl node:
>
> hdmi_conn_pins: pinmux_hdmi_conn_pins {
>         pinctrl-single,pins = <
>                 0x0fe (PIN_INPUT_PULLDOWN | MUX_MODE6)
>         >;
> };
>
> Note that I tested this yesterday on one board, but I couldn't get it
> working yet, so no promises =). But that may be an issue with the HPD
> pin on the board.

Works like a charm here :)
Replugging the HDMI monitor and everything.

But I notice something strange on the monitor. Around the white login
text there are small blinking green dots. So maybe there is a timing
issue here?

Log below shows a monitor replug.
[ 63.158966] DISPC: dispc_runtime_get
[ 63.159027] DISPC: dispc_runtime_get
[ 63.159057] DISPC: dispc_runtime_put
[ 63.159057] DISPC: dispc_runtime_get
[ 63.159088] DISPC: dispc_runtime_put
[ 63.164459] DISPC: dispc_runtime_get
[ 63.164550] DISPC: dispc_runtime_put
[ 63.164550] DISPC: dispc_runtime_get
[ 63.164581] DISPC: dispc_runtime_put
[ 63.164581] DISPC: dispc_enable_plane 0, 0
[ 63.165069] DISPC: dispc_runtime_put
[ 63.165069] DISPC: dispc_runtime_get
[ 63.165069] DISPC: dispc_runtime_put
[ 83.292205] HDMI: hdmi_runtime_get
[ 83.320678] HDMI: hdmi_runtime_put
[ 83.326477] DISPC: dispc_runtime_get
[ 83.326538] DISPC: dispc_ovl_setup 0, pa 7f6a0000, pa_uv 0, sw 2048,
0,0, 1920x1200 -> 1920x1200, cmode 800, rot 0, mir 0, chan 1 repl 0
[ 83.326568] DISPC: calc_rot(0): scrw 2048, 1920x1200
[ 83.326568] DISPC: offset0 0, offset1 0, row_inc 513, pix_inc 1
[ 83.326599] DISPC: 0,0 1920x1200 -> 1920x1200
[ 83.326599] DISPC: dispc_enable_plane 0, 1
[ 83.326599] HDMI: Enter hdmi_display_disable
[ 83.328613] HDMI: hdmi_runtime_put
[ 83.328643] DISPC: dispc_runtime_put
[ 83.329010] HDMI: hdmi_get_code
[ 83.329010] HDMI: timing1_hsync = 160 timing1_vsync = 35timing2_hsync
= 160 timing2_vsync = 35
[ 83.329132] HDMI: using mode: DVI, code 68
[ 83.329132] HDMI: hdmi_get_code
[ 83.329162] HDMI: timing1_hsync = 160 timing1_vsync = 35timing2_hsync
= 160 timing2_vsync = 35
[ 83.329162] HDMI: using mode: DVI, code 68
[ 83.329162] HDMI: ENTER hdmi_display_enable
[ 83.330017] HDMI: hdmi_runtime_get
[ 83.330078] DISPC: dispc_runtime_get
[ 83.330078] HDMI: hdmi_power_on x_res= 1920 y_res = 1200
[ 83.330078] HDMIPLL: M = 641 Mf = 174762
[ 83.330139] HDMIPLL: range = 1 sd = 6
[ 83.330139] HDMIPLL: PLL locked!
[ 83.330566] HDMICORE: Enter hdmi_core_init
[ 83.330657] HDMIWP: Enter hdmi_wp_video_init_format
[ 83.330657] HDMIWP: Enter hdmi_wp_video_config_timing
[ 83.330657] HDMIWP: Enter hdmi_wp_video_config_interface
[ 83.330688] HDMICORE: Enter hdmi_core_swreset_assert
[ 83.330688] HDMICORE: Enter hdmi_core_powerdown_disable
[ 83.330718] HDMICORE: Enter hdmi_core_swreset_release
[ 83.330718] DISPC: channel 1 xres 1920 yres 1200
[ 83.330749] DISPC: dispc_runtime_get
[ 83.330749] DISPC: dispc_runtime_put
[ 83.330780] DISPC: dispc_runtime_get
[ 83.330780] DISPC: dispc_runtime_put
[ 83.330780] DISPC: dispc_runtime_get
[ 83.330810] DISPC: dispc_runtime_put
[ 83.330810] DISPC: GO DIGIT
[ 83.330841] DISPC: dispc_runtime_put
[ 83.330902] DISPC: dispc_runtime_get
[ 83.330902] DISPC: dispc_runtime_put


>> One other thing.
>> Does HDMI audio work with DT or is that a still TODO?
>> I am only getting probe deferral's from omap-hdmi-audio. Haven't look
>> to far into it.
>
> It's still on the works. If you volunteer for testing it (and Jyri needs
> someone to test), you can ask Jyri Sarha.

Jyri Sarha:

I get these messages in my log:
[ 4.290710] omap-hdmi-audio omap-hdmi-audio: ASoC: CODEC
hdmi-audio-codec not registered
[ 4.290710] omap-hdmi-audio omap-hdmi-audio: snd_soc_register_card failed (-517)
[ 4.290710] platform omap-hdmi-audio: Driver omap-hdmi-audio requests
probe deferral

"hdmi-audio-codec" should come from sound/soc/codecs/hdmi.c so added
these nodes to my DT.

hdmi_audio: hdmi_audio@0 {
    compatible = "linux,hdmi-audio";
    status = "okay";
};

But I still get the same message.

So if you have some patches you would like to have tested just tell me.


regards
Joachim Eastwood

Re: HDMI on OMAP4460: clk rate mismatch warning

[Joachim Eastwood]

On 17 April 2014 10:56, Joachim  Eastwood <manabian@gmail.com> wrote:
> On 17 April 2014 09:24, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> On 16/04/14 19:11, Joachim Eastwood wrote:
>>> On 16 April 2014 07:40, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>>> On 15/04/14 20:36, Joachim Eastwood wrote:
>>>>> Hello,
>>>>>
>>>>> I am trying to get HDMI work with DT on my VAR-STK-OM44 (4460) board.
>>>>> But during kernel boot I get the following message:
>>>>>
>>>>> [ 0.953796] ------------[ cut here ]------------
>>>>> [ 0.953826] WARNING: CPU: 0 PID: 1 at
>>>>> drivers/video/omap2/dss/dss.c:483 dss_set_fck_rate+0x7c/0x8c()
>>>>> [ 0.953826] clk rate mismatch: 153600000 != 170666666
>>>>
>>>> I have a fix (attached) for this in fbdev-fixes, which I'll probably be
>>>> sending to Linus today. I couldn't send it in the main fbdev pull
>>>> request, as it depended on clk driver changes. And it's not fatal, most
>>>> likely things work fine even with the warning.
>>>
>>> The warning disappeared after the patch. Thanks.
>>> Feel free to add: Tested-By: Joachim Eastwood <manabian@gmail.com>
>>
>> Thanks. It should be in -rc2.
>>
>>> This board (VAR-STK-OM44) has a TPD12S521 which has no controllable
>>> settings so adding a driver for it would be pretty meaningless. I
>>> think it's the same situation with Gumstix Parlor. That board also
>>> just have a very simple HDMI transmitter which shouldn't require a
>>> driver.
>>>
>>> But never the less I got HDMI working on my board adding the tpd21s015
>>> nodes and providing a dummy gpio for "CT CP HPD". This works but it's
>>> a bit hacky.
>>
>> Remove the tpd21s015 nodes and try the attached patch. It adds HPD
>> support to the hdmi connector. You also need something like this for the
>> hdmi-connector node:
>>
>>
>> pinctrl-names = "default";
>> pinctrl-0 = <&hdmi_conn_pins>;
>>
>> hpd-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>; /* GPIO 193, HPD */
>>
>>
>> And the respective pinctrl node:
>>
>> hdmi_conn_pins: pinmux_hdmi_conn_pins {
>>         pinctrl-single,pins = <
>>                 0x0fe (PIN_INPUT_PULLDOWN | MUX_MODE6)
>>         >;
>> };
>>
>> Note that I tested this yesterday on one board, but I couldn't get it
>> working yet, so no promises =). But that may be an issue with the HPD
>> pin on the board.
>
> Works like a charm here :)
> Replugging the HDMI monitor and everything.
>
> But I notice something strange on the monitor. Around the white login
> text there are small blinking green dots. So maybe there is a timing
> issue here?

That turned out to be my HDMI cable...
Changed to shorter cable and the green dots disappeared. Sorry for the
false alarm.

regards
Joachim Eastwood