* [PATCH] extcon: max14577: Properly handle regmap_irq_get_virq error
@ 2014-04-18 14:47 Krzysztof Kozlowski
2014-04-21 9:47 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2014-04-18 14:47 UTC (permalink / raw)
To: MyungJoo Ham, Chanwoo Choi, linux-kernel; +Cc: Krzysztof Kozlowski, stable
The regmap_irq_get_virq may return 0 or -EINVAL on error. Fail the probe
in both situations.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: <stable@vger.kernel.org>
---
drivers/extcon/extcon-max14577.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
index 3846941801b8..d58747d2ddfa 100644
--- a/drivers/extcon/extcon-max14577.c
+++ b/drivers/extcon/extcon-max14577.c
@@ -650,7 +650,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
unsigned int virq = 0;
virq = regmap_irq_get_virq(max14577->irq_data, muic_irq->irq);
- if (!virq)
+ if (virq <= 0)
return -EINVAL;
muic_irq->virq = virq;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] extcon: max14577: Properly handle regmap_irq_get_virq error
2014-04-18 14:47 [PATCH] extcon: max14577: Properly handle regmap_irq_get_virq error Krzysztof Kozlowski
@ 2014-04-21 9:47 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2014-04-21 9:47 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: MyungJoo Ham, linux-kernel, stable
On 04/18/2014 11:47 PM, Krzysztof Kozlowski wrote:
> The regmap_irq_get_virq may return 0 or -EINVAL on error. Fail the probe
> in both situations.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: <stable@vger.kernel.org>
> ---
> drivers/extcon/extcon-max14577.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
> index 3846941801b8..d58747d2ddfa 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -650,7 +650,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
> unsigned int virq = 0;
>
> virq = regmap_irq_get_virq(max14577->irq_data, muic_irq->irq);
> - if (!virq)
> + if (virq <= 0)
> return -EINVAL;
> muic_irq->virq = virq;
Applied it.
But,
IMO, Generally, if function completed the operation without problem,
return zero(0). But, irq_create_mapping() returns zero(0) when error happen.
It is necessary to modify irq_create_mapping(kernel/irq/irqdomain.c) about return value.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-21 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-18 14:47 [PATCH] extcon: max14577: Properly handle regmap_irq_get_virq error Krzysztof Kozlowski
2014-04-21 9:47 ` Chanwoo Choi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.