From: Anna Schumaker <schumaker.anna@gmail.com>
To: Christoph Hellwig <hch@infradead.org>,
Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: Trond.Myklebust@primarydata.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 02/17] NFS: Create a common results structure for reads and writes
Date: Mon, 21 Apr 2014 08:45:31 -0400 [thread overview]
Message-ID: <535512EB.60708@gmail.com> (raw)
In-Reply-To: <20140418135725.GB20096@infradead.org>
On 04/18/2014 09:57 AM, Christoph Hellwig wrote:
>> +struct nfs_pgio_res {
>> + struct nfs4_sequence_res seq_res;
>> + struct nfs_fattr * fattr;
>> + struct nfs_writeverf * verf; /* used by write */
>> + const struct nfs_server *server; /* used by write */
>> + __u32 count;
>> + int eof; /* used by read */
> Same comment as for the previous patch applies here. Also maybe
> this should use a union to overlay the read/write only fields?
I thought about a union, but I didn't know if it was worth it for only one or two differing variables. I can put one in that would make more sense, though. Thanks!
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-21 12:45 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 21:09 [PATCH 00/17] NFS: Create a common path used by reads and writes Anna Schumaker
2014-04-17 21:09 ` [PATCH 01/17] NFS: Create a common argument structure for " Anna Schumaker
2014-04-18 13:56 ` Christoph Hellwig
2014-04-21 12:44 ` Anna Schumaker
2014-04-17 21:09 ` [PATCH 02/17] NFS: Create a common results " Anna Schumaker
2014-04-18 13:57 ` Christoph Hellwig
2014-04-21 12:45 ` Anna Schumaker [this message]
2014-04-17 21:09 ` [PATCH 03/17] NFS: Create a common read and write data struct Anna Schumaker
2014-04-18 14:00 ` Christoph Hellwig
2014-04-17 21:09 ` [PATCH 04/17] NFS: Create a common read and write header struct Anna Schumaker
2014-04-18 14:01 ` Christoph Hellwig
2014-04-17 21:09 ` [PATCH 05/17] NFS: Move the write verifier into the nfs_pgio_header Anna Schumaker
2014-04-18 14:02 ` Christoph Hellwig
2014-04-17 21:09 ` [PATCH 06/17] NFS: Create a common pgio_alloc and pgio_release function Anna Schumaker
2014-04-18 14:03 ` Christoph Hellwig
2014-04-17 21:09 ` [PATCH 07/17] NFS: Create a common rw_header_alloc and rw_header_free function Anna Schumaker
2014-04-21 13:32 ` Christoph Hellwig
2014-04-21 13:52 ` Anna Schumaker
2014-04-21 16:24 ` Anna Schumaker
2014-04-25 12:12 ` Christoph Hellwig
2014-04-25 13:02 ` Anna Schumaker
2014-04-17 21:09 ` [PATCH 08/17] NFS: Create a common pgio_rpc_prepare function Anna Schumaker
2014-04-17 21:09 ` [PATCH 09/17] NFS: Create a common nfs_pgio_result_common function Anna Schumaker
2014-04-17 21:09 ` [PATCH 10/17] NFS: Create a common rpc_call_ops struct Anna Schumaker
2014-04-17 21:09 ` [PATCH 11/17] NFS: Create a common rpcsetup function for reads and writes Anna Schumaker
2014-04-17 21:09 ` [PATCH 12/17] NFS: Create a common pgio_error function Anna Schumaker
2014-04-17 21:09 ` [PATCH 13/17] NFS: Create a generic_pgio function Anna Schumaker
2014-04-17 21:09 ` [PATCH 14/17] NFS: Create a common initiate_pgio() function Anna Schumaker
2014-04-17 21:09 ` [PATCH 15/17] NFS: Create a common multiple_pgios() function Anna Schumaker
2014-04-17 21:09 ` [PATCH 16/17] NFS: Create a common generic_pg_pgios() Anna Schumaker
2014-04-17 21:09 ` [PATCH 17/17] NFS: Create a common nfs_pageio_ops struct Anna Schumaker
2014-04-21 6:42 ` [PATCH 00/17] NFS: Create a common path used by reads and writes Christoph Hellwig
2014-04-21 12:46 ` Anna Schumaker
2014-04-21 13:09 ` Christoph Hellwig
2014-04-23 12:55 ` Boaz Harrosh
2014-04-23 13:15 ` Boaz Harrosh
2014-04-23 13:42 ` Weston Andros Adamson
2014-04-23 13:51 ` Anna Schumaker
2014-04-23 13:59 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535512EB.60708@gmail.com \
--to=schumaker.anna@gmail.com \
--cc=Anna.Schumaker@netapp.com \
--cc=Trond.Myklebust@primarydata.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.