Re: [PATCH 07/17] NFS: Create a common rw_header_alloc and rw_header_free function

[Anna Schumaker <schumaker.anna@gmail.com>]

On 04/21/2014 09:52 AM, Anna Schumaker wrote:
> On 04/21/2014 09:32 AM, Christoph Hellwig wrote:
>> On Thu, Apr 17, 2014 at 05:09:31PM -0400, Anna Schumaker wrote:
>>> From: Anna Schumaker <Anna.Schumaker@netapp.com>
>>>
>>> I create a new struct nfs_rw_ops to decide the differences between reads
>>> and writes.  This struct will be set when initializing a new
>>> nfs_pgio_descriptor, and then passed on to the nfs_rw_header when a new
>>> header is allocated.
>> To me it seems like adding this new vector confuses things.  From a look
>> at your whole tree it seems like all methods added to it could as well
>> be added to nfs_pageio_ops.  In that case we'd still keep separate
>> instances of nfs_pageio_ops for reads and writes, but most methods would
>> be that same.  I'm also defintively curious what you have on your
>> sleeves for pnfs.
> Okay.  I'll rework everything into the pageio_ops and see how it looks!  Maybe I'll see what I can do about updating the pnfs patches while I'm at it.
I remember my issue with adding to the nfs_pageio_ops now.  The file, object and block layouts along with the generic pnfs code all have their own read and write pageio_ops.  Changing all of these seemed more tedious than adding a new struct  only in the read and write code.

>
> Thanks for reviewing all of these!
>
> Anna
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html