From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/7] ARM: mm: use phys_addr_t in __dma_page_[cpu_to_dev/dev_to_cpu]
Date: Mon, 21 Apr 2014 09:39:13 -0400 [thread overview]
Message-ID: <53551F81.9040209@ti.com> (raw)
In-Reply-To: <1397917972-6293-8-git-send-email-santosh.shilimkar@ti.com>
(Adding few CC's)
On Saturday 19 April 2014 10:32 AM, Santosh Shilimkar wrote:
> On a 32 bit ARM architecture with LPAE extension physical addresses
> cannot fit into unsigned long variable.
>
> So fix it by using phys_addr_t instead of unsigned long.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mm/dma-mapping.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index f62aa06..5260f43 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -885,7 +885,7 @@ static void dma_cache_maint_page(struct page *page, unsigned long offset,
> static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
> size_t size, enum dma_data_direction dir)
> {
> - unsigned long paddr;
> + phys_addr_t paddr;
>
> dma_cache_maint_page(page, off, size, dir, dmac_map_area);
>
> @@ -901,7 +901,7 @@ static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
> static void __dma_page_dev_to_cpu(struct page *page, unsigned long off,
> size_t size, enum dma_data_direction dir)
> {
> - unsigned long paddr = page_to_phys(page) + off;
> + phys_addr_t paddr = page_to_phys(page) + off;
>
> /* FIXME: non-speculating: not required */
> /* don't bother invalidating if DMA to device */
>
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Russell King - ARM Linux
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Nicolas Pitre
<nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH v2 7/7] ARM: mm: use phys_addr_t in __dma_page_[cpu_to_dev/dev_to_cpu]
Date: Mon, 21 Apr 2014 09:39:13 -0400 [thread overview]
Message-ID: <53551F81.9040209@ti.com> (raw)
In-Reply-To: <1397917972-6293-8-git-send-email-santosh.shilimkar-l0cyMroinI0@public.gmane.org>
(Adding few CC's)
On Saturday 19 April 2014 10:32 AM, Santosh Shilimkar wrote:
> On a 32 bit ARM architecture with LPAE extension physical addresses
> cannot fit into unsigned long variable.
>
> So fix it by using phys_addr_t instead of unsigned long.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
> ---
> arch/arm/mm/dma-mapping.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index f62aa06..5260f43 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -885,7 +885,7 @@ static void dma_cache_maint_page(struct page *page, unsigned long offset,
> static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
> size_t size, enum dma_data_direction dir)
> {
> - unsigned long paddr;
> + phys_addr_t paddr;
>
> dma_cache_maint_page(page, off, size, dir, dmac_map_area);
>
> @@ -901,7 +901,7 @@ static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
> static void __dma_page_dev_to_cpu(struct page *page, unsigned long off,
> size_t size, enum dma_data_direction dir)
> {
> - unsigned long paddr = page_to_phys(page) + off;
> + phys_addr_t paddr = page_to_phys(page) + off;
>
> /* FIXME: non-speculating: not required */
> /* don't bother invalidating if DMA to device */
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: <linux-kernel@vger.kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v2 7/7] ARM: mm: use phys_addr_t in __dma_page_[cpu_to_dev/dev_to_cpu]
Date: Mon, 21 Apr 2014 09:39:13 -0400 [thread overview]
Message-ID: <53551F81.9040209@ti.com> (raw)
In-Reply-To: <1397917972-6293-8-git-send-email-santosh.shilimkar@ti.com>
(Adding few CC's)
On Saturday 19 April 2014 10:32 AM, Santosh Shilimkar wrote:
> On a 32 bit ARM architecture with LPAE extension physical addresses
> cannot fit into unsigned long variable.
>
> So fix it by using phys_addr_t instead of unsigned long.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mm/dma-mapping.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index f62aa06..5260f43 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -885,7 +885,7 @@ static void dma_cache_maint_page(struct page *page, unsigned long offset,
> static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
> size_t size, enum dma_data_direction dir)
> {
> - unsigned long paddr;
> + phys_addr_t paddr;
>
> dma_cache_maint_page(page, off, size, dir, dmac_map_area);
>
> @@ -901,7 +901,7 @@ static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
> static void __dma_page_dev_to_cpu(struct page *page, unsigned long off,
> size_t size, enum dma_data_direction dir)
> {
> - unsigned long paddr = page_to_phys(page) + off;
> + phys_addr_t paddr = page_to_phys(page) + off;
>
> /* FIXME: non-speculating: not required */
> /* don't bother invalidating if DMA to device */
>
next prev parent reply other threads:[~2014-04-21 13:39 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 14:32 [PATCH v2 0/7] of: setup dma parameters using dma-ranges and dma-coherent Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` [PATCH v2 1/7] device: introduce per device dma_pfn_offset Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` [PATCH v2 2/7] of: introduce of_dma_get_range() helper Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-21 15:29 ` Rob Herring
2014-04-21 15:29 ` Rob Herring
2014-04-21 15:29 ` Rob Herring
2014-04-22 14:56 ` Grygorii Strashko
2014-04-22 14:56 ` Grygorii Strashko
2014-04-22 14:56 ` Grygorii Strashko
2014-04-22 4:09 ` Joel Fernandes
2014-04-22 4:09 ` Joel Fernandes
2014-04-22 4:09 ` Joel Fernandes
2014-04-19 14:32 ` [PATCH v2 3/7] of: introduce of_dma_is_coherent() helper Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` [PATCH v2 4/7] of: configure the platform device dma parameters Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-21 14:58 ` Rob Herring
2014-04-21 14:58 ` Rob Herring
2014-04-21 14:58 ` Rob Herring
2014-04-22 15:09 ` Grygorii Strashko
2014-04-22 15:09 ` Grygorii Strashko
2014-04-22 15:09 ` Grygorii Strashko
2014-04-22 14:44 ` Rob Herring
2014-04-22 14:44 ` Rob Herring
2014-04-22 14:44 ` Rob Herring
2014-04-22 15:44 ` Grygorii Strashko
2014-04-22 15:44 ` Grygorii Strashko
2014-04-19 14:32 ` [PATCH v2 5/7] ARM: dma: Use dma_pfn_offset for dma address translation Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 19:43 ` Russell King - ARM Linux
2014-04-19 19:43 ` Russell King - ARM Linux
2014-04-19 19:43 ` Russell King - ARM Linux
2014-04-21 13:38 ` Santosh Shilimkar
2014-04-21 13:38 ` Santosh Shilimkar
2014-04-21 13:38 ` Santosh Shilimkar
2014-04-19 14:32 ` [PATCH v2 6/7] ARM: dma: implement set_arch_dma_coherent_ops() Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` [PATCH v2 7/7] ARM: mm: use phys_addr_t in __dma_page_[cpu_to_dev/dev_to_cpu] Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-19 14:32 ` Santosh Shilimkar
2014-04-21 13:39 ` Santosh Shilimkar [this message]
2014-04-21 13:39 ` Santosh Shilimkar
2014-04-21 13:39 ` Santosh Shilimkar
2014-04-19 16:25 ` [PATCH v2 0/7] of: setup dma parameters using dma-ranges and dma-coherent Thomas Petazzoni
2014-04-19 16:25 ` Thomas Petazzoni
2014-04-19 16:25 ` Thomas Petazzoni
2014-04-21 13:35 ` Santosh Shilimkar
2014-04-21 13:35 ` Santosh Shilimkar
2014-04-21 13:35 ` Santosh Shilimkar
2014-04-21 18:19 ` Thomas Petazzoni
2014-04-21 18:19 ` Thomas Petazzoni
2014-04-21 19:17 ` Santosh Shilimkar
2014-04-21 19:17 ` Santosh Shilimkar
2014-04-21 19:17 ` Santosh Shilimkar
2014-04-22 14:54 ` Catalin Marinas
2014-04-22 14:54 ` Catalin Marinas
2014-04-22 15:02 ` Arnd Bergmann
2014-04-22 15:02 ` Arnd Bergmann
2014-04-22 15:02 ` Arnd Bergmann
2014-04-22 15:15 ` Santosh Shilimkar
2014-04-22 15:15 ` Santosh Shilimkar
2014-04-22 15:15 ` Santosh Shilimkar
2014-04-22 15:25 ` Catalin Marinas
2014-04-22 15:25 ` Catalin Marinas
2014-04-22 15:25 ` Catalin Marinas
2014-04-22 15:30 ` Rob Herring
2014-04-22 15:30 ` Rob Herring
2014-04-22 15:30 ` Rob Herring
2014-04-22 16:01 ` Catalin Marinas
2014-04-22 16:01 ` Catalin Marinas
2014-04-22 16:01 ` Catalin Marinas
2014-04-21 14:37 ` Rob Herring
2014-04-21 14:37 ` Rob Herring
2014-04-21 14:37 ` Rob Herring
2014-04-21 15:13 ` Santosh Shilimkar
2014-04-21 15:13 ` Santosh Shilimkar
2014-04-21 15:35 ` Rob Herring
2014-04-21 15:35 ` Rob Herring
2014-04-21 15:35 ` Rob Herring
2014-04-21 15:36 ` Santosh Shilimkar
2014-04-21 15:36 ` Santosh Shilimkar
2014-04-21 15:36 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53551F81.9040209@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.