From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] i.MX: Do not explicitly call l2x0_of_init()
Date: Wed, 15 Jun 2016 12:41:09 +0200 [thread overview]
Message-ID: <5355653.147Wd29CCq@wuerfel> (raw)
In-Reply-To: <1465954193-5894-7-git-send-email-andrew.smirnov@gmail.com>
On Tuesday, June 14, 2016 6:29:53 PM CEST Andrey Smirnov wrote:
> DT_MACHINE_START(IMX35_DT, "Freescale i.MX35 (Device Tree Support)")
> .map_io = mx35_map_io,
> .init_early = imx35_init_early,
> - .init_irq = imx35_irq_init,
> + .init_irq = mx35_init_irq,
> .dt_compat = imx35_dt_board_compat,
> + .l2c_aux_val = 0,
> + .l2c_aux_mask = ~0,
> MACHINE_END
>
Please keep the fields sorted the same way that they are defined in
struct machine_desc, i.e. add the new fields at the top of this list.
Otherwise the whole series looks good to me now,
Acked-by: Arnd Bergmann <arnd@arndb.de>
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] i.MX: Do not explicitly call l2x0_of_init()
Date: Wed, 15 Jun 2016 12:41:09 +0200 [thread overview]
Message-ID: <5355653.147Wd29CCq@wuerfel> (raw)
In-Reply-To: <1465954193-5894-7-git-send-email-andrew.smirnov@gmail.com>
On Tuesday, June 14, 2016 6:29:53 PM CEST Andrey Smirnov wrote:
> DT_MACHINE_START(IMX35_DT, "Freescale i.MX35 (Device Tree Support)")
> .map_io = mx35_map_io,
> .init_early = imx35_init_early,
> - .init_irq = imx35_irq_init,
> + .init_irq = mx35_init_irq,
> .dt_compat = imx35_dt_board_compat,
> + .l2c_aux_val = 0,
> + .l2c_aux_mask = ~0,
> MACHINE_END
>
Please keep the fields sorted the same way that they are defined in
struct machine_desc, i.e. add the new fields at the top of this list.
Otherwise the whole series looks good to me now,
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2016-06-15 10:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 1:29 [PATCH v2 0/6] i.MX L2-cache code cleanups and performance tweaks Andrey Smirnov
2016-06-15 1:29 ` Andrey Smirnov
2016-06-15 1:29 ` [PATCH v2 1/6] i.MX: system.c: Convert goto to if statement Andrey Smirnov
2016-06-15 1:29 ` Andrey Smirnov
2016-06-15 1:29 ` [PATCH v2 2/6] i.MX: system.c: Remove redundant errata 752271 code Andrey Smirnov
2016-06-15 1:29 ` Andrey Smirnov
2016-06-15 1:29 ` [PATCH v2 3/6] i.MX: system.c: Replace magic numbers Andrey Smirnov
2016-06-15 1:29 ` Andrey Smirnov
2016-06-15 6:18 ` Uwe Kleine-König
2016-06-15 6:18 ` Uwe Kleine-König
2016-06-16 2:00 ` Shawn Guo
2016-06-16 2:00 ` Shawn Guo
2016-06-15 1:29 ` [PATCH v2 4/6] ARM: cache-l2x0: Do not clear bit 23 in prefetch control register Andrey Smirnov
2016-06-15 1:29 ` Andrey Smirnov
2016-06-15 1:29 ` [PATCH v2 5/6] i.MX: system.c: Tweak prefetch settings for performance Andrey Smirnov
2016-06-15 1:29 ` Andrey Smirnov
2016-06-15 1:29 ` [PATCH v2 6/6] i.MX: Do not explicitly call l2x0_of_init() Andrey Smirnov
2016-06-15 1:29 ` Andrey Smirnov
2016-06-15 10:41 ` Arnd Bergmann [this message]
2016-06-15 10:41 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5355653.147Wd29CCq@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.