All of lore.kernel.org
 help / color / mirror / Atom feed
* [ ulogd PATCH 2/2 ] fix to allow not using connstring parameter in pgsql plugin
@ 2014-04-21 20:16 Bob Hockney
  0 siblings, 0 replies; only message in thread
From: Bob Hockney @ 2014-04-21 20:16 UTC (permalink / raw)
  To: Eric Leblond; +Cc: The netfilter developer mailinglist

commit a565216f3f772514356a067d68b775331b01832a
Author: Bob Hockney <zeus@ix.netcom.com>
Date:   Sat Apr 19 12:43:37 2014 -0600

     Connection parameters other than connstring are ignored, forcing its
     use.  u.string in config_keyset in conffile.h is a character array,
     not a pointer, and is initialized as a zero length string, not a null
     pointer, so the pointer assignment to connstr will always be a valid
     pointer, not NULL, so (! connstr) will always be false.

     Signed-off-by: Bob Hockney <zeus@ix.netcom.com>

diff --git a/output/pgsql/ulogd_output_PGSQL.c 
b/output/pgsql/ulogd_output_PGSQL.c
index fda289e..ac87a64 100644
--- a/output/pgsql/ulogd_output_PGSQL.c
+++ b/output/pgsql/ulogd_output_PGSQL.c
@@ -236,7 +236,7 @@ static int open_db_pgsql(struct ulogd_pluginstance *upi)
      char *schema = NULL;
      char pgbuf[128];

-    if (!connstr) {
+    if (! strlen(connstr)) {
          char *server = host_ce(upi->config_kset).u.string;
          unsigned int port = port_ce(upi->config_kset).u.value;
          char *user = user_ce(upi->config_kset).u.string;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-04-21 20:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-21 20:16 [ ulogd PATCH 2/2 ] fix to allow not using connstring parameter in pgsql plugin Bob Hockney

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.