From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
eddie.dong@intel.com, xen-devel@lists.xen.org,
yang.z.zhang@intel.com, ian.jackson@eu.citrix.com
Subject: Re: [PATCH v8 1/3] xen/libxc: Allow changing max number of hypervisor cpuid leaves
Date: Tue, 22 Apr 2014 08:32:25 -0400 [thread overview]
Message-ID: <53566159.2090105@oracle.com> (raw)
In-Reply-To: <53565673020000780000AA82@nat28.tlf.novell.com>
On 04/22/2014 05:45 AM, Jan Beulich wrote:
>>>> On 21.04.14 at 23:57, <boris.ostrovsky@oracle.com> wrote:
>> + if ( (limit < 2) || (limit > XEN_CPUID_MAX_NUM_LEAVES) )
>> + limit = XEN_CPUID_MAX_NUM_LEAVES;
> Almost: If limit < 2, you would be better off using 2 rather than the
> default (which may be growing).
My thinking was that for any invalid limit value we should ignore what
the user file specified, not try to guess what was meant.
-boris
next prev parent reply other threads:[~2014-04-22 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 21:57 [PATCH v8 0/3] Expose HW APIC virtualization support to HVM guests Boris Ostrovsky
2014-04-21 21:57 ` [PATCH v8 1/3] xen/libxc: Allow changing max number of hypervisor cpuid leaves Boris Ostrovsky
2014-04-22 9:45 ` Jan Beulich
2014-04-22 12:32 ` Boris Ostrovsky [this message]
2014-04-22 12:41 ` Jan Beulich
2014-04-22 14:26 ` Don Slutz
2014-04-21 21:57 ` [PATCH v8 2/3] x86/hvm: Add HVM-specific hypervisor CPUID leaf Boris Ostrovsky
2014-04-21 21:57 ` [PATCH v8 3/3] x86/hvm: Indicate avaliability of HW support of APIC virtualization to HVM guests Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53566159.2090105@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.