* [PATCH] Correct cnum changes @ 2014-04-22 15:22 Andrew Earl 2014-04-22 15:22 ` [PATCH] handsfree: correct crash on connect of hfp Andrew Earl 0 siblings, 1 reply; 3+ messages in thread From: Andrew Earl @ 2014-04-22 15:22 UTC (permalink / raw) To: ofono [-- Attachment #1: Type: text/plain, Size: 475 bytes --] Hi Denis, With one of the corrections there is now a crash which occurs when formatting the properties for the handsfree interface. I have reverted one of the changes in the attached patch so the problem is fixed. I have followed the same convention as other interface such as gprs. Thanks, Andrew Andrew Earl (1): handsfree: correct crash on connect of hfp src/handsfree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.7.11.7 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] handsfree: correct crash on connect of hfp 2014-04-22 15:22 [PATCH] Correct cnum changes Andrew Earl @ 2014-04-22 15:22 ` Andrew Earl 2014-04-22 18:11 ` Denis Kenzior 0 siblings, 1 reply; 3+ messages in thread From: Andrew Earl @ 2014-04-22 15:22 UTC (permalink / raw) To: ofono [-- Attachment #1: Type: text/plain, Size: 931 bytes --] --- src/handsfree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/handsfree.c b/src/handsfree.c index d713731..3fc8d50 100644 --- a/src/handsfree.c +++ b/src/handsfree.c @@ -189,6 +189,7 @@ static void append_subscriber_numbers(GSList *subscriber_numbers, GSList *l; const char *subscriber_number_string; char arraysig[3]; + const char *key = "SubscriberNumbers"; arraysig[0] = DBUS_TYPE_ARRAY; arraysig[1] = DBUS_TYPE_STRING; @@ -197,7 +198,7 @@ static void append_subscriber_numbers(GSList *subscriber_numbers, dbus_message_iter_open_container(iter, DBUS_TYPE_DICT_ENTRY, NULL, &entry); dbus_message_iter_append_basic(&entry, DBUS_TYPE_STRING, - "SubscriberNumbers"); + &key); dbus_message_iter_open_container(&entry, DBUS_TYPE_VARIANT, arraysig, &variant); dbus_message_iter_open_container(&variant, DBUS_TYPE_ARRAY, -- 1.7.11.7 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] handsfree: correct crash on connect of hfp 2014-04-22 15:22 ` [PATCH] handsfree: correct crash on connect of hfp Andrew Earl @ 2014-04-22 18:11 ` Denis Kenzior 0 siblings, 0 replies; 3+ messages in thread From: Denis Kenzior @ 2014-04-22 18:11 UTC (permalink / raw) To: ofono [-- Attachment #1: Type: text/plain, Size: 247 bytes --] Hi Andrew, On 04/22/2014 10:22 AM, Andrew Earl wrote: > --- > src/handsfree.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Yep, my fault. Thanks for cleaning up after me. Patch has been applied. Regards, -Denis ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-22 18:11 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-04-22 15:22 [PATCH] Correct cnum changes Andrew Earl 2014-04-22 15:22 ` [PATCH] handsfree: correct crash on connect of hfp Andrew Earl 2014-04-22 18:11 ` Denis Kenzior
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.