All of lore.kernel.org
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: berlin: add CPU_V7 to Marvell Armada 1500-mini (BG2CD)
Date: Tue, 22 Apr 2014 20:35:00 +0200	[thread overview]
Message-ID: <5356B654.8050504@gmail.com> (raw)
In-Reply-To: <CAL_JsqKvBWk3bD3=G=kY+8yitV6M7Gx=7JnwJeH=yns5dvXbnA@mail.gmail.com>

On 04/22/2014 08:29 PM, Rob Herring wrote:
> On Tue, Apr 22, 2014 at 1:11 PM, Sebastian Hesselbarth
> <sebastian.hesselbarth@gmail.com> wrote:
>> On 04/15/2014 08:48 PM, Sebastian Hesselbarth wrote:
>>> This selects missing CPU_V7 for ARM Cortex-A9 based Marvell Armada
>>> 1500-mini (BG2CD).
>>>
>>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>>> ---
>>
>> Applied to berlin/soc.
>>
>>> ---
>>>  arch/arm/mach-berlin/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig
>>> index d3c5f14dc142..0add8350faf4 100644
>>> --- a/arch/arm/mach-berlin/Kconfig
>>> +++ b/arch/arm/mach-berlin/Kconfig
>>> @@ -18,6 +18,7 @@ config MACH_BERLIN_BG2
>>>  config MACH_BERLIN_BG2CD
>>>       bool "Marvell Armada 1500-mini (BG2CD)"
>>>       select CACHE_L2X0
>>> +     select CPU_V7
> 
> This should not be needed. This gets selected by multi-platform with
> ARCH_MULTI_V7.

Ok, you are right.

Currently, I have three different SoCs for MACH_BERLIN. One selects
CPU_PJ4B, one also selects CPU_V7. This would add CPU_V7 to BG2CD
just to make it symmetrical.

I can also remove it from BG2Q and only select CPU_PJ4B for the one
that is different.

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: berlin: add CPU_V7 to Marvell Armada 1500-mini (BG2CD)
Date: Tue, 22 Apr 2014 20:35:00 +0200	[thread overview]
Message-ID: <5356B654.8050504@gmail.com> (raw)
In-Reply-To: <CAL_JsqKvBWk3bD3=G=kY+8yitV6M7Gx=7JnwJeH=yns5dvXbnA@mail.gmail.com>

On 04/22/2014 08:29 PM, Rob Herring wrote:
> On Tue, Apr 22, 2014 at 1:11 PM, Sebastian Hesselbarth
> <sebastian.hesselbarth@gmail.com> wrote:
>> On 04/15/2014 08:48 PM, Sebastian Hesselbarth wrote:
>>> This selects missing CPU_V7 for ARM Cortex-A9 based Marvell Armada
>>> 1500-mini (BG2CD).
>>>
>>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>>> ---
>>
>> Applied to berlin/soc.
>>
>>> ---
>>>  arch/arm/mach-berlin/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig
>>> index d3c5f14dc142..0add8350faf4 100644
>>> --- a/arch/arm/mach-berlin/Kconfig
>>> +++ b/arch/arm/mach-berlin/Kconfig
>>> @@ -18,6 +18,7 @@ config MACH_BERLIN_BG2
>>>  config MACH_BERLIN_BG2CD
>>>       bool "Marvell Armada 1500-mini (BG2CD)"
>>>       select CACHE_L2X0
>>> +     select CPU_V7
> 
> This should not be needed. This gets selected by multi-platform with
> ARCH_MULTI_V7.

Ok, you are right.

Currently, I have three different SoCs for MACH_BERLIN. One selects
CPU_PJ4B, one also selects CPU_V7. This would add CPU_V7 to BG2CD
just to make it symmetrical.

I can also remove it from BG2Q and only select CPU_PJ4B for the one
that is different.

Sebastian


  reply	other threads:[~2014-04-22 18:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 18:48 [PATCH] ARM: berlin: add CPU_V7 to Marvell Armada 1500-mini (BG2CD) Sebastian Hesselbarth
2014-04-15 18:48 ` Sebastian Hesselbarth
2014-04-22 18:11 ` Sebastian Hesselbarth
2014-04-22 18:11   ` Sebastian Hesselbarth
2014-04-22 18:29   ` Rob Herring
2014-04-22 18:29     ` Rob Herring
2014-04-22 18:35     ` Sebastian Hesselbarth [this message]
2014-04-22 18:35       ` Sebastian Hesselbarth
2014-04-22 21:22     ` Sebastian Hesselbarth
2014-04-22 21:22       ` Sebastian Hesselbarth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5356B654.8050504@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.