From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] clk: berlin: add berlin clocks DT bindings documentation
Date: Wed, 23 Apr 2014 19:21:46 +0200 [thread overview]
Message-ID: <5357F6AA.1010406@gmail.com> (raw)
In-Reply-To: <1398261667-12621-3-git-send-email-alexandre.belloni@free-electrons.com>
On 04/23/2014 04:01 PM, Alexandre Belloni wrote:
> Document the newly added berlin clock driver
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> Cc: devicetree at vger.kernel.org
> Documentation/devicetree/bindings/clock/berlin-clock.txt | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/berlin-clock.txt b/Documentation/devicetree/bindings/clock/berlin-clock.txt
> index 49b7860bffb8..00f0053ef587 100644
> --- a/Documentation/devicetree/bindings/clock/berlin-clock.txt
> +++ b/Documentation/devicetree/bindings/clock/berlin-clock.txt
> @@ -9,6 +9,8 @@ Required properties:
> "marvell,berlin2-pll",
> "marvell,berlin2q-pll":
> CPU PLL and System PLL
> + "marvell,berlin2-clk":
> + simple clocks
> - reg: Address and length of the clock register set.
> - #clock-cells: from common clock binding; shall be set to 0.
> - clocks: from common clock binding
> @@ -26,4 +28,9 @@ cpupll: cpupll at ea003c {
> reg = <0xea003c 0x8>;
> };
>
> -
> +sdio0xinclk: sdio0xinclk at ea023c {
Yuck! ;)
Can't we just simply use "clock@<addr>" for the node name and
have the driver compute the name like simple-bus does?
Sebastian
> + compatible = "marvell,berlin-clk";
> + clocks = <&syspll>;
> + #clock-cells = <0>;
> + reg = <0xea023c 4>;
> +};
>
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Mike Turquette <mturquette@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/5] clk: berlin: add berlin clocks DT bindings documentation
Date: Wed, 23 Apr 2014 19:21:46 +0200 [thread overview]
Message-ID: <5357F6AA.1010406@gmail.com> (raw)
In-Reply-To: <1398261667-12621-3-git-send-email-alexandre.belloni@free-electrons.com>
On 04/23/2014 04:01 PM, Alexandre Belloni wrote:
> Document the newly added berlin clock driver
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> Cc: devicetree@vger.kernel.org
> Documentation/devicetree/bindings/clock/berlin-clock.txt | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/berlin-clock.txt b/Documentation/devicetree/bindings/clock/berlin-clock.txt
> index 49b7860bffb8..00f0053ef587 100644
> --- a/Documentation/devicetree/bindings/clock/berlin-clock.txt
> +++ b/Documentation/devicetree/bindings/clock/berlin-clock.txt
> @@ -9,6 +9,8 @@ Required properties:
> "marvell,berlin2-pll",
> "marvell,berlin2q-pll":
> CPU PLL and System PLL
> + "marvell,berlin2-clk":
> + simple clocks
> - reg: Address and length of the clock register set.
> - #clock-cells: from common clock binding; shall be set to 0.
> - clocks: from common clock binding
> @@ -26,4 +28,9 @@ cpupll: cpupll@ea003c {
> reg = <0xea003c 0x8>;
> };
>
> -
> +sdio0xinclk: sdio0xinclk@ea023c {
Yuck! ;)
Can't we just simply use "clock@<addr>" for the node name and
have the driver compute the name like simple-bus does?
Sebastian
> + compatible = "marvell,berlin-clk";
> + clocks = <&syspll>;
> + #clock-cells = <0>;
> + reg = <0xea023c 4>;
> +};
>
next prev parent reply other threads:[~2014-04-23 17:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 14:01 [PATCH 0/5] Berlin: add clock support Alexandre Belloni
2014-04-23 14:01 ` Alexandre Belloni
2014-04-23 14:01 ` [PATCH 1/5] clk: berlin: add support for clocks Alexandre Belloni
2014-04-23 14:01 ` Alexandre Belloni
2014-04-23 17:03 ` Sebastian Hesselbarth
2014-04-23 17:03 ` Sebastian Hesselbarth
2014-04-23 17:10 ` Sebastian Hesselbarth
2014-04-23 17:10 ` Sebastian Hesselbarth
2014-04-23 14:01 ` [PATCH 2/5] clk: berlin: add berlin clocks DT bindings documentation Alexandre Belloni
2014-04-23 14:01 ` Alexandre Belloni
2014-04-23 17:21 ` Sebastian Hesselbarth [this message]
2014-04-23 17:21 ` Sebastian Hesselbarth
2014-04-23 14:01 ` [PATCH 3/5] ARM: berlin/dt: add sdio clocks to BG2 Alexandre Belloni
2014-04-23 14:01 ` Alexandre Belloni
2014-04-23 14:01 ` [PATCH 4/5] ARM: berlin/dt: add sdio clocks to BG2CD Alexandre Belloni
2014-04-23 14:01 ` Alexandre Belloni
2014-04-23 22:51 ` Antoine Ténart
2014-04-23 22:51 ` Antoine Ténart
2014-04-23 14:01 ` [PATCH 5/5] ARM: berlin/dt: add sdio clocks to BG2Q Alexandre Belloni
2014-04-23 14:01 ` Alexandre Belloni
2014-04-23 22:49 ` Antoine Ténart
2014-04-23 22:49 ` Antoine Ténart
-- strict thread matches above, loose matches on Subject: below --
2014-03-21 11:43 [PATCH 0/5] berlin: initial support for the clocks Alexandre Belloni
2014-03-21 11:43 ` [PATCH 2/5] clk: berlin: add berlin clocks DT bindings documentation Alexandre Belloni
2014-03-21 11:43 ` Alexandre Belloni
2014-03-21 11:43 ` Alexandre Belloni
2014-03-21 11:53 ` Mark Rutland
2014-03-21 11:53 ` Mark Rutland
2014-03-21 12:16 ` Sebastian Hesselbarth
2014-03-21 12:16 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5357F6AA.1010406@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.