From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Devesh Sharma <Devesh.Sharma@Emulex.Com>,
Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Trond Myklebust <trond.myklebust@primarydata.com>
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
Date: Thu, 24 Apr 2014 10:12:53 +0300 [thread overview]
Message-ID: <5358B975.4020207@dev.mellanox.co.il> (raw)
In-Reply-To: <1bab6615-60c4-4865-a6a0-c53bb1c32341@CMEXHTCAS1.ad.emulex.com>
On 4/24/2014 2:30 AM, Devesh Sharma wrote:
> Hi Chuck
>
> Following is the complete call trace of a typical NFS-RDMA transaction while mounting a share.
> It is unavoidable to stop calling post-send in case it is not created. Therefore, applying checks to the connection state is a must
> While registering/deregistering frmrs on-the-fly. The unconnected state of QP implies don't call post_send/post_recv from any context.
>
Long thread... didn't follow it all.
If I understand correctly this race comes only for *cleanup* (LINV) of
FRMR registration while teardown flow destroyed the QP.
I think this might be disappear if for each registration you post LINV+FRMR.
This is assuming that a situation where trying to post Fastreg on a
"bad" QP can
never happen (usually since teardown flow typically suspends outgoing
commands).
Sagi.
WARNING: multiple messages have this Message-ID (diff)
From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Devesh Sharma
<Devesh.Sharma-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org>,
Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Linux NFS Mailing List
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Trond Myklebust
<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
Date: Thu, 24 Apr 2014 10:12:53 +0300 [thread overview]
Message-ID: <5358B975.4020207@dev.mellanox.co.il> (raw)
In-Reply-To: <1bab6615-60c4-4865-a6a0-c53bb1c32341-3RiH6ntJJkP8BX6JNMqfyFjyZtpTMMwT@public.gmane.org>
On 4/24/2014 2:30 AM, Devesh Sharma wrote:
> Hi Chuck
>
> Following is the complete call trace of a typical NFS-RDMA transaction while mounting a share.
> It is unavoidable to stop calling post-send in case it is not created. Therefore, applying checks to the connection state is a must
> While registering/deregistering frmrs on-the-fly. The unconnected state of QP implies don't call post_send/post_recv from any context.
>
Long thread... didn't follow it all.
If I understand correctly this race comes only for *cleanup* (LINV) of
FRMR registration while teardown flow destroyed the QP.
I think this might be disappear if for each registration you post LINV+FRMR.
This is assuming that a situation where trying to post Fastreg on a
"bad" QP can
never happen (usually since teardown flow typically suspends outgoing
commands).
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-24 7:12 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 18:40 [PATCH V1] NFS-RDMA: fix qp pointer validation checks Devesh Sharma
2014-04-09 18:40 ` Devesh Sharma
2014-04-09 20:22 ` Trond Myklebust
2014-04-09 20:22 ` Trond Myklebust
2014-04-09 20:26 ` Chuck Lever
2014-04-09 20:26 ` Chuck Lever
2014-04-09 23:56 ` Devesh Sharma
2014-04-09 23:56 ` Devesh Sharma
2014-04-10 0:26 ` Chuck Lever
2014-04-10 0:26 ` Chuck Lever
2014-04-10 15:01 ` Steve Wise
2014-04-10 15:01 ` Steve Wise
2014-04-10 17:43 ` Chuck Lever
2014-04-10 17:43 ` Chuck Lever
2014-04-10 18:34 ` Steve Wise
2014-04-10 18:34 ` Steve Wise
2014-04-10 17:42 ` Devesh Sharma
2014-04-10 17:42 ` Devesh Sharma
2014-04-10 17:51 ` Chuck Lever
2014-04-10 17:51 ` Chuck Lever
2014-04-10 17:54 ` Devesh Sharma
2014-04-10 17:54 ` Devesh Sharma
2014-04-10 19:53 ` Chuck Lever
2014-04-10 19:53 ` Chuck Lever
2014-04-11 23:51 ` Devesh Sharma
2014-04-11 23:51 ` Devesh Sharma
2014-04-13 4:01 ` Chuck Lever
2014-04-13 4:01 ` Chuck Lever
2014-04-14 20:53 ` Chuck Lever
2014-04-14 20:53 ` Chuck Lever
2014-04-14 22:46 ` Devesh Sharma
2014-04-14 22:46 ` Devesh Sharma
2014-04-15 0:39 ` Chuck Lever
2014-04-15 0:39 ` Chuck Lever
2014-04-15 18:25 ` Devesh Sharma
2014-04-15 18:25 ` Devesh Sharma
2014-04-23 23:30 ` Devesh Sharma
2014-04-23 23:30 ` Devesh Sharma
2014-04-24 7:12 ` Sagi Grimberg [this message]
2014-04-24 7:12 ` Sagi Grimberg
2014-04-24 15:01 ` Chuck Lever
2014-04-24 15:01 ` Chuck Lever
2014-04-24 15:48 ` Devesh Sharma
2014-04-24 15:48 ` Devesh Sharma
2014-04-24 17:44 ` Chuck Lever
2014-04-24 17:44 ` Chuck Lever
2014-04-27 10:12 ` Sagi Grimberg
2014-04-27 10:12 ` Sagi Grimberg
2014-04-27 12:37 ` Chuck Lever
2014-04-27 12:37 ` Chuck Lever
2014-04-28 8:58 ` Sagi Grimberg
2014-04-28 8:58 ` Sagi Grimberg
2014-04-14 23:55 ` Devesh Sharma
2014-04-14 23:55 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5358B975.4020207@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=Devesh.Sharma@Emulex.Com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.