All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: linus.walleij@linaro.org, Jianqun Xu <jay.xu@rock-chips.com>
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
	robh+dt@kernel.org, kever.yang@rock-chips.com,
	Liang Chen <cl@rock-chips.com>
Subject: Re: [PATCH 4/9] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank
Date: Tue, 22 Jun 2021 15:02:26 +0200	[thread overview]
Message-ID: <5359180.zXnORWrf4K@diego> (raw)
In-Reply-To: <20210618062449.1067106-5-jay.xu@rock-chips.com>

Hi Jay,

Am Freitag, 18. Juni 2021, 08:24:44 CEST schrieb Jianqun Xu:
> From: Liang Chen <cl@rock-chips.com>
> 
> The clock property need 2 items on some rockchip chips.
> 
> Signed-off-by: Liang Chen <cl@rock-chips.com>
> ---
>  .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml         | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> index d993e002cebe..0d62c28fb58d 100644
> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> @@ -22,7 +22,10 @@ properties:
>      maxItems: 1
>  
>    clocks:
> -    maxItems: 1
> +    minItems: 1
> +    items:
> +      - description: APB interface clock source
> +      - description: GPIO debounce reference clock source

as said in a previous mail, please adapt this to use clock-names for the
two clock variant. Maybe something like

clocks:
  minItems: 1
  maxItems: 2

clock-names:
  minItems: 1
  maxItems: 2
  items:
    - const: apb_pclk
    - const: debounce

if:
   properties:
     clocks:
       items:
         const: 2
then:
   required:
    - clock-names

[not yet sure if that works]



Heiko

>  
>    gpio-controller: true
>  
> 





WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: linus.walleij@linaro.org, Jianqun Xu <jay.xu@rock-chips.com>
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
	robh+dt@kernel.org, kever.yang@rock-chips.com,
	Liang Chen <cl@rock-chips.com>
Subject: Re: [PATCH 4/9] dt-bindings: gpio: change items restriction of clock for rockchip, gpio-bank
Date: Tue, 22 Jun 2021 15:02:26 +0200	[thread overview]
Message-ID: <5359180.zXnORWrf4K@diego> (raw)
In-Reply-To: <20210618062449.1067106-5-jay.xu@rock-chips.com>

Hi Jay,

Am Freitag, 18. Juni 2021, 08:24:44 CEST schrieb Jianqun Xu:
> From: Liang Chen <cl@rock-chips.com>
> 
> The clock property need 2 items on some rockchip chips.
> 
> Signed-off-by: Liang Chen <cl@rock-chips.com>
> ---
>  .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml         | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> index d993e002cebe..0d62c28fb58d 100644
> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> @@ -22,7 +22,10 @@ properties:
>      maxItems: 1
>  
>    clocks:
> -    maxItems: 1
> +    minItems: 1
> +    items:
> +      - description: APB interface clock source
> +      - description: GPIO debounce reference clock source

as said in a previous mail, please adapt this to use clock-names for the
two clock variant. Maybe something like

clocks:
  minItems: 1
  maxItems: 2

clock-names:
  minItems: 1
  maxItems: 2
  items:
    - const: apb_pclk
    - const: debounce

if:
   properties:
     clocks:
       items:
         const: 2
then:
   required:
    - clock-names

[not yet sure if that works]



Heiko

>  
>    gpio-controller: true
>  
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2021-06-22 13:02 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18  6:24 [PATCH v6 0/9] gpio-rockchip driver Jianqun Xu
2021-06-18  6:24 ` Jianqun Xu
2021-06-18  6:24 ` [PATCH 1/9] pinctrl/rockchip: always enable clock for gpio controller Jianqun Xu
2021-06-18  6:24   ` Jianqun Xu
2021-06-18  6:24 ` [PATCH 2/9] pinctrl/rockchip: separate struct rockchip_pin_bank to a head file Jianqun Xu
2021-06-18  6:24   ` Jianqun Xu
2021-06-18  6:24 ` [PATCH 3/9] pinctrl/rockchip: add pinctrl device to gpio bank struct Jianqun Xu
2021-06-18  6:24   ` Jianqun Xu
2021-06-18  6:24 ` [PATCH 4/9] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank Jianqun Xu
2021-06-18  6:24   ` [PATCH 4/9] dt-bindings: gpio: change items restriction of clock for rockchip, gpio-bank Jianqun Xu
2021-06-22 13:02   ` Heiko Stübner [this message]
2021-06-22 13:02     ` Heiko Stübner
2021-06-23 17:24     ` [PATCH 4/9] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank Rob Herring
2021-06-23 17:24       ` Rob Herring
2021-06-18  6:27 ` Jianqun Xu
2021-06-18  6:27   ` [PATCH 4/9] dt-bindings: gpio: change items restriction of clock for rockchip, gpio-bank Jianqun Xu
2021-06-18  6:27 ` [PATCH 5/9] gpio/rockchip: add driver for rockchip gpio Jianqun Xu
2021-06-18  6:27   ` Jianqun Xu
2021-06-18  6:28 ` [PATCH 6/9] gpio/rockchip: use struct rockchip_gpio_regs for gpio controller Jianqun Xu
2021-06-18  6:28   ` Jianqun Xu
2021-06-18  6:28 ` [PATCH 7/9] gpio/rockchip: support next version " Jianqun Xu
2021-06-18  6:28   ` Jianqun Xu
2021-06-18  6:29 ` [PATCH 8/9] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Jianqun Xu
2021-06-18  6:29   ` Jianqun Xu
2021-06-18  6:29 ` [PATCH 9/9] pinctrl/rockchip: drop the gpio related codes Jianqun Xu
2021-06-18  6:29   ` Jianqun Xu
2021-07-23 10:12   ` Linus Walleij
2021-07-23 10:12     ` Linus Walleij
2021-07-23 10:07 ` [PATCH v6 0/9] gpio-rockchip driver Linus Walleij
2021-07-23 10:07   ` Linus Walleij
2021-07-23 10:14   ` Linus Walleij
2021-07-23 10:14     ` Linus Walleij
2021-07-23 13:47     ` Peter Geis
2021-07-23 13:47       ` Peter Geis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5359180.zXnORWrf4K@diego \
    --to=heiko@sntech.de \
    --cc=cl@rock-chips.com \
    --cc=jay.xu@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.