From: Nishanth Menon <nm@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Saravana Kannan <skannan@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Markus Pargmann <mpa@pengutronix.de>
Subject: Re: [RESEND PATCH] regulator: core: Disable unused regulators after deferred probing is done
Date: Thu, 24 Apr 2014 09:18:22 -0500 [thread overview]
Message-ID: <53591D2E.8020505@ti.com> (raw)
In-Reply-To: <20140424133451.GZ12304@sirena.org.uk>
On 04/24/2014 08:34 AM, Mark Brown wrote:
> On Wed, Apr 23, 2014 at 06:10:50PM -0500, Nishanth Menon wrote:
>> From: Saravana Kannan <skannan@codeaurora.org>
>>
>> regulator_init_complete does a scan of regulators which dont have
>> always-on or consumers are automatically disabled as being unused.
>> However, with deferred probing, late_initcall() is too soon to
>> declare a regulator as unused as the regulator itself might not
>> have registered due to defferal - Example: A regulator deffered due
>> to i2bus not available which in turn is deffered due to pinctrl
>> availability.
>>
>> Since deferred probing is done in late_initcall(), do the cleanup of
>> unused regulators by regulator_init_complete in late_initcall_sync
>> instead of late_initcall.
>
> I'll apply this however since as we discussed on IRC last night it's
> going to make the issues with unconfigured regulators getting powered
> off more severe before I do so I'll change things so that regulators
> with no configuration at all don't get touched by the core.
>
Thanks Mark.
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] regulator: core: Disable unused regulators after deferred probing is done
Date: Thu, 24 Apr 2014 09:18:22 -0500 [thread overview]
Message-ID: <53591D2E.8020505@ti.com> (raw)
In-Reply-To: <20140424133451.GZ12304@sirena.org.uk>
On 04/24/2014 08:34 AM, Mark Brown wrote:
> On Wed, Apr 23, 2014 at 06:10:50PM -0500, Nishanth Menon wrote:
>> From: Saravana Kannan <skannan@codeaurora.org>
>>
>> regulator_init_complete does a scan of regulators which dont have
>> always-on or consumers are automatically disabled as being unused.
>> However, with deferred probing, late_initcall() is too soon to
>> declare a regulator as unused as the regulator itself might not
>> have registered due to defferal - Example: A regulator deffered due
>> to i2bus not available which in turn is deffered due to pinctrl
>> availability.
>>
>> Since deferred probing is done in late_initcall(), do the cleanup of
>> unused regulators by regulator_init_complete in late_initcall_sync
>> instead of late_initcall.
>
> I'll apply this however since as we discussed on IRC last night it's
> going to make the issues with unconfigured regulators getting powered
> off more severe before I do so I'll change things so that regulators
> with no configuration at all don't get touched by the core.
>
Thanks Mark.
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Saravana Kannan <skannan@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Markus Pargmann <mpa@pengutronix.de>
Subject: Re: [RESEND PATCH] regulator: core: Disable unused regulators after deferred probing is done
Date: Thu, 24 Apr 2014 09:18:22 -0500 [thread overview]
Message-ID: <53591D2E.8020505@ti.com> (raw)
In-Reply-To: <20140424133451.GZ12304@sirena.org.uk>
On 04/24/2014 08:34 AM, Mark Brown wrote:
> On Wed, Apr 23, 2014 at 06:10:50PM -0500, Nishanth Menon wrote:
>> From: Saravana Kannan <skannan@codeaurora.org>
>>
>> regulator_init_complete does a scan of regulators which dont have
>> always-on or consumers are automatically disabled as being unused.
>> However, with deferred probing, late_initcall() is too soon to
>> declare a regulator as unused as the regulator itself might not
>> have registered due to defferal - Example: A regulator deffered due
>> to i2bus not available which in turn is deffered due to pinctrl
>> availability.
>>
>> Since deferred probing is done in late_initcall(), do the cleanup of
>> unused regulators by regulator_init_complete in late_initcall_sync
>> instead of late_initcall.
>
> I'll apply this however since as we discussed on IRC last night it's
> going to make the issues with unconfigured regulators getting powered
> off more severe before I do so I'll change things so that regulators
> with no configuration at all don't get touched by the core.
>
Thanks Mark.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-04-24 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 23:10 [RESEND PATCH] regulator: core: Disable unused regulators after deferred probing is done Nishanth Menon
2014-04-23 23:10 ` Nishanth Menon
2014-04-23 23:10 ` Nishanth Menon
2014-04-24 13:34 ` Mark Brown
2014-04-24 13:34 ` Mark Brown
2014-04-24 14:18 ` Nishanth Menon [this message]
2014-04-24 14:18 ` Nishanth Menon
2014-04-24 14:18 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53591D2E.8020505@ti.com \
--to=nm@ti.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.