From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>
Cc: Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH v2 4/4] perf/x86/uncore: modularize Intel uncore driver
Date: Fri, 25 Apr 2014 21:17:36 +0800 [thread overview]
Message-ID: <535A6070.90803@intel.com> (raw)
In-Reply-To: <20140424112715.GQ11096@twins.programming.kicks-ass.net>
On 04/24/2014 07:27 PM, Peter Zijlstra wrote:
> On Thu, Apr 24, 2014 at 12:36:01PM +0200, Stephane Eranian wrote:
>>> Most of hardware specific codes in the Intel uncore driver are for
>>> SandyBridge/IvyBridge/Haswell. Uncore subsystem in these CPUs are
>>> similar. One module per CPU type means we have to duplicate lots of
>>> code. I don't think it's a good idea.
>>>
>> Then, at least split nhm_ex from the rest. It is very big.
>
> Aren't the EX parts in general far more complex and different from the
> EP parts? Or will the SNB/IVB/HSW-EX parts also be similar again? (this
> would be a good thing).
SNB/IVB/HSW-EX are almost identical to SNB/IVB/HSW-EP. NHM/WSM-EX are complete
different from SNB/IVB/HSW-EX
Regards
Yan, Zheng
>
> But yes, it makes sense to at least split the EP and EX parts, and split
> where the families are different.
>
next prev parent reply other threads:[~2014-04-25 13:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 6:03 [PATCH v2 4/4] perf/x86/uncore: modularize Intel uncore driver Yan, Zheng
2014-03-20 8:27 ` Peter Zijlstra
2014-04-18 10:53 ` Ingo Molnar
2014-04-18 16:49 ` Andi Kleen
2014-04-21 2:18 ` Yan, Zheng
2014-04-22 11:35 ` Ingo Molnar
2014-04-23 14:55 ` Stephane Eranian
2014-04-24 8:14 ` Ingo Molnar
2014-04-24 10:25 ` Yan, Zheng
2014-04-24 10:36 ` Stephane Eranian
2014-04-24 10:37 ` Yan, Zheng
2014-04-24 11:27 ` Peter Zijlstra
2014-04-25 13:17 ` Yan, Zheng [this message]
2014-04-25 13:55 ` Peter Zijlstra
2014-04-25 14:06 ` Yan, Zheng
2014-04-25 14:35 ` Peter Zijlstra
2014-04-25 14:44 ` Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535A6070.90803@intel.com \
--to=zheng.z.yan@intel.com \
--cc=acme@infradead.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.