All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>, Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
	Theodore Tso <tytso@mit.edu>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: introduce FSX_AVOID env var
Date: Fri, 25 Apr 2014 08:57:52 -0500	[thread overview]
Message-ID: <535A69E0.80900@sandeen.net> (raw)
In-Reply-To: <20140425063153.GC27527@infradead.org>

On 4/25/14, 1:31 AM, Christoph Hellwig wrote:
> On Mon, Apr 21, 2014 at 11:30:04AM -0500, Eric Sandeen wrote:
>> Just like FSSTRESS_AVOID, FSX_AVOID can be used to add
>> options at the end of the default fsx runs in each test.
>> i.e. FSX_AVOID="-H -z -C" will disable punch hole, zero range,
>> and collapse range calls in all tests which run fsx.
>>
>> This should handle Ted's concerns about buggy ext4 fallocate
>> code without needing to add tunables to the kernel to reject
>> these operations during xfstests runs.
> 
> I would much prefer to add a little _run_fsx helper to encapsulate this.
> 

Dave already merged it, but yeah, that's a good idea, for fsx
as well as fsstress.

-Eric


WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>, Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
	Theodore Tso <tytso@mit.edu>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: introduce FSX_AVOID env var
Date: Fri, 25 Apr 2014 08:57:52 -0500	[thread overview]
Message-ID: <535A69E0.80900@sandeen.net> (raw)
In-Reply-To: <20140425063153.GC27527@infradead.org>

On 4/25/14, 1:31 AM, Christoph Hellwig wrote:
> On Mon, Apr 21, 2014 at 11:30:04AM -0500, Eric Sandeen wrote:
>> Just like FSSTRESS_AVOID, FSX_AVOID can be used to add
>> options at the end of the default fsx runs in each test.
>> i.e. FSX_AVOID="-H -z -C" will disable punch hole, zero range,
>> and collapse range calls in all tests which run fsx.
>>
>> This should handle Ted's concerns about buggy ext4 fallocate
>> code without needing to add tunables to the kernel to reject
>> these operations during xfstests runs.
> 
> I would much prefer to add a little _run_fsx helper to encapsulate this.
> 

Dave already merged it, but yeah, that's a good idea, for fsx
as well as fsstress.

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-04-25 13:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-21 16:30 [PATCH] xfstests: introduce FSX_AVOID env var Eric Sandeen
2014-04-25  6:31 ` Christoph Hellwig
2014-04-25 13:57   ` Eric Sandeen [this message]
2014-04-25 13:57     ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535A69E0.80900@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.