From: Nishanth Menon <nm@ti.com>
To: Tony Lindgren <tony@atomide.com>, Felipe Balbi <balbi@ti.com>
Cc: dbaryshkov@gmail.com, dwmw2@infradead.org,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH] power: twl4030_charger: clear IRQs after handling them
Date: Fri, 25 Apr 2014 15:58:10 -0500 [thread overview]
Message-ID: <535ACC62.102@ti.com> (raw)
In-Reply-To: <20140416163526.GA3049@atomide.com>
On 04/16/2014 11:35 AM, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [140416 08:18]:
>> TRM says we *must* write 1 to each bit we're handling
>> in order to clear the IRQ status and bring IRQ line
>> low. This patch implements that.
>>
>> Signed-off-by: Felipe Balbi <balbi@ti.com>
>> ---
>>
>> Russell, I don't have HW to test, but this should
>> solve the problem you saw when not using battery
>> with Zoom board. Let me know if it doesn't.
>
> BTW, looks like we're enabling BCI automatically in twl4030.dtsi
> while the legacy booting does not have TWL_COMMON_PDATA_BCI
> enabled for LDP. Anyways, for LDP BCI should be enabled for
> sure, that's the only way to power at least the earlier LDP
> revisions.
>
I picked up https://patchwork.kernel.org/patch/4002371/ for testing.
Unfortunately, it does not seem to work in my tests:
ldp-board-no-battery uses upstream u-boot in a chainloaded
configuration + does not have battery plugged in, instead, just J58
(charger) is connected - this is plugged on a remote farm setup for
developers to work with.
ldp-board-with-battery uses legacy bootloader with a battery simulator.
omap2plus_defconfig + CONFIG_CHARGER_TWL4030 enabled.
Result:
v3-15-rc2-ldp-board-no-battery: Boot FAIL:
http://slexy.org/raw/s20riTwu04
v3-15-rc2-ldp-board-with-battery: Boot PASS:
http://slexy.org/raw/s2elKdJpI7
v3-15-rc2-with-felipe-fix-ldp-board-no-battery: Boot FAIL:
http://slexy.org/raw/s20lKp2o0s
This patch should probably also acknowledge that Russell reported this
issue.
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] power: twl4030_charger: clear IRQs after handling them
Date: Fri, 25 Apr 2014 15:58:10 -0500 [thread overview]
Message-ID: <535ACC62.102@ti.com> (raw)
In-Reply-To: <20140416163526.GA3049@atomide.com>
On 04/16/2014 11:35 AM, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [140416 08:18]:
>> TRM says we *must* write 1 to each bit we're handling
>> in order to clear the IRQ status and bring IRQ line
>> low. This patch implements that.
>>
>> Signed-off-by: Felipe Balbi <balbi@ti.com>
>> ---
>>
>> Russell, I don't have HW to test, but this should
>> solve the problem you saw when not using battery
>> with Zoom board. Let me know if it doesn't.
>
> BTW, looks like we're enabling BCI automatically in twl4030.dtsi
> while the legacy booting does not have TWL_COMMON_PDATA_BCI
> enabled for LDP. Anyways, for LDP BCI should be enabled for
> sure, that's the only way to power at least the earlier LDP
> revisions.
>
I picked up https://patchwork.kernel.org/patch/4002371/ for testing.
Unfortunately, it does not seem to work in my tests:
ldp-board-no-battery uses upstream u-boot in a chainloaded
configuration + does not have battery plugged in, instead, just J58
(charger) is connected - this is plugged on a remote farm setup for
developers to work with.
ldp-board-with-battery uses legacy bootloader with a battery simulator.
omap2plus_defconfig + CONFIG_CHARGER_TWL4030 enabled.
Result:
v3-15-rc2-ldp-board-no-battery: Boot FAIL:
http://slexy.org/raw/s20riTwu04
v3-15-rc2-ldp-board-with-battery: Boot PASS:
http://slexy.org/raw/s2elKdJpI7
v3-15-rc2-with-felipe-fix-ldp-board-no-battery: Boot FAIL:
http://slexy.org/raw/s20lKp2o0s
This patch should probably also acknowledge that Russell reported this
issue.
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Tony Lindgren <tony@atomide.com>, Felipe Balbi <balbi@ti.com>
Cc: <dbaryshkov@gmail.com>, <dwmw2@infradead.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH] power: twl4030_charger: clear IRQs after handling them
Date: Fri, 25 Apr 2014 15:58:10 -0500 [thread overview]
Message-ID: <535ACC62.102@ti.com> (raw)
In-Reply-To: <20140416163526.GA3049@atomide.com>
On 04/16/2014 11:35 AM, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [140416 08:18]:
>> TRM says we *must* write 1 to each bit we're handling
>> in order to clear the IRQ status and bring IRQ line
>> low. This patch implements that.
>>
>> Signed-off-by: Felipe Balbi <balbi@ti.com>
>> ---
>>
>> Russell, I don't have HW to test, but this should
>> solve the problem you saw when not using battery
>> with Zoom board. Let me know if it doesn't.
>
> BTW, looks like we're enabling BCI automatically in twl4030.dtsi
> while the legacy booting does not have TWL_COMMON_PDATA_BCI
> enabled for LDP. Anyways, for LDP BCI should be enabled for
> sure, that's the only way to power at least the earlier LDP
> revisions.
>
I picked up https://patchwork.kernel.org/patch/4002371/ for testing.
Unfortunately, it does not seem to work in my tests:
ldp-board-no-battery uses upstream u-boot in a chainloaded
configuration + does not have battery plugged in, instead, just J58
(charger) is connected - this is plugged on a remote farm setup for
developers to work with.
ldp-board-with-battery uses legacy bootloader with a battery simulator.
omap2plus_defconfig + CONFIG_CHARGER_TWL4030 enabled.
Result:
v3-15-rc2-ldp-board-no-battery: Boot FAIL:
http://slexy.org/raw/s20riTwu04
v3-15-rc2-ldp-board-with-battery: Boot PASS:
http://slexy.org/raw/s2elKdJpI7
v3-15-rc2-with-felipe-fix-ldp-board-no-battery: Boot FAIL:
http://slexy.org/raw/s20lKp2o0s
This patch should probably also acknowledge that Russell reported this
issue.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-04-25 20:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 15:14 [PATCH] power: twl4030_charger: clear IRQs after handling them Felipe Balbi
2014-04-16 15:14 ` Felipe Balbi
2014-04-16 15:14 ` Felipe Balbi
2014-04-16 16:35 ` Tony Lindgren
2014-04-16 16:35 ` Tony Lindgren
2014-04-16 16:35 ` Tony Lindgren
2014-04-25 20:58 ` Nishanth Menon [this message]
2014-04-25 20:58 ` Nishanth Menon
2014-04-25 20:58 ` Nishanth Menon
2014-04-25 21:00 ` Felipe Balbi
2014-04-25 21:00 ` Felipe Balbi
2014-04-25 21:00 ` Felipe Balbi
2014-05-07 0:24 ` Nishanth Menon
2014-05-07 0:24 ` Nishanth Menon
2014-05-07 0:24 ` Nishanth Menon
2014-05-09 1:03 ` Tony Lindgren
2014-05-09 1:03 ` Tony Lindgren
2014-05-09 12:39 ` Nishanth Menon
2014-05-09 12:39 ` Nishanth Menon
2014-05-09 12:39 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535ACC62.102@ti.com \
--to=nm@ti.com \
--cc=balbi@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.