Re: [Qemu-trivial] [PATCH] po/Makefile: Fix source path for in-tree builds

[Stefan Weil <sw@weilnetz.de>]

Am 27.04.2014 11:37, schrieb Michael Tokarev:
> 
> How about moving it below inclusion of config-host.mak and using something like
> 
>  SRC_PATH ?= $(realpath ..)
> 
> ?  I dunno how gnu'ish this construct is... :)
> 
> 
> However, I think I've a better fix for this:
> 
> Author: Michael Tokarev <mjt@tls.msk.ru>
> Date:   Sun Apr 27 13:32:07 2014 +0400
> 
>     po/Makefile: fix $SRC_PATH reference
> 
>     The rule for messages.po appears to be slightly wrong.
>     Move the `cd' command within parens.
> 
>     Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>     Cc: Stefan Weil <sw@weilnetz.de>
>     Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> 
> diff --git a/po/Makefile b/po/Makefile
> index 705166e..669f865 100644
> --- a/po/Makefile
> +++ b/po/Makefile
> @@ -37,8 +37,8 @@ install: $(OBJS)
>         $(call quiet-command, msgfmt -o $@ $<, "  GEN   $@")
> 
>  $(PO_PATH)/messages.po: $(SRC_PATH)/ui/gtk.c
> -       $(call quiet-command, cd $(SRC_PATH) && \
> -        (xgettext -o - --from-code=UTF-8 --foreign-user \
> +       $(call quiet-command, ( cd $(SRC_PATH) && \
> +          xgettext -o - --from-code=UTF-8 --foreign-user \
>             --package-name=QEMU --package-version=$(VERSION) \
>             --msgid-bugs-address=qemu-devel@nongnu.org -k_ -C ui/gtk.c | \
>           sed -e s/CHARSET/UTF-8/) >$@, "  GEN   $@")
> 
> 
> Note the already existing parens () -- it looks like this is in order to
> run commands within a subshell (with its own current directory) but still
> have correct output redirection.
> 
> If you don't have objections, I'll apply my version (it also fixes the issue).
> 
> Thanks,
> 
> /mjt
> 
> Thanks,
> 
> /mjt
> 


Tested-by: Stefan Weil <sw@weilnetz.de>

Cheers,
Stefan