From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Ellerman <michael@ellerman.id.au>,
David.Laight@aculab.com,
Linux PPC <linuxppc-dev@lists.ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH v2 6/6] powerpc/perf/hv-24x7: catalog version number is be64, not be32
Date: Sun, 27 Apr 2014 21:59:19 -0700 [thread overview]
Message-ID: <535DE027.5050700@linux.vnet.ibm.com> (raw)
In-Reply-To: <1398660478.30694.10.camel@pasglop>
On 04/27/2014 09:47 PM, Benjamin Herrenschmidt wrote:
> On Tue, 2014-04-15 at 10:10 -0700, Cody P Schafer wrote:
>> The catalog version number was changed from a be32 (with proceeding
>> 32bits of padding) to a be64, update the code to treat it as a be64
>>
>> Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
>> --
>
> Have you tested this ?
>
> It doesn't build for me:
>
> arch/powerpc/perf/hv-24x7.c: In function 'catalog_read':
> arch/powerpc/perf/hv-24x7.c:223:3: error: format '%d' expects argument of type 'int', but argument 2 has type 'uint64_t' [-Werror=format]
> cc1: all warnings being treated as errors
I have, and I wasn't initially sure how I managed to miss that
warning-as-error. On examination: My config (for some reason) has
CONFIG_PPC_DISABLE_WERROR=y set (probably because it's a variation of a
distro config). Must have been piping the warnings to a file and
forgotten to check the file.
> I'll fix that up in my tree.
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Ellerman <michael@ellerman.id.au>,
Linux PPC <linuxppc-dev@lists.ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>,
Anton Blanchard <anton@samba.org>,
David.Laight@aculab.com
Subject: Re: [PATCH v2 6/6] powerpc/perf/hv-24x7: catalog version number is be64, not be32
Date: Sun, 27 Apr 2014 21:59:19 -0700 [thread overview]
Message-ID: <535DE027.5050700@linux.vnet.ibm.com> (raw)
In-Reply-To: <1398660478.30694.10.camel@pasglop>
On 04/27/2014 09:47 PM, Benjamin Herrenschmidt wrote:
> On Tue, 2014-04-15 at 10:10 -0700, Cody P Schafer wrote:
>> The catalog version number was changed from a be32 (with proceeding
>> 32bits of padding) to a be64, update the code to treat it as a be64
>>
>> Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
>> --
>
> Have you tested this ?
>
> It doesn't build for me:
>
> arch/powerpc/perf/hv-24x7.c: In function 'catalog_read':
> arch/powerpc/perf/hv-24x7.c:223:3: error: format '%d' expects argument of type 'int', but argument 2 has type 'uint64_t' [-Werror=format]
> cc1: all warnings being treated as errors
I have, and I wasn't initially sure how I managed to miss that
warning-as-error. On examination: My config (for some reason) has
CONFIG_PPC_DISABLE_WERROR=y set (probably because it's a variation of a
distro config). Must have been piping the warnings to a file and
forgotten to check the file.
> I'll fix that up in my tree.
Thanks.
next prev parent reply other threads:[~2014-04-28 5:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 17:10 [PATCH v2 0/6] powerpc/perf/hv_{gpci,24x7}: fixes Cody P Schafer
2014-04-15 17:10 ` Cody P Schafer
2014-04-15 17:10 ` [PATCH v2 1/6] powerpc/perf/hv_24x7: probe errors changed to pr_debug(), padding fixed Cody P Schafer
2014-04-15 17:10 ` Cody P Schafer
2014-04-15 17:10 ` [PATCH v2 2/6] powerpc/perf/hv_gpci: probe failures use pr_debug(), and padding reduced Cody P Schafer
2014-04-15 17:10 ` Cody P Schafer
2014-04-15 17:10 ` [PATCH v2 3/6] powerpc/perf/hv-gpci: make device attr static Cody P Schafer
2014-04-15 17:10 ` Cody P Schafer
2014-04-15 17:10 ` [PATCH v2 4/6] powerpc/perf/hv-24x7: use (unsigned long) not (u32) values when calling plpar_hcall_norets() Cody P Schafer
2014-04-15 17:10 ` Cody P Schafer
2014-04-15 17:10 ` [PATCH v2 5/6] powerpc/perf/hv-24x7: remove [static 4096], sparse chokes on it Cody P Schafer
2014-04-15 17:10 ` Cody P Schafer
2014-04-15 17:10 ` [PATCH v2 6/6] powerpc/perf/hv-24x7: catalog version number is be64, not be32 Cody P Schafer
2014-04-15 17:10 ` Cody P Schafer
2014-04-28 4:47 ` Benjamin Herrenschmidt
2014-04-28 4:47 ` Benjamin Herrenschmidt
2014-04-28 4:59 ` Cody P Schafer [this message]
2014-04-28 4:59 ` Cody P Schafer
2014-04-29 3:12 ` Michael Ellerman
2014-04-29 3:12 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535DE027.5050700@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=David.Laight@aculab.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.