From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, Feng Wu <feng.wu@intel.com>,
ian.campbell@citrix.com, eddie.dong@intel.com,
xen-devel@lists.xen.org, jun.nakajima@intel.com
Subject: Re: [PATCH v3 2/9] x86: move common_interrupt to entry.S
Date: Mon, 28 Apr 2014 10:49:56 +0100 [thread overview]
Message-ID: <535E2444.1020701@citrix.com> (raw)
In-Reply-To: <535E400B020000780000CC6E@nat28.tlf.novell.com>
On 28/04/14 10:48, Jan Beulich wrote:
>>>> On 28.04.14 at 11:25, <andrew.cooper3@citrix.com> wrote:
>> On 28/04/14 04:14, Feng Wu wrote:
>>> This patch moves label common_interrupt from asm_defns.h to entry.S
>>>
>>> Signed-off-by: Feng Wu <feng.wu@intel.com>
>> I am fairly sure the __asm__(".section .text"); was bogus, given no
>> obvious special case hacks play with the sections of this file.
> I'm fairly sure it's needed, and - what may make things worse - only
> with some compiler versions: If the compiler emitted any data before
> processing the file scope asm()s, the code generated here would end
> up in that data section.
>
> Jan
Ah ok. In which case it needs to be kept until all the interrupt logic
has moved.
~Andrew
prev parent reply other threads:[~2014-04-28 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 3:14 [PATCH v3 2/9] x86: move common_interrupt to entry.S Feng Wu
2014-04-28 9:16 ` Jan Beulich
2014-04-28 9:25 ` Wu, Feng
2014-04-28 9:25 ` Andrew Cooper
2014-04-28 9:48 ` Jan Beulich
2014-04-28 9:49 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535E2444.1020701@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=feng.wu@intel.com \
--cc=ian.campbell@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.