From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2/4] x86/boot: Early data should live in init.data
Date: Mon, 28 Apr 2014 11:41:09 +0100 [thread overview]
Message-ID: <535E3045.2040001@citrix.com> (raw)
In-Reply-To: <535E4B9B020000780000CD86@nat28.tlf.novell.com>
On 28/04/14 11:37, Jan Beulich wrote:
>>>> On 28.04.14 at 12:16, <andrew.cooper3@citrix.com> wrote:
>> On 28/04/14 11:08, Jan Beulich wrote:
>>>>>> On 25.04.14 at 21:50, <andrew.cooper3@citrix.com> wrote:
>>>> --- a/xen/arch/x86/boot/head.S
>>>> +++ b/xen/arch/x86/boot/head.S
>>>> @@ -32,11 +32,17 @@ ENTRY(start)
>>>> /* Checksum: must be the negated sum of the first two fields. */
>>>> .long -(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS)
>>>>
>>>> - .section .init.text, "ax"
>>>> + .section .init.data, "aw", @progbits
>>>> +
>>>> +gdt_boot_descr:
>>>> + .word 6*8-1
>>>> + .long sym_phys(trampoline_gdt)
>>> While at it, how about putting this on a 2 mod 4 boundary?
>> Yes, and the strings below into .rodata
> Actually not just them - the construct above is read-only too afaict.
>
> Jan
Yes - I noticed as much when starting to implement the changed.
~Andrew
next prev parent reply other threads:[~2014-04-28 10:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 19:50 [PATCH 0/4] Improvements to x86 boot code Andrew Cooper
2014-04-25 19:50 ` [PATCH 1/4] x86/boot: Remove high_start and ret_point Andrew Cooper
2014-04-25 19:50 ` [PATCH 2/4] x86/boot: Early data should live in init.data Andrew Cooper
2014-04-28 10:08 ` Jan Beulich
2014-04-28 10:16 ` Andrew Cooper
2014-04-28 10:37 ` Jan Beulich
2014-04-28 10:41 ` Andrew Cooper [this message]
2014-04-25 19:50 ` [PATCH 3/4] x86/boot: Move some __high_start code and data into init sections Andrew Cooper
2014-04-28 10:12 ` Jan Beulich
2014-04-28 10:16 ` Andrew Cooper
2014-04-25 19:50 ` [PATCH 4/4] x86/boot: Use 'hlt' inside terminal loops Andrew Cooper
2014-04-28 10:14 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535E3045.2040001@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.