Re: [PATCH v3 09/16] xen/arm: use device api to detect GIC version

[Julien Grall <julien.grall@linaro.org>]

On 29/04/14 09:55, Ian Campbell wrote:
> On Tue, 2014-04-29 at 12:37 +0530, Vijay Kilari wrote:
>> On Wed, Apr 23, 2014 at 8:31 PM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
>>> On Tue, 2014-04-15 at 16:47 +0530, vijay.kilari@gmail.com wrote:
>>>> +static const char * const gicv2_dt_compat[] __initconst =
>>>> +{
>>>> +    "arm,cortex-a15-gic",
>>>> +    "arm,cortex-a9-gic",
>>>
>>> This is DT_MATCH_GIC. Please keep using it. Perhaps you will want to
>>> rename it to DT_MATCH_GICV2.
>>>
>> DT_MATCH_GIC is redefined as DT_MATCH_COMPATIBLE, so could not
>> use it here.
>> #define DT_MATCH_GIC    DT_MATCH_COMPATIBLE("arm,cortex-a15-gic"), \
>>                          DT_MATCH_COMPATIBLE("arm,cortex-a7-gic")
>
> Hrm I thought you were removing the existing use of DT_MATCH_GIC so you
> could change it, but actually one remains.
>
> A little unsatisfactory to have this list twice. Not sure what to do. At
> the least we could define DT_MATCH_GIC_COMPATIBLE and
> DT_MATCH_GIC_STRING next to each other in the same header.

We could also extend/modify the device API to accept DT_MATCH* instead 
of a list of compatible string.

I don't really like this solution but it will avoid to have 2 times the 
same list of compatible string with only minor changes.

Regards,

-- 
Julien Grall