Re: [PATCH v3 06/16] xen/arm: move gic lock out of gic data structure

[Julien Grall <julien.grall@linaro.org>]

Hi Vijay,

On 04/15/2014 12:17 PM, vijay.kilari@gmail.com wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> 
> spinlock is used across generic and GIC low level
> functions. Move this lock out of gic data.
> This helps to separate generic and low level functions
> later.
> 
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> ---
>  xen/arch/arm/gic.c |   35 ++++++++++++++++++-----------------
>  1 file changed, 18 insertions(+), 17 deletions(-)
> 
> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
> index 05f2240..7c9a408 100644
> --- a/xen/arch/arm/gic.c
> +++ b/xen/arch/arm/gic.c
> @@ -35,6 +35,8 @@
>  #include <asm/gic_v2_defs.h>
>  #include <asm/gic.h>
>  
> +static spinlock_t gic_lock;
> +

You can directly use DEFINE_SPINCLOCK(gic_lock). This will avoid the
spin_lock_init in gic_init.

Regards,

-- 
Julien Grall