All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 0/9] drm/nouveau: support for GK20A, cont'd
Date: Thu, 1 May 2014 16:14:56 +0900	[thread overview]
Message-ID: <5361F470.5050306@nvidia.com> (raw)
In-Reply-To: <CACAvsv5x6uZcTGUTa3-wBRo0sJ-557sJ_d8r0kscODhr18yzBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 05/01/2014 04:11 PM, Ben Skeggs wrote:
> On Fri, Apr 25, 2014 at 5:19 PM, Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
>> Changes since v2:
>> - Enabled software class
>> - Removed unneeded changes to nouveau_accel_init()
>> - Replaced use of architecture-private pfn_to_dma() and dma_to_pfn() with
>>    the portable page_to_phys()/phys_to_page()
> page_to_phys() looks well defined and used everywhere, phys_to_page()
> not so much (including on amd64) :(

Argh, dammit. Now I *really* wonder what one is supposed to use in such 
cases...

Let me come with a v4 then. I will address the other issue with external 
firmware at the same time.

Sorry for the inconvenience.

>
>> - Fixed incorrect comment/commit log talking about bytes instead of words
>>
>> Hope this looks good! Once this gets merged the next set will be to use this
>> driver on Jetson and Venice2 boards.
>>
>> Cheers,
>>
>> Alexandre Courbot (9):
>>    drm/nouveau/bar: only ioremap BAR3 if it exists
>>    drm/nouveau/bar/nvc0: support chips without BAR3
>>    drm/nouveau/ibus: add GK20A support
>>    drm/nouveau/fb: add GK20A support
>>    drm/nouveau/fifo: add GK20A support
>>    drm/nouveau/graph: enable when using external firmware
>>    drm/nouveau/graph: pad firmware code at load time
>>    drm/nouveau/graph: add GK20A support
>>    drm/nouveau: support for probing GK20A
>>
>>   drivers/gpu/drm/nouveau/Makefile                   |   6 +
>>   drivers/gpu/drm/nouveau/core/engine/device/nve0.c  |  17 +++
>>   drivers/gpu/drm/nouveau/core/engine/fifo/gk20a.c   |  35 +++++
>>   drivers/gpu/drm/nouveau/core/engine/fifo/nve0.h    |   1 +
>>   .../gpu/drm/nouveau/core/engine/graph/ctxgk20a.c   |  53 +++++++
>>   .../gpu/drm/nouveau/core/engine/graph/ctxnvc0.h    |   9 ++
>>   .../gpu/drm/nouveau/core/engine/graph/ctxnve4.c    |  14 +-
>>   drivers/gpu/drm/nouveau/core/engine/graph/gk20a.c  |  47 ++++++
>>   drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c   |  13 +-
>>   drivers/gpu/drm/nouveau/core/engine/graph/nvc0.h   |   2 +
>>   drivers/gpu/drm/nouveau/core/engine/graph/nve4.c   |   4 +-
>>   drivers/gpu/drm/nouveau/core/include/engine/fifo.h |   1 +
>>   .../gpu/drm/nouveau/core/include/engine/graph.h    |   1 +
>>   drivers/gpu/drm/nouveau/core/include/subdev/fb.h   |   1 +
>>   drivers/gpu/drm/nouveau/core/include/subdev/ibus.h |   1 +
>>   drivers/gpu/drm/nouveau/core/subdev/bar/base.c     |   6 +-
>>   drivers/gpu/drm/nouveau/core/subdev/bar/nvc0.c     | 114 +++++++-------
>>   drivers/gpu/drm/nouveau/core/subdev/fb/gk20a.c     |  56 +++++++
>>   drivers/gpu/drm/nouveau/core/subdev/fb/priv.h      |   1 +
>>   drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c  | 167 +++++++++++++++++++++
>>   drivers/gpu/drm/nouveau/core/subdev/ibus/gk20a.c   | 103 +++++++++++++
>>   21 files changed, 583 insertions(+), 69 deletions(-)
>>   create mode 100644 drivers/gpu/drm/nouveau/core/engine/fifo/gk20a.c
>>   create mode 100644 drivers/gpu/drm/nouveau/core/engine/graph/ctxgk20a.c
>>   create mode 100644 drivers/gpu/drm/nouveau/core/engine/graph/gk20a.c
>>   create mode 100644 drivers/gpu/drm/nouveau/core/subdev/fb/gk20a.c
>>   create mode 100644 drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c
>>   create mode 100644 drivers/gpu/drm/nouveau/core/subdev/ibus/gk20a.c
>>
>> --
>> 1.9.2
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@nvidia.com>
To: Ben Skeggs <skeggsb@gmail.com>
Cc: Ben Skeggs <bskeggs@redhat.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v3 0/9] drm/nouveau: support for GK20A, cont'd
Date: Thu, 1 May 2014 16:14:56 +0900	[thread overview]
Message-ID: <5361F470.5050306@nvidia.com> (raw)
In-Reply-To: <CACAvsv5x6uZcTGUTa3-wBRo0sJ-557sJ_d8r0kscODhr18yzBA@mail.gmail.com>

On 05/01/2014 04:11 PM, Ben Skeggs wrote:
> On Fri, Apr 25, 2014 at 5:19 PM, Alexandre Courbot <acourbot@nvidia.com> wrote:
>> Changes since v2:
>> - Enabled software class
>> - Removed unneeded changes to nouveau_accel_init()
>> - Replaced use of architecture-private pfn_to_dma() and dma_to_pfn() with
>>    the portable page_to_phys()/phys_to_page()
> page_to_phys() looks well defined and used everywhere, phys_to_page()
> not so much (including on amd64) :(

Argh, dammit. Now I *really* wonder what one is supposed to use in such 
cases...

Let me come with a v4 then. I will address the other issue with external 
firmware at the same time.

Sorry for the inconvenience.

>
>> - Fixed incorrect comment/commit log talking about bytes instead of words
>>
>> Hope this looks good! Once this gets merged the next set will be to use this
>> driver on Jetson and Venice2 boards.
>>
>> Cheers,
>>
>> Alexandre Courbot (9):
>>    drm/nouveau/bar: only ioremap BAR3 if it exists
>>    drm/nouveau/bar/nvc0: support chips without BAR3
>>    drm/nouveau/ibus: add GK20A support
>>    drm/nouveau/fb: add GK20A support
>>    drm/nouveau/fifo: add GK20A support
>>    drm/nouveau/graph: enable when using external firmware
>>    drm/nouveau/graph: pad firmware code at load time
>>    drm/nouveau/graph: add GK20A support
>>    drm/nouveau: support for probing GK20A
>>
>>   drivers/gpu/drm/nouveau/Makefile                   |   6 +
>>   drivers/gpu/drm/nouveau/core/engine/device/nve0.c  |  17 +++
>>   drivers/gpu/drm/nouveau/core/engine/fifo/gk20a.c   |  35 +++++
>>   drivers/gpu/drm/nouveau/core/engine/fifo/nve0.h    |   1 +
>>   .../gpu/drm/nouveau/core/engine/graph/ctxgk20a.c   |  53 +++++++
>>   .../gpu/drm/nouveau/core/engine/graph/ctxnvc0.h    |   9 ++
>>   .../gpu/drm/nouveau/core/engine/graph/ctxnve4.c    |  14 +-
>>   drivers/gpu/drm/nouveau/core/engine/graph/gk20a.c  |  47 ++++++
>>   drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c   |  13 +-
>>   drivers/gpu/drm/nouveau/core/engine/graph/nvc0.h   |   2 +
>>   drivers/gpu/drm/nouveau/core/engine/graph/nve4.c   |   4 +-
>>   drivers/gpu/drm/nouveau/core/include/engine/fifo.h |   1 +
>>   .../gpu/drm/nouveau/core/include/engine/graph.h    |   1 +
>>   drivers/gpu/drm/nouveau/core/include/subdev/fb.h   |   1 +
>>   drivers/gpu/drm/nouveau/core/include/subdev/ibus.h |   1 +
>>   drivers/gpu/drm/nouveau/core/subdev/bar/base.c     |   6 +-
>>   drivers/gpu/drm/nouveau/core/subdev/bar/nvc0.c     | 114 +++++++-------
>>   drivers/gpu/drm/nouveau/core/subdev/fb/gk20a.c     |  56 +++++++
>>   drivers/gpu/drm/nouveau/core/subdev/fb/priv.h      |   1 +
>>   drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c  | 167 +++++++++++++++++++++
>>   drivers/gpu/drm/nouveau/core/subdev/ibus/gk20a.c   | 103 +++++++++++++
>>   21 files changed, 583 insertions(+), 69 deletions(-)
>>   create mode 100644 drivers/gpu/drm/nouveau/core/engine/fifo/gk20a.c
>>   create mode 100644 drivers/gpu/drm/nouveau/core/engine/graph/ctxgk20a.c
>>   create mode 100644 drivers/gpu/drm/nouveau/core/engine/graph/gk20a.c
>>   create mode 100644 drivers/gpu/drm/nouveau/core/subdev/fb/gk20a.c
>>   create mode 100644 drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c
>>   create mode 100644 drivers/gpu/drm/nouveau/core/subdev/ibus/gk20a.c
>>
>> --
>> 1.9.2
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel


  parent reply	other threads:[~2014-05-01  7:14 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25  7:19 [PATCH v3 0/9] drm/nouveau: support for GK20A, cont'd Alexandre Courbot
2014-04-25  7:19 ` Alexandre Courbot
     [not found] ` <1398410396-23338-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-04-25  7:19   ` [PATCH v3 1/9] drm/nouveau/bar: only ioremap BAR3 if it exists Alexandre Courbot
2014-04-25  7:19     ` Alexandre Courbot
2014-04-25  7:19   ` [PATCH v3 2/9] drm/nouveau/bar/nvc0: support chips without BAR3 Alexandre Courbot
2014-04-25  7:19     ` Alexandre Courbot
2014-04-25  7:19   ` [PATCH v3 3/9] drm/nouveau/ibus: add GK20A support Alexandre Courbot
2014-04-25  7:19     ` Alexandre Courbot
2014-04-25  7:19   ` [PATCH v3 4/9] drm/nouveau/fb: " Alexandre Courbot
2014-04-25  7:19     ` Alexandre Courbot
2014-04-25  7:19   ` [PATCH v3 5/9] drm/nouveau/fifo: " Alexandre Courbot
2014-04-25  7:19     ` Alexandre Courbot
2014-04-25  7:19   ` [PATCH v3 6/9] drm/nouveau/graph: enable when using external firmware Alexandre Courbot
2014-04-25  7:19     ` Alexandre Courbot
     [not found]     ` <1398410396-23338-7-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-04-28  2:10       ` Ben Skeggs
2014-04-28  2:10         ` [Nouveau] " Ben Skeggs
2014-04-28  6:57         ` Thierry Reding
2014-04-28  6:57           ` Thierry Reding
2014-04-28 23:52           ` Ben Skeggs
2014-04-28 23:52             ` Ben Skeggs
     [not found]         ` <CACAvsv51Ju_ZqJfNU5GzzEmDzf2Fr6Xr_5yGRtfqOQRVTgvDPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-01  4:53           ` Alexandre Courbot
2014-05-01  4:53             ` [Nouveau] " Alexandre Courbot
     [not found]             ` <CAAVeFuK7H3zK3CaxYT4MP4pY=r2dF0oojjYHG1DGRf7Sq0TExg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-01  4:59               ` Ben Skeggs
2014-05-01  4:59                 ` Ben Skeggs
2014-04-25  7:19   ` [PATCH v3 8/9] drm/nouveau/graph: add GK20A support Alexandre Courbot
2014-04-25  7:19     ` Alexandre Courbot
2014-05-01  7:11   ` [PATCH v3 0/9] drm/nouveau: support for GK20A, cont'd Ben Skeggs
2014-05-01  7:11     ` Ben Skeggs
     [not found]     ` <CACAvsv5x6uZcTGUTa3-wBRo0sJ-557sJ_d8r0kscODhr18yzBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-01  7:14       ` Alexandre Courbot [this message]
2014-05-01  7:14         ` Alexandre Courbot
2014-04-25  7:19 ` [PATCH v3 7/9] drm/nouveau/graph: pad firmware code at load time Alexandre Courbot
2014-04-25  7:19   ` Alexandre Courbot
2014-04-25  7:19 ` [PATCH v3 9/9] drm/nouveau: support for probing GK20A Alexandre Courbot
2014-04-25  7:19   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5361F470.5050306@nvidia.com \
    --to=acourbot-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.